* [PATCH] Input: restore EV_ABS ABS_RESERVED @ 2018-12-05 23:03 Peter Hutterer 2018-12-06 8:36 ` Martin Kepplinger 0 siblings, 1 reply; 7+ messages in thread From: Peter Hutterer @ 2018-12-05 23:03 UTC (permalink / raw) To: Benjamin Tissoires, linux-input; +Cc: Dmitry Torokhov, linux-kernel ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of ffe0e7cf290f5c9 when the high-resolution scrolling code was removed. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> --- include/uapi/linux/input-event-codes.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h index 3eb5a4c3d60a..ae366b87426a 100644 --- a/include/uapi/linux/input-event-codes.h +++ b/include/uapi/linux/input-event-codes.h @@ -752,6 +752,15 @@ #define ABS_MISC 0x28 +/* + * 0x2e is reserved and should not be used in input drivers. + * It was used by HID as ABS_MISC+6 and userspace needs to detect if + * the next ABS_* event is correct or is just ABS_MISC + n. + * We define here ABS_RESERVED so userspace can rely on it and detect + * the situation described above. + */ +#define ABS_RESERVED 0x2e + #define ABS_MT_SLOT 0x2f /* MT slot being modified */ #define ABS_MT_TOUCH_MAJOR 0x30 /* Major axis of touching ellipse */ #define ABS_MT_TOUCH_MINOR 0x31 /* Minor axis (omit if circular) */ -- 2.19.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: restore EV_ABS ABS_RESERVED 2018-12-05 23:03 [PATCH] Input: restore EV_ABS ABS_RESERVED Peter Hutterer @ 2018-12-06 8:36 ` Martin Kepplinger 2018-12-06 9:24 ` Benjamin Tissoires 0 siblings, 1 reply; 7+ messages in thread From: Martin Kepplinger @ 2018-12-06 8:36 UTC (permalink / raw) To: Peter Hutterer, Benjamin Tissoires, linux-input Cc: Dmitry Torokhov, linux-kernel [-- Attachment #1: Type: text/plain, Size: 316 bytes --] On 06.12.18 00:03, Peter Hutterer wrote: > ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of > ffe0e7cf290f5c9 when the high-resolution scrolling code was removed. > > Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Martin Kepplinger <martin.kepplinger@ginzinger.com> [-- Attachment #2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 3616 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: restore EV_ABS ABS_RESERVED 2018-12-06 8:36 ` Martin Kepplinger @ 2018-12-06 9:24 ` Benjamin Tissoires 2018-12-06 22:46 ` Peter Hutterer 0 siblings, 1 reply; 7+ messages in thread From: Benjamin Tissoires @ 2018-12-06 9:24 UTC (permalink / raw) To: Martin Kepplinger Cc: Peter Hutterer, linux-input, Dmitry Torokhov, linux-kernel On Thu, Dec 6, 2018 at 9:36 AM Martin Kepplinger <martin.kepplinger@ginzinger.com> wrote: > > On 06.12.18 00:03, Peter Hutterer wrote: > > ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of > > ffe0e7cf290f5c9 when the high-resolution scrolling code was removed. > > > > Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> > > Reviewed-by: Martin Kepplinger <martin.kepplinger@ginzinger.com> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Dmitry, I do not think this one will conflict with the high res wheel patches, so I think it should be safe to take it through your tree. If you think it'll be an issue, I can also take it through the HID one. Cheers, Benjamin ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: restore EV_ABS ABS_RESERVED 2018-12-06 9:24 ` Benjamin Tissoires @ 2018-12-06 22:46 ` Peter Hutterer 2018-12-06 22:56 ` Dmitry Torokhov 0 siblings, 1 reply; 7+ messages in thread From: Peter Hutterer @ 2018-12-06 22:46 UTC (permalink / raw) To: Benjamin Tissoires Cc: Martin Kepplinger, linux-input, Dmitry Torokhov, linux-kernel On Thu, Dec 06, 2018 at 10:24:11AM +0100, Benjamin Tissoires wrote: > On Thu, Dec 6, 2018 at 9:36 AM Martin Kepplinger > <martin.kepplinger@ginzinger.com> wrote: > > > > On 06.12.18 00:03, Peter Hutterer wrote: > > > ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of > > > ffe0e7cf290f5c9 when the high-resolution scrolling code was removed. > > > > > > Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> > > > > Reviewed-by: Martin Kepplinger <martin.kepplinger@ginzinger.com> > > Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > Dmitry, I do not think this one will conflict with the high res wheel > patches, so I think it should be safe to take it through your tree. > If you think it'll be an issue, I can also take it through the HID one. fwiw, patch was made on top of v4.20-rc5, so it shouldn't conflict. Cheers, Peter ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: restore EV_ABS ABS_RESERVED 2018-12-06 22:46 ` Peter Hutterer @ 2018-12-06 22:56 ` Dmitry Torokhov 2018-12-07 14:28 ` Benjamin Tissoires 0 siblings, 1 reply; 7+ messages in thread From: Dmitry Torokhov @ 2018-12-06 22:56 UTC (permalink / raw) To: Peter Hutterer Cc: Benjamin Tissoires, Martin Kepplinger, linux-input, linux-kernel On Fri, Dec 07, 2018 at 08:46:05AM +1000, Peter Hutterer wrote: > On Thu, Dec 06, 2018 at 10:24:11AM +0100, Benjamin Tissoires wrote: > > On Thu, Dec 6, 2018 at 9:36 AM Martin Kepplinger > > <martin.kepplinger@ginzinger.com> wrote: > > > > > > On 06.12.18 00:03, Peter Hutterer wrote: > > > > ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of > > > > ffe0e7cf290f5c9 when the high-resolution scrolling code was removed. > > > > > > > > Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> > > > > > > Reviewed-by: Martin Kepplinger <martin.kepplinger@ginzinger.com> > > > > Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > > > Dmitry, I do not think this one will conflict with the high res wheel > > patches, so I think it should be safe to take it through your tree. > > If you think it'll be an issue, I can also take it through the HID one. > > fwiw, patch was made on top of v4.20-rc5, so it shouldn't conflict. My tree is behind that ;) so I would actually prefer if Benjamin/Jiri would take it through their tree with my: Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: restore EV_ABS ABS_RESERVED 2018-12-06 22:56 ` Dmitry Torokhov @ 2018-12-07 14:28 ` Benjamin Tissoires 2018-12-10 10:24 ` Jiri Kosina 0 siblings, 1 reply; 7+ messages in thread From: Benjamin Tissoires @ 2018-12-07 14:28 UTC (permalink / raw) To: Dmitry Torokhov, Jiri Kosina Cc: Peter Hutterer, Martin Kepplinger, linux-input, linux-kernel On Thu, Dec 6, 2018 at 11:56 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > On Fri, Dec 07, 2018 at 08:46:05AM +1000, Peter Hutterer wrote: > > On Thu, Dec 06, 2018 at 10:24:11AM +0100, Benjamin Tissoires wrote: > > > On Thu, Dec 6, 2018 at 9:36 AM Martin Kepplinger > > > <martin.kepplinger@ginzinger.com> wrote: > > > > > > > > On 06.12.18 00:03, Peter Hutterer wrote: > > > > > ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of > > > > > ffe0e7cf290f5c9 when the high-resolution scrolling code was removed. > > > > > > > > > > Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> > > > > > > > > Reviewed-by: Martin Kepplinger <martin.kepplinger@ginzinger.com> > > > > > > Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > > > > > Dmitry, I do not think this one will conflict with the high res wheel > > > patches, so I think it should be safe to take it through your tree. > > > If you think it'll be an issue, I can also take it through the HID one. > > > > fwiw, patch was made on top of v4.20-rc5, so it shouldn't conflict. > > My tree is behind that ;) so I would actually prefer if Benjamin/Jiri > would take it through their tree with my: > > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > OK, thanks Dmitry. Jiri, I have pushed this in for-4.20/upstream-fixes. I think the branch has enough now to justify a PR towards Linus. I believe https://patchwork.kernel.org/patch/10693337/ would be a good material too, but OTOH, this only happens when the device fails at probing, so maybe not so urgent. Cheers, Benjamin > Thanks. > > -- > Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: restore EV_ABS ABS_RESERVED 2018-12-07 14:28 ` Benjamin Tissoires @ 2018-12-10 10:24 ` Jiri Kosina 0 siblings, 0 replies; 7+ messages in thread From: Jiri Kosina @ 2018-12-10 10:24 UTC (permalink / raw) To: Benjamin Tissoires Cc: Dmitry Torokhov, Peter Hutterer, Martin Kepplinger, linux-input, linux-kernel On Fri, 7 Dec 2018, Benjamin Tissoires wrote: > OK, thanks Dmitry. > > Jiri, I have pushed this in for-4.20/upstream-fixes. > > I think the branch has enough now to justify a PR towards Linus. Agreed. I will be sending it today. Thanks, -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-12-10 10:24 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-12-05 23:03 [PATCH] Input: restore EV_ABS ABS_RESERVED Peter Hutterer 2018-12-06 8:36 ` Martin Kepplinger 2018-12-06 9:24 ` Benjamin Tissoires 2018-12-06 22:46 ` Peter Hutterer 2018-12-06 22:56 ` Dmitry Torokhov 2018-12-07 14:28 ` Benjamin Tissoires 2018-12-10 10:24 ` Jiri Kosina
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).