From: Lee Jones <lee.jones@linaro.org>
To: Oskari Lemmela <oskari@lemmela.net>
Cc: Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Quentin Schulz <quentin.schulz@bootlin.com>,
Vasily Khoruzhick <anarsoul@gmail.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803
Date: Fri, 7 Dec 2018 16:40:11 +0000 [thread overview]
Message-ID: <20181207164011.GI26661@dell> (raw)
In-Reply-To: <20181120175211.3913-9-oskari@lemmela.net>
On Tue, 20 Nov 2018, Oskari Lemmela wrote:
> Parts of the AXP803 are compatible with their counterparts on the AXP813.
> These include the GPIO, ADC, AC and battery power supplies.
>
> Signed-off-by: Oskari Lemmela <oskari@lemmela.net>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Tested-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> drivers/mfd/axp20x.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index dfc3cff1d08b..e415b967d38c 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -728,11 +728,26 @@ static const struct mfd_cell axp288_cells[] = {
>
> static const struct mfd_cell axp803_cells[] = {
> {
> + .name = "axp20x-gpio",
> + .of_compatible = "x-powers,axp813-gpio",
> + }, {
> .name = "axp221-pek",
> .num_resources = ARRAY_SIZE(axp803_pek_resources),
> .resources = axp803_pek_resources,
> },
> { .name = "axp20x-regulator" },
> + {
> + .name = "axp813-adc",
> + .of_compatible = "x-powers,axp813-adc",
> + }, {
> + .name = "axp20x-battery-power-supply",
> + .of_compatible = "x-powers,axp813-battery-power-supply",
> + }, {
> + .name = "axp20x-ac-power-supply",
> + .of_compatible = "x-powers,axp813-ac-power-supply",
> + .num_resources = ARRAY_SIZE(axp20x_ac_power_supply_resources),
> + .resources = axp20x_ac_power_supply_resources,
> + },
> };
My OCD-dar is going crazy.
Why haven't you used the same alignment as is already there?
If it starts to run over 80-chars then bring the others back.
Also why is there a single liner shoved in the middle of the
multi-line entries? Please move the singles to the top or the
bottom.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-12-07 16:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 17:52 [PATCH v6 0/8] AXP8x3 AC and battery power supply support Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 1/8] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 2/8] ARM: dts: axp81x: add AC power supply subnode Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 3/8] arm64: dts: allwinner: axp803: add AC and battery power supplies Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 4/8] arm64: dts: allwinner: a64: sopine-baseboard: enable " Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 5/8] arm64: dts: allwinner: a64: pinebook: " Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 6/8] power: supply: add AC power supply driver for AXP813 Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 7/8] mfd: axp20x: Add AC power supply cell " Oskari Lemmela
2018-12-07 16:40 ` Lee Jones
2018-11-20 17:52 ` [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803 Oskari Lemmela
2018-12-07 16:40 ` Lee Jones [this message]
2018-12-07 18:58 ` Vasily Khoruzhick
2018-12-07 19:22 ` Lee Jones
2018-12-08 15:05 ` Quentin Schulz
2018-12-10 6:27 ` Lee Jones
2018-12-10 8:29 ` Quentin Schulz
2018-12-08 18:10 ` Oskari Lemmelä
2018-12-10 6:27 ` Lee Jones
2018-11-30 8:31 ` [PATCH v6 0/8] AXP8x3 AC and battery power supply support Chen-Yu Tsai
2018-12-05 18:00 ` Sebastian Reichel
2018-12-07 7:28 ` Lee Jones
2018-12-07 7:45 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207164011.GI26661@dell \
--to=lee.jones@linaro.org \
--cc=anarsoul@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=oskari@lemmela.net \
--cc=quentin.schulz@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).