From: Quentin Schulz <quentin.schulz@bootlin.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Vasily Khoruzhick <anarsoul@gmail.com>,
Oskari Lemmela <oskari@lemmela.net>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
linux-pm@vger.kernel.org, devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
arm-linux <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803
Date: Sat, 8 Dec 2018 16:05:26 +0100 [thread overview]
Message-ID: <20181208150526.uceviwfwqskfwovm@qschulz> (raw)
In-Reply-To: <20181207192237.GK26661@dell>
[-- Attachment #1: Type: text/plain, Size: 2004 bytes --]
Hi Lee,
On Fri, Dec 07, 2018 at 07:22:37PM +0000, Lee Jones wrote:
> On Fri, 07 Dec 2018, Vasily Khoruzhick wrote:
>
> > On Fri, Dec 7, 2018 at 8:40 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > > My OCD-dar is going crazy.
> > >
> > > Why haven't you used the same alignment as is already there?
> > >
> > > If it starts to run over 80-chars then bring the others back.
> > >
> > > Also why is there a single liner shoved in the middle of the
> > > multi-line entries? Please move the singles to the top or the
> > > bottom.
> >
> > Hi Lee,
> >
> > Could you please reformat it in the way that makes your OCD-dar happy?
> > It would be really nice to get
>
> I'm afraid not, for a multitude of reasons.
>
> The most important of which surround testing.
>
> > AC and battery support for APX8x3 merged -- it'll make Pinebook and
> > Teres-I pretty well supported by mainline kernel.
>
> That's great. A worthy cause indeed. So I'm sure you guys will want
> to turn the patch around in short order so that it's applied in time
> for the next merge window.
>
Aren't the MFD cells probed in order?
In that case, it makes little sense to short order them for this
particular device (X-Powers PMICs in general). It will just make the
system boot slower because of probe deferring.
Why? As explained by Chen-Yu in v3[1], axp-gpios can be muxed as
regulators, thus should be probed before axp-regulators. axp-adc is
often used by axp-battery, axp-usb-power, axp-ac-power, thus should be
probed beforehand as well.
For the alignment that also triggered your OCD, I can send you a patch
the day you merge this one if it can help. I sent a few patches for this
driver that didn't respect the alignment so I'm fine fixing the mfd
cells (and eventually re-order them as I saw a few axp-gpio cells being
declared after axp-regulators).
Does that make this patch OK for you, Lee?
Thanks,
Quentin
[1] https://lkml.org/lkml/2018/10/11/338
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-08 15:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 17:52 [PATCH v6 0/8] AXP8x3 AC and battery power supply support Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 1/8] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 2/8] ARM: dts: axp81x: add AC power supply subnode Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 3/8] arm64: dts: allwinner: axp803: add AC and battery power supplies Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 4/8] arm64: dts: allwinner: a64: sopine-baseboard: enable " Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 5/8] arm64: dts: allwinner: a64: pinebook: " Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 6/8] power: supply: add AC power supply driver for AXP813 Oskari Lemmela
2018-11-20 17:52 ` [PATCH v6 7/8] mfd: axp20x: Add AC power supply cell " Oskari Lemmela
2018-12-07 16:40 ` Lee Jones
2018-11-20 17:52 ` [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803 Oskari Lemmela
2018-12-07 16:40 ` Lee Jones
2018-12-07 18:58 ` Vasily Khoruzhick
2018-12-07 19:22 ` Lee Jones
2018-12-08 15:05 ` Quentin Schulz [this message]
2018-12-10 6:27 ` Lee Jones
2018-12-10 8:29 ` Quentin Schulz
2018-12-08 18:10 ` Oskari Lemmelä
2018-12-10 6:27 ` Lee Jones
2018-11-30 8:31 ` [PATCH v6 0/8] AXP8x3 AC and battery power supply support Chen-Yu Tsai
2018-12-05 18:00 ` Sebastian Reichel
2018-12-07 7:28 ` Lee Jones
2018-12-07 7:45 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181208150526.uceviwfwqskfwovm@qschulz \
--to=quentin.schulz@bootlin.com \
--cc=anarsoul@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=oskari@lemmela.net \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).