* [PATCH] fjes: convert to DEFINE_SHOW_ATTRIBUTE
@ 2018-12-10 15:57 Yangtao Li
2018-12-10 20:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-12-10 15:57 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/net/fjes/fjes_debugfs.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/net/fjes/fjes_debugfs.c b/drivers/net/fjes/fjes_debugfs.c
index 30052ebd52bf..7fed88ea27a5 100644
--- a/drivers/net/fjes/fjes_debugfs.c
+++ b/drivers/net/fjes/fjes_debugfs.c
@@ -62,19 +62,7 @@ static int fjes_dbg_status_show(struct seq_file *m, void *v)
return 0;
}
-
-static int fjes_dbg_status_open(struct inode *inode, struct file *file)
-{
- return single_open(file, fjes_dbg_status_show, inode->i_private);
-}
-
-static const struct file_operations fjes_dbg_status_fops = {
- .owner = THIS_MODULE,
- .open = fjes_dbg_status_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(fjes_dbg_status);
void fjes_dbg_adapter_init(struct fjes_adapter *adapter)
{
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fjes: convert to DEFINE_SHOW_ATTRIBUTE
2018-12-10 15:57 [PATCH] fjes: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
@ 2018-12-10 20:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-12-10 20:05 UTC (permalink / raw)
To: tiny.windzz; +Cc: netdev, linux-kernel
From: Yangtao Li <tiny.windzz@gmail.com>
Date: Mon, 10 Dec 2018 10:57:38 -0500
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-10 20:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-10 15:57 [PATCH] fjes: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-10 20:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).