linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@mips.com>
To: Firoz Khan <firoz.khan@linaro.org>
Cc: "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	James Hogan <jhogan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	"y2038@lists.linaro.org" <y2038@lists.linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"deepa.kernel@gmail.com" <deepa.kernel@gmail.com>,
	"marcin.juszkiewicz@linaro.org" <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'
Date: Mon, 10 Dec 2018 19:51:46 +0000	[thread overview]
Message-ID: <20181210195144.dvprpyxyddusyb5c@pburton-laptop> (raw)
In-Reply-To: <1544073508-13720-4-git-send-email-firoz.khan@linaro.org>

Hi Firoz,

On Thu, Dec 06, 2018 at 10:48:24AM +0530, Firoz Khan wrote:
> diff --git a/arch/mips/include/uapi/asm/sgidefs.h b/arch/mips/include/uapi/asm/sgidefs.h
> index 26143e3..0364eec 100644
> --- a/arch/mips/include/uapi/asm/sgidefs.h
> +++ b/arch/mips/include/uapi/asm/sgidefs.h
> @@ -40,6 +40,6 @@
>   */
>  #define _MIPS_SIM_ABI32		1
>  #define _MIPS_SIM_NABI32	2
> -#define _MIPS_SIM_ABI64		3
> +#define _MIPS_SIM_ABIN64	3

Whilst I agree with changing our own definitions & filenames to use n64,
this macro actually reflects naming used by the toolchain. ie:

    $ mips-linux-gcc -mips64 -mabi=64 -dM -E - </dev/null | grep ABI64
    #define _ABI64 3
    #define _MIPS_SIM _ABI64

Our macro here is used to compare against _MIPS_SIM provided by the
toolchain, so for consistency I think we should keep the same name for
the macro that the toolchain uses.

And I realise that undoing that but keeping n64 in our own filenames &
macros is another type of inconsistency, but something imperfect is
unavoidable at this point given that the engineers way back when decided
to use "ABI64" for n64.

Thanks,
    Paul

  reply	other threads:[~2018-12-10 19:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06  5:18 [PATCH v4 0/7] mips: system call table generation support Firoz Khan
2018-12-06  5:18 ` [PATCH v4 1/7] mips: add __NR_syscalls along with __NR_Linux_syscalls Firoz Khan
2018-12-06  5:18 ` [PATCH v4 2/7] mips: remove unused macros Firoz Khan
2018-12-06  5:18 ` [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64' Firoz Khan
2018-12-10 19:51   ` Paul Burton [this message]
2018-12-10 23:32     ` Maciej W. Rozycki
2018-12-10 23:46       ` Paul Burton
2018-12-11 10:58         ` Maciej W. Rozycki
2018-12-11  8:45     ` Firoz Khan
2018-12-11 18:59       ` Paul Burton
2018-12-12  4:34         ` Firoz Khan
2018-12-12 22:28           ` Paul Burton
2018-12-13  8:53             ` Firoz Khan
2018-12-13 20:15               ` Paul Burton
2018-12-14  5:50                 ` Firoz Khan
2018-12-06  5:18 ` [PATCH v4 4/7] mips: add +1 to __NR_syscalls in uapi header Firoz Khan
2018-12-06  5:18 ` [PATCH v4 5/7] mips: remove syscall table entries Firoz Khan
2018-12-06  5:18 ` [PATCH v4 6/7] mips: add system call table generation support Firoz Khan
2018-12-06  5:18 ` [PATCH v4 7/7] mips: generate uapi header and system call table files Firoz Khan
2018-12-10  5:35 ` [PATCH v4 0/7] mips: system call table generation support Firoz Khan
2018-12-10  5:41   ` Paul Burton
2018-12-10  8:05     ` Firoz Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210195144.dvprpyxyddusyb5c@pburton-laptop \
    --to=paul.burton@mips.com \
    --cc=arnd@arndb.de \
    --cc=deepa.kernel@gmail.com \
    --cc=firoz.khan@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhogan@kernel.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pombredanne@nexb.com \
    --cc=ralf@linux-mips.org \
    --cc=tglx@linutronix.de \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).