From: Firoz Khan <firoz.khan@linaro.org>
To: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'
Date: Wed, 12 Dec 2018 10:04:47 +0530 [thread overview]
Message-ID: <CALxhOngErLD7+CEhgSPwQUnGg7YEFTcH-v6dhR0j55SvEg1FoA@mail.gmail.com> (raw)
In-Reply-To: <20181211185947.gnaachztyh3ils7o@pburton-laptop>
Hi Paul,
On Wed, 12 Dec 2018 at 00:29, Paul Burton <paul.burton@mips.com> wrote:
> > Will this below change will help?
> >
> > #define _MIPS_SIM_ABI32 1
> > #define _MIPS_SIM_NABI32 2
> > #define _MIPS_SIM_ABI64 3
> > +#define _MIPS_SIM_ABIN64 _MIPS_SIM_ABI64
>
> Hmm, I think I'd prefer that we just keep using _MIPS_SIM_ABI64.
Sure, I think '64' to 'n64' conversion must be remove it from this patch
series.I can send v5 without '64' to 'n64' conversion.
If we rename '64' to 'n64' in half of the place and this _MIPS_SIM_ABI64
if we half to keep it in same looks not good (according to me).
(FYI, This macro name - _MIPS_SIM_ABIN64 must be _MIPS_SIM_NABI64
and defintion will be:
+#define _MIPS_SIM_NABI64 _MIPS_SIM_ABI64)
So If you confirm I can send v5 without '64' to 'n64' conversion (not just above
one, completely from this patch series). Or uou can take a call just
keep this macro -
_MIPS_SIM_ABI64 as it is and change it rest of the place.
Thanks
Firoz
next prev parent reply other threads:[~2018-12-12 4:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 5:18 [PATCH v4 0/7] mips: system call table generation support Firoz Khan
2018-12-06 5:18 ` [PATCH v4 1/7] mips: add __NR_syscalls along with __NR_Linux_syscalls Firoz Khan
2018-12-06 5:18 ` [PATCH v4 2/7] mips: remove unused macros Firoz Khan
2018-12-06 5:18 ` [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64' Firoz Khan
2018-12-10 19:51 ` Paul Burton
2018-12-10 23:32 ` Maciej W. Rozycki
2018-12-10 23:46 ` Paul Burton
2018-12-11 10:58 ` Maciej W. Rozycki
2018-12-11 8:45 ` Firoz Khan
2018-12-11 18:59 ` Paul Burton
2018-12-12 4:34 ` Firoz Khan [this message]
2018-12-12 22:28 ` Paul Burton
2018-12-13 8:53 ` Firoz Khan
2018-12-13 20:15 ` Paul Burton
2018-12-14 5:50 ` Firoz Khan
2018-12-06 5:18 ` [PATCH v4 4/7] mips: add +1 to __NR_syscalls in uapi header Firoz Khan
2018-12-06 5:18 ` [PATCH v4 5/7] mips: remove syscall table entries Firoz Khan
2018-12-06 5:18 ` [PATCH v4 6/7] mips: add system call table generation support Firoz Khan
2018-12-06 5:18 ` [PATCH v4 7/7] mips: generate uapi header and system call table files Firoz Khan
2018-12-10 5:35 ` [PATCH v4 0/7] mips: system call table generation support Firoz Khan
2018-12-10 5:41 ` Paul Burton
2018-12-10 8:05 ` Firoz Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALxhOngErLD7+CEhgSPwQUnGg7YEFTcH-v6dhR0j55SvEg1FoA@mail.gmail.com \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhogan@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=paul.burton@mips.com \
--cc=pombredanne@nexb.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).