linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/2] dt-bindings: serial: 8250: Add rate limit for serial port input overruns
@ 2018-12-09 22:27 Darwin Dingel
  2018-12-10 23:23 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Darwin Dingel @ 2018-12-09 22:27 UTC (permalink / raw)
  To: gregkh, robh+dt
  Cc: chris.packham, linux-serial, devicetree, linux-kernel, Darwin Dingel

When a serial port continuously experiences input overrun from
(1) continuous receive characters from remote and or (2) hardware
issues, its interrupt handler can preempt other tasks especially
when the system is busy (ie. boot up period). This can cause other
tasks to get starved of processing time from the CPU.

When this dts binding is enabled and input overrun on the serial port
is detected, serial port receive will be throttled to give some breathing
room for processing other tasks. Value provided will be in milliseconds.

&serial0{
	overrun-throttle-ms = <500>;
};

Signed-off-by: Darwin Dingel <darwin.dingel@alliedtelesis.co.nz>
---

Notes:
    Changelog
    v1->v2:
    - Separated dts binding to another patch
    
    v2->v3:
    - Fixed commit message and reviewed-by fields

 Documentation/devicetree/bindings/serial/8250.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/8250.txt b/Documentation/devicetree/bindings/serial/8250.txt
index aeb6db4e35c3..da50321da34d 100644
--- a/Documentation/devicetree/bindings/serial/8250.txt
+++ b/Documentation/devicetree/bindings/serial/8250.txt
@@ -51,6 +51,7 @@ Optional properties:
 - tx-threshold: Specify the TX FIFO low water indication for parts with
   programmable TX FIFO thresholds.
 - resets : phandle + reset specifier pairs
+- overrun-throttle-ms : how long to pause uart rx when input overrun is encountered.
 
 Note:
 * fsl,ns16550:
-- 
2.19.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: serial: 8250: Add rate limit for serial port input overruns
  2018-12-09 22:27 [PATCH v3 1/2] dt-bindings: serial: 8250: Add rate limit for serial port input overruns Darwin Dingel
@ 2018-12-10 23:23 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2018-12-10 23:23 UTC (permalink / raw)
  To: Darwin Dingel
  Cc: gregkh, robh+dt, chris.packham, linux-serial, devicetree,
	linux-kernel, Darwin Dingel

On Mon, 10 Dec 2018 11:27:39 +1300, Darwin Dingel wrote:
> When a serial port continuously experiences input overrun from
> (1) continuous receive characters from remote and or (2) hardware
> issues, its interrupt handler can preempt other tasks especially
> when the system is busy (ie. boot up period). This can cause other
> tasks to get starved of processing time from the CPU.
> 
> When this dts binding is enabled and input overrun on the serial port
> is detected, serial port receive will be throttled to give some breathing
> room for processing other tasks. Value provided will be in milliseconds.
> 
> &serial0{
> 	overrun-throttle-ms = <500>;
> };
> 
> Signed-off-by: Darwin Dingel <darwin.dingel@alliedtelesis.co.nz>
> ---
> 
> Notes:
>     Changelog
>     v1->v2:
>     - Separated dts binding to another patch
>     
>     v2->v3:
>     - Fixed commit message and reviewed-by fields
> 
>  Documentation/devicetree/bindings/serial/8250.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-10 23:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-09 22:27 [PATCH v3 1/2] dt-bindings: serial: 8250: Add rate limit for serial port input overruns Darwin Dingel
2018-12-10 23:23 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).