From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Anthony Yznaga <anthony.yznaga@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"chansen3@cisco.com" <chansen3@cisco.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"willy@infradead.org" <willy@infradead.org>,
"rientjes@google.com" <rientjes@google.com>
Subject: Re: [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures
Date: Tue, 11 Dec 2018 00:00:49 +0000 [thread overview]
Message-ID: <20181211000049.GA19806@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <1543962269-26116-1-git-send-email-anthony.yznaga@oracle.com>
On Tue, Dec 04, 2018 at 02:24:29PM -0800, Anthony Yznaga wrote:
> Because kpagecount_read() fakes success if map counts are not being
> collected, clamp the page count passed to it by walk_pfn() to the pages
> value returned by the preceding call to kpageflags_read().
>
> Fixes: 7f1d23e60718 ("tools/vm/page-types.c: include shared map counts")
> Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> tools/vm/page-types.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c
> index 37908a83ddc2..1ff3a6c0367b 100644
> --- a/tools/vm/page-types.c
> +++ b/tools/vm/page-types.c
> @@ -701,7 +701,7 @@ static void walk_pfn(unsigned long voffset,
> if (kpagecgroup_read(cgi, index, pages) != pages)
> fatal("kpagecgroup returned fewer pages than expected");
>
> - if (kpagecount_read(cnt, index, batch) != pages)
> + if (kpagecount_read(cnt, index, pages) != pages)
> fatal("kpagecount returned fewer pages than expected");
>
> for (i = 0; i < pages; i++)
> --
> 1.8.3.1
>
>
prev parent reply other threads:[~2018-12-11 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 22:24 [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures Anthony Yznaga
2018-12-11 0:00 ` Naoya Horiguchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211000049.GA19806@hori1.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.yznaga@oracle.com \
--cc=chansen3@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).