* [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures
@ 2018-12-04 22:24 Anthony Yznaga
2018-12-11 0:00 ` Naoya Horiguchi
0 siblings, 1 reply; 2+ messages in thread
From: Anthony Yznaga @ 2018-12-04 22:24 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, chansen3, n-horiguchi, vbabka, willy, rientjes
Because kpagecount_read() fakes success if map counts are not being
collected, clamp the page count passed to it by walk_pfn() to the pages
value returned by the preceding call to kpageflags_read().
Fixes: 7f1d23e60718 ("tools/vm/page-types.c: include shared map counts")
Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>
---
tools/vm/page-types.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c
index 37908a83ddc2..1ff3a6c0367b 100644
--- a/tools/vm/page-types.c
+++ b/tools/vm/page-types.c
@@ -701,7 +701,7 @@ static void walk_pfn(unsigned long voffset,
if (kpagecgroup_read(cgi, index, pages) != pages)
fatal("kpagecgroup returned fewer pages than expected");
- if (kpagecount_read(cnt, index, batch) != pages)
+ if (kpagecount_read(cnt, index, pages) != pages)
fatal("kpagecount returned fewer pages than expected");
for (i = 0; i < pages; i++)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures
2018-12-04 22:24 [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures Anthony Yznaga
@ 2018-12-11 0:00 ` Naoya Horiguchi
0 siblings, 0 replies; 2+ messages in thread
From: Naoya Horiguchi @ 2018-12-11 0:00 UTC (permalink / raw)
To: Anthony Yznaga; +Cc: linux-kernel, akpm, chansen3, vbabka, willy, rientjes
On Tue, Dec 04, 2018 at 02:24:29PM -0800, Anthony Yznaga wrote:
> Because kpagecount_read() fakes success if map counts are not being
> collected, clamp the page count passed to it by walk_pfn() to the pages
> value returned by the preceding call to kpageflags_read().
>
> Fixes: 7f1d23e60718 ("tools/vm/page-types.c: include shared map counts")
> Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> tools/vm/page-types.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c
> index 37908a83ddc2..1ff3a6c0367b 100644
> --- a/tools/vm/page-types.c
> +++ b/tools/vm/page-types.c
> @@ -701,7 +701,7 @@ static void walk_pfn(unsigned long voffset,
> if (kpagecgroup_read(cgi, index, pages) != pages)
> fatal("kpagecgroup returned fewer pages than expected");
>
> - if (kpagecount_read(cnt, index, batch) != pages)
> + if (kpagecount_read(cnt, index, pages) != pages)
> fatal("kpagecount returned fewer pages than expected");
>
> for (i = 0; i < pages; i++)
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-11 0:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04 22:24 [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures Anthony Yznaga
2018-12-11 0:00 ` Naoya Horiguchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).