* [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option
@ 2018-12-11 0:05 Nathan Chancellor
2018-12-11 0:10 ` Andrew Jeffery
2018-12-16 0:23 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Nathan Chancellor @ 2018-12-11 0:05 UTC (permalink / raw)
To: Linus Walleij
Cc: Joel Stanley, Andrew Jeffery, linux-gpio, linux-arm-kernel,
linux-aspeed, linux-kernel, Nathan Chancellor
Clang does not support this option:
warning: unknown warning option '-Woverride-init'; did you mean
'-Woverride-module'? [-Wunknown-warning-option]
1 warning generated.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/pinctrl/aspeed/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/aspeed/Makefile b/drivers/pinctrl/aspeed/Makefile
index 191ed0fc1804..790b406aae19 100644
--- a/drivers/pinctrl/aspeed/Makefile
+++ b/drivers/pinctrl/aspeed/Makefile
@@ -1,6 +1,6 @@
# Aspeed pinctrl support
-ccflags-y += -Woverride-init
+ccflags-y += $(call cc-option,-Woverride-init)
obj-$(CONFIG_PINCTRL_ASPEED) += pinctrl-aspeed.o
obj-$(CONFIG_PINCTRL_ASPEED_G4) += pinctrl-aspeed-g4.o
obj-$(CONFIG_PINCTRL_ASPEED_G5) += pinctrl-aspeed-g5.o
--
2.20.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option
2018-12-11 0:05 [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option Nathan Chancellor
@ 2018-12-11 0:10 ` Andrew Jeffery
2018-12-11 0:16 ` Joel Stanley
2018-12-16 0:23 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Jeffery @ 2018-12-11 0:10 UTC (permalink / raw)
To: Nathan Chancellor, Linus Walleij
Cc: Joel Stanley, linux-gpio, linux-arm-kernel, linux-aspeed, linux-kernel
On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> Clang does not support this option:
>
> warning: unknown warning option '-Woverride-init'; did you mean
> '-Woverride-module'? [-Wunknown-warning-option]
> 1 warning generated.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> drivers/pinctrl/aspeed/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/aspeed/Makefile b/drivers/pinctrl/aspeed/Makefile
> index 191ed0fc1804..790b406aae19 100644
> --- a/drivers/pinctrl/aspeed/Makefile
> +++ b/drivers/pinctrl/aspeed/Makefile
> @@ -1,6 +1,6 @@
> # Aspeed pinctrl support
>
> -ccflags-y += -Woverride-init
> +ccflags-y += $(call cc-option,-Woverride-init)
> obj-$(CONFIG_PINCTRL_ASPEED) += pinctrl-aspeed.o
> obj-$(CONFIG_PINCTRL_ASPEED_G4) += pinctrl-aspeed-g4.o
> obj-$(CONFIG_PINCTRL_ASPEED_G5) += pinctrl-aspeed-g5.o
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option
2018-12-11 0:10 ` Andrew Jeffery
@ 2018-12-11 0:16 ` Joel Stanley
2018-12-11 0:25 ` Nathan Chancellor
0 siblings, 1 reply; 5+ messages in thread
From: Joel Stanley @ 2018-12-11 0:16 UTC (permalink / raw)
To: Andrew Jeffery
Cc: Nathan Chancellor, Linus Walleij, linux-gpio, Linux ARM,
linux-aspeed, Linux Kernel Mailing List
On Tue, 11 Dec 2018 at 10:40, Andrew Jeffery <andrew@aj.id.au> wrote:
>
>
>
> On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> > Clang does not support this option:
> >
> > warning: unknown warning option '-Woverride-init'; did you mean
> > '-Woverride-module'? [-Wunknown-warning-option]
> > 1 warning generated.
> >
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Acked-by: Andrew Jeffery <andrew@aj.id.au>
Thanks Nathan.
Andrew explained to me that this warning helps find bugs when
developing the complicated (some would say crazy) set of macros that
this pinctrl driver uses. It would be good to have this warning
available in clang. Do we have a clang issue opened for that?
Acked-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option
2018-12-11 0:16 ` Joel Stanley
@ 2018-12-11 0:25 ` Nathan Chancellor
0 siblings, 0 replies; 5+ messages in thread
From: Nathan Chancellor @ 2018-12-11 0:25 UTC (permalink / raw)
To: Joel Stanley
Cc: Andrew Jeffery, Linus Walleij, linux-gpio, Linux ARM,
linux-aspeed, Linux Kernel Mailing List
On Tue, Dec 11, 2018 at 10:46:26AM +1030, Joel Stanley wrote:
> On Tue, 11 Dec 2018 at 10:40, Andrew Jeffery <andrew@aj.id.au> wrote:
> >
> >
> >
> > On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> > > Clang does not support this option:
> > >
> > > warning: unknown warning option '-Woverride-init'; did you mean
> > > '-Woverride-module'? [-Wunknown-warning-option]
> > > 1 warning generated.
> > >
> > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> >
> > Acked-by: Andrew Jeffery <andrew@aj.id.au>
>
> Thanks Nathan.
>
> Andrew explained to me that this warning helps find bugs when
> developing the complicated (some would say crazy) set of macros that
> this pinctrl driver uses. It would be good to have this warning
> available in clang. Do we have a clang issue opened for that?
>
> Acked-by: Joel Stanley <joel@jms.id.au>
>
> Cheers,
>
> Joel
Hi Joel,
I just opened https://github.com/ClangBuiltLinux/linux/issues/293.
I searched the LLVM issue tracker and haven't see any reference of this.
I can file an issue but if you are a little more familiar with this
warning, you are welcome to do it instead.
Thanks for the quick response,
Nathan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option
2018-12-11 0:05 [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option Nathan Chancellor
2018-12-11 0:10 ` Andrew Jeffery
@ 2018-12-16 0:23 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2018-12-16 0:23 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Joel Stanley, Andrew Jeffery, open list:GPIO SUBSYSTEM,
Linux ARM, linux-aspeed, linux-kernel
On Tue, Dec 11, 2018 at 1:05 AM Nathan Chancellor
<natechancellor@gmail.com> wrote:
> Clang does not support this option:
>
> warning: unknown warning option '-Woverride-init'; did you mean
> '-Woverride-module'? [-Wunknown-warning-option]
> 1 warning generated.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Patch applied with the ACKs!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-16 0:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11 0:05 [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option Nathan Chancellor
2018-12-11 0:10 ` Andrew Jeffery
2018-12-11 0:16 ` Joel Stanley
2018-12-11 0:25 ` Nathan Chancellor
2018-12-16 0:23 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).