* [PATCH] net/ibmvnic: Remove tests of member address
@ 2018-12-11 4:20 Wen Yang
2018-12-14 21:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wen Yang @ 2018-12-11 4:20 UTC (permalink / raw)
To: Thomas Falcon, John Allen, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman
Cc: netdev, linuxppc-dev, linux-kernel, cheng.shengyu, Wen Yang,
David S. Miller
The driver was checking for non-NULL address.
- adapter->napi[i]
This is pointless as these will be always non-NULL, since the
'dapter->napi' is allocated in init_napi().
It is safe to get rid of useless checks for addresses to fix the
coccinelle warning:
>>drivers/net/ethernet/ibm/ibmvnic.c: test of a variable/field address
Since such statements always return true, they are redundant.
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Michael Ellerman <mpe@ellerman.id.au>
CC: Thomas Falcon <tlfalcon@linux.ibm.com>
CC: John Allen <jallen@linux.ibm.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: linuxppc-dev@lists.ozlabs.org
CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
drivers/net/ethernet/ibm/ibmvnic.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index ed50b8dee44f..14d00985f087 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -773,11 +773,8 @@ static void release_napi(struct ibmvnic_adapter *adapter)
return;
for (i = 0; i < adapter->num_active_rx_napi; i++) {
- if (&adapter->napi[i]) {
- netdev_dbg(adapter->netdev,
- "Releasing napi[%d]\n", i);
- netif_napi_del(&adapter->napi[i]);
- }
+ netdev_dbg(adapter->netdev, "Releasing napi[%d]\n", i);
+ netif_napi_del(&adapter->napi[i]);
}
kfree(adapter->napi);
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/ibmvnic: Remove tests of member address
2018-12-11 4:20 [PATCH] net/ibmvnic: Remove tests of member address Wen Yang
@ 2018-12-14 21:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-12-14 21:36 UTC (permalink / raw)
To: wen.yang99
Cc: tlfalcon, jallen, benh, paulus, mpe, netdev, linuxppc-dev,
linux-kernel, cheng.shengyu
From: Wen Yang <wen.yang99@zte.com.cn>
Date: Tue, 11 Dec 2018 12:20:46 +0800
> The driver was checking for non-NULL address.
> - adapter->napi[i]
>
> This is pointless as these will be always non-NULL, since the
> 'dapter->napi' is allocated in init_napi().
> It is safe to get rid of useless checks for addresses to fix the
> coccinelle warning:
>>>drivers/net/ethernet/ibm/ibmvnic.c: test of a variable/field address
> Since such statements always return true, they are redundant.
>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-14 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11 4:20 [PATCH] net/ibmvnic: Remove tests of member address Wen Yang
2018-12-14 21:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).