From: YueHaibing <yuehaibing@huawei.com>
To: <bp@alien8.de>, <mchehab@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH -next] i5000_edac: remove set but not used variables 'maxdimmperch, maxch, channel_count'
Date: Tue, 11 Dec 2018 17:52:07 +0800 [thread overview]
Message-ID: <20181211095207.25936-1-yuehaibing@huawei.com> (raw)
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/edac/i5000_edac.c: In function 'i5000_get_mc_regs':
drivers/edac/i5000_edac.c:1138:6: warning:
variable 'maxdimmperch' set but not used [-Wunused-but-set-variable]
drivers/edac/i5000_edac.c:1137:6: warning:
variable 'maxch' set but not used [-Wunused-but-set-variable]
drivers/edac/i5000_edac.c: In function 'i5000_init_csrows':
drivers/edac/i5000_edac.c:1256:13: warning:
variable 'channel_count' set but not used [-Wunused-but-set-variable]
It never used since introduction in
commit eb60705ac5a9 ("drivers/edac: new intel 5000 MC driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/edac/i5000_edac.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c
index 98bef13..078a735 100644
--- a/drivers/edac/i5000_edac.c
+++ b/drivers/edac/i5000_edac.c
@@ -1134,8 +1134,6 @@ static void i5000_get_mc_regs(struct mem_ctl_info *mci)
u32 actual_tolm;
u16 limit;
int slot_row;
- int maxch;
- int maxdimmperch;
int way0, way1;
pvt = mci->pvt_info;
@@ -1145,9 +1143,6 @@ static void i5000_get_mc_regs(struct mem_ctl_info *mci)
pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32),
&pvt->u.ambase_top);
- maxdimmperch = pvt->maxdimmperch;
- maxch = pvt->maxch;
-
edac_dbg(2, "AMBASE= 0x%lx MAXCH= %d MAX-DIMM-Per-CH= %d\n",
(long unsigned int)pvt->ambase, pvt->maxch, pvt->maxdimmperch);
@@ -1253,7 +1248,7 @@ static int i5000_init_csrows(struct mem_ctl_info *mci)
{
struct i5000_pvt *pvt;
struct dimm_info *dimm;
- int empty, channel_count;
+ int empty;
int max_csrows;
int mtr;
int csrow_megs;
@@ -1261,8 +1256,6 @@ static int i5000_init_csrows(struct mem_ctl_info *mci)
int slot;
pvt = mci->pvt_info;
-
- channel_count = pvt->maxch;
max_csrows = pvt->maxdimmperch * 2;
empty = 1; /* Assume NO memory */
--
2.7.4
next reply other threads:[~2018-12-11 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:52 YueHaibing [this message]
2018-12-11 13:58 ` [PATCH -next] i5000_edac: remove set but not used variables 'maxdimmperch, maxch, channel_count' Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211095207.25936-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).