From: Borislav Petkov <bp@alien8.de>
To: YueHaibing <yuehaibing@huawei.com>
Cc: mchehab@kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH -next] i5000_edac: remove set but not used variables 'maxdimmperch, maxch, channel_count'
Date: Tue, 11 Dec 2018 14:58:29 +0100 [thread overview]
Message-ID: <20181211135829.GF27375@zn.tnic> (raw)
In-Reply-To: <20181211095207.25936-1-yuehaibing@huawei.com>
On Tue, Dec 11, 2018 at 05:52:07PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/edac/i5000_edac.c: In function 'i5000_get_mc_regs':
> drivers/edac/i5000_edac.c:1138:6: warning:
> variable 'maxdimmperch' set but not used [-Wunused-but-set-variable]
>
> drivers/edac/i5000_edac.c:1137:6: warning:
> variable 'maxch' set but not used [-Wunused-but-set-variable]
>
> drivers/edac/i5000_edac.c: In function 'i5000_init_csrows':
> drivers/edac/i5000_edac.c:1256:13: warning:
> variable 'channel_count' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
> commit eb60705ac5a9 ("drivers/edac: new intel 5000 MC driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/edac/i5000_edac.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
prev parent reply other threads:[~2018-12-11 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:52 [PATCH -next] i5000_edac: remove set but not used variables 'maxdimmperch, maxch, channel_count' YueHaibing
2018-12-11 13:58 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211135829.GF27375@zn.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).