From: Michal Hocko <mhocko@kernel.org>
To: osalvador@suse.de
Cc: akpm@linux-foundation.org, david@redhat.com,
pasha.tatashin@soleen.com, dan.j.williams@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm, memory_hotplug: Don't bail out in do_migrate_range prematurely
Date: Tue, 11 Dec 2018 13:52:34 +0100 [thread overview]
Message-ID: <20181211125234.GI1286@dhcp22.suse.cz> (raw)
In-Reply-To: <6009dea8a638aaa5b88088a117297edf@suse.de>
On Tue 11-12-18 13:22:27, osalvador@suse.de wrote:
> On 2018-12-11 11:18, Michal Hocko wrote:
[...]
> > The main question here is. Do we want to migrate as much as possible or
> > do we want to be conservative and bail out early. The later could be an
> > advantage if the next attempt could fail the whole operation because the
> > impact of the failed operation would be somehow reduced. The former
> > should be better for throughput because easily done stuff is done first.
> >
> > I would go with the throuput because our failure mode is to bail out
> > much earlier - even before we try to migrate. Even though the detection
> > is not perfect it works reasonably well for most usecases.
>
> I agree here.
> I think it is better to do as much work as possible at once.
This would be great to mention in the changelog. Because that is the
real justification for the change IMHO.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2018-12-11 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 8:50 [PATCH] mm, memory_hotplug: Don't bail out in do_migrate_range prematurely Oscar Salvador
2018-12-11 8:57 ` osalvador
2018-12-11 9:37 ` David Hildenbrand
2018-12-11 9:35 ` David Hildenbrand
2018-12-11 10:20 ` Michal Hocko
2018-12-11 10:35 ` David Hildenbrand
2018-12-11 10:18 ` Michal Hocko
2018-12-11 12:22 ` osalvador
2018-12-11 12:52 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211125234.GI1286@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@gmail.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).