From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Oscar Salvador <osalvador@suse.de>,
akpm@linux-foundation.org, pasha.tatashin@soleen.com,
dan.j.williams@gmail.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm, memory_hotplug: Don't bail out in do_migrate_range prematurely
Date: Tue, 11 Dec 2018 11:35:16 +0100 [thread overview]
Message-ID: <b0618ef7-8537-f85b-4cba-9a6fb75602f0@redhat.com> (raw)
In-Reply-To: <20181211102014.GF1286@dhcp22.suse.cz>
On 11.12.18 11:20, Michal Hocko wrote:
> On Tue 11-12-18 10:35:53, David Hildenbrand wrote:
>> So somehow remember if we had issues with one page and instead of
>> reporting 0, report e.g. -EAGAIN?
>
> There is no consumer of the return value right now and it is not really
> clear whether we need one. I would just make do_migrate_range return void.
>
Well, this would allow optimizations like "No need to check if
everything has been migrated, I can tell you right away that it has been
done".
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-12-11 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 8:50 [PATCH] mm, memory_hotplug: Don't bail out in do_migrate_range prematurely Oscar Salvador
2018-12-11 8:57 ` osalvador
2018-12-11 9:37 ` David Hildenbrand
2018-12-11 9:35 ` David Hildenbrand
2018-12-11 10:20 ` Michal Hocko
2018-12-11 10:35 ` David Hildenbrand [this message]
2018-12-11 10:18 ` Michal Hocko
2018-12-11 12:22 ` osalvador
2018-12-11 12:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0618ef7-8537-f85b-4cba-9a6fb75602f0@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).