* [PATCH] PM / sleep: convert to DEFINE_SHOW_ATTRIBUTE
@ 2018-12-11 16:20 Yangtao Li
2018-12-11 17:42 ` Pavel Machek
2018-12-17 11:42 ` Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Yangtao Li @ 2018-12-11 16:20 UTC (permalink / raw)
To: rjw, len.brown, pavel; +Cc: linux-pm, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
kernel/power/main.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/kernel/power/main.c b/kernel/power/main.c
index 35b50823d83b..98e76cad128b 100644
--- a/kernel/power/main.c
+++ b/kernel/power/main.c
@@ -318,23 +318,12 @@ static int suspend_stats_show(struct seq_file *s, void *unused)
return 0;
}
-
-static int suspend_stats_open(struct inode *inode, struct file *file)
-{
- return single_open(file, suspend_stats_show, NULL);
-}
-
-static const struct file_operations suspend_stats_operations = {
- .open = suspend_stats_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(suspend_stats);
static int __init pm_debugfs_init(void)
{
debugfs_create_file("suspend_stats", S_IFREG | S_IRUGO,
- NULL, NULL, &suspend_stats_operations);
+ NULL, NULL, &suspend_stats_fops);
return 0;
}
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / sleep: convert to DEFINE_SHOW_ATTRIBUTE
2018-12-11 16:20 [PATCH] PM / sleep: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
@ 2018-12-11 17:42 ` Pavel Machek
2018-12-17 11:42 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2018-12-11 17:42 UTC (permalink / raw)
To: Yangtao Li; +Cc: rjw, len.brown, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]
On Tue 2018-12-11 11:20:48, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> kernel/power/main.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 35b50823d83b..98e76cad128b 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -318,23 +318,12 @@ static int suspend_stats_show(struct seq_file *s, void *unused)
>
> return 0;
> }
> -
> -static int suspend_stats_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, suspend_stats_show, NULL);
> -}
> -
> -static const struct file_operations suspend_stats_operations = {
> - .open = suspend_stats_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(suspend_stats);
>
> static int __init pm_debugfs_init(void)
> {
> debugfs_create_file("suspend_stats", S_IFREG | S_IRUGO,
> - NULL, NULL, &suspend_stats_operations);
> + NULL, NULL, &suspend_stats_fops);
> return 0;
> }
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / sleep: convert to DEFINE_SHOW_ATTRIBUTE
2018-12-11 16:20 [PATCH] PM / sleep: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-11 17:42 ` Pavel Machek
@ 2018-12-17 11:42 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-12-17 11:42 UTC (permalink / raw)
To: Yangtao Li; +Cc: len.brown, pavel, linux-pm, linux-kernel
On Tuesday, December 11, 2018 5:20:48 PM CET Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> kernel/power/main.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 35b50823d83b..98e76cad128b 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -318,23 +318,12 @@ static int suspend_stats_show(struct seq_file *s, void *unused)
>
> return 0;
> }
> -
> -static int suspend_stats_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, suspend_stats_show, NULL);
> -}
> -
> -static const struct file_operations suspend_stats_operations = {
> - .open = suspend_stats_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(suspend_stats);
>
> static int __init pm_debugfs_init(void)
> {
> debugfs_create_file("suspend_stats", S_IFREG | S_IRUGO,
> - NULL, NULL, &suspend_stats_operations);
> + NULL, NULL, &suspend_stats_fops);
> return 0;
> }
>
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-17 11:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11 16:20 [PATCH] PM / sleep: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-11 17:42 ` Pavel Machek
2018-12-17 11:42 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).