From: Tony Lindgren <tony@atomide.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH 0/2] Graph fixes for using multiple endpoints per port
Date: Tue, 11 Dec 2018 16:19:50 -0800 [thread overview]
Message-ID: <20181212001950.GX6707@atomide.com> (raw)
In-Reply-To: <87ftv33bpg.wl-kuninori.morimoto.gx@renesas.com>
* Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> [181211 23:16]:
>
> Hi Tony
>
> > The issue I have with that it does not then follow the binding doc :)
> >
> > See this part in Documentation/devicetree/bindings/graph.txt:
> >
> > "If a single port is connected to more than one remote device, an
> > 'endpoint' child node must be provided for each link."
> >
> > Isn't the I2C TDM case the same as "single port connecected to
> > more than one remote device" rather than multiple ports?
> >
> > To me it seems we're currently only handling the multiple ports
> > case, and not multiple endpoints for a port. Other than fixing
> > that, things should work just as earlier with my two patches.
> > That is unless I accidentally broke something.
> >
> > So just trying to correct the binding usage. Or am I missing
> > something?
>
> I'm not 100% sure your "I2C TDM case", but you can check
> multi-endpoint sample on "Example: Multi DAI with DPCM" below.
> "pcm3168a" is using multi-endpoint.
> Does this help you ?
>
> https://patchwork.kernel.org/patch/10712877/
Hmm, so do you have multiple separate ports at the "&sound" node
hardware? If so then yeah multiple ports make sense.
But if you only a single physical (I2S?) port at the
"&sound" node hardware, then IMO you should only have one
port and multiple endpoints there according to the graph.txt
binding doc.
In my McBSP case there is only a single physical I2S port
that can be TDM split into timeslots.
Regards,
Tony
next prev parent reply other threads:[~2018-12-12 0:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 2:05 [PATCH 0/2] Graph fixes for using multiple endpoints per port Tony Lindgren
2018-12-11 2:05 ` [PATCH 1/2] ASoC: simple-card-utils: revert port changes to follow graph binding Tony Lindgren
2018-12-11 2:05 ` [PATCH 2/2] ASoC: audio-graph-card: Fix parsing of multiple endpoints Tony Lindgren
2018-12-11 3:31 ` [PATCH 0/2] Graph fixes for using multiple endpoints per port Kuninori Morimoto
2018-12-11 4:52 ` Tony Lindgren
2018-12-11 5:16 ` Kuninori Morimoto
2018-12-11 5:30 ` Kuninori Morimoto
2018-12-11 5:44 ` Tony Lindgren
2018-12-11 5:35 ` Tony Lindgren
2018-12-11 6:14 ` Kuninori Morimoto
2018-12-11 14:16 ` Tony Lindgren
2018-12-11 23:16 ` Kuninori Morimoto
2018-12-12 0:12 ` Kuninori Morimoto
2018-12-12 0:43 ` Tony Lindgren
2018-12-12 0:50 ` Tony Lindgren
2018-12-12 0:19 ` Tony Lindgren [this message]
2018-12-12 2:11 ` Kuninori Morimoto
2018-12-12 6:51 ` [alsa-devel] " Kuninori Morimoto
2018-12-12 15:27 ` Tony Lindgren
2018-12-13 0:24 ` Kuninori Morimoto
2018-12-13 0:40 ` Tony Lindgren
2018-12-13 1:06 ` Kuninori Morimoto
2018-12-13 1:13 ` Tony Lindgren
2018-12-12 13:05 ` Peter Ujfalusi
2018-12-12 14:50 ` Tony Lindgren
2018-12-13 6:53 ` Peter Ujfalusi
2018-12-13 16:55 ` Tony Lindgren
2018-12-12 12:48 ` Peter Ujfalusi
2018-12-12 14:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212001950.GX6707@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).