From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 0/2] Graph fixes for using multiple endpoints per port
Date: Tue, 11 Dec 2018 05:16:05 +0000 [thread overview]
Message-ID: <871s6obqkb.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20181211045220.GI6707@atomide.com>
Hi Tony
> > This looks a little bit strange for me.
> > Can you show me your DT for it ?
>
> Sure, adding also Sebastian to Cc. Here's what I currently have for droid 4
> dts with two codecs on I2S. Please just ignore the GNSS parts there..
>
> The TDM configuration is all done in the cpcap_audio_codec via set_tdm_slot().
> The modem voice call codec is a serdev driver :) I'll need some more time to
> be able to post patches but it's basically working for voice calls.
Hmm... it seems strange...
I guess you are using "ti,omap4-mcbsp" driver (= linux/sound/soc/omap/omap-mcbsp.c)
Is this correct ?
If so, your driver is registering component as
ret = devm_snd_soc_register_component(&pdev->dev,
&omap_mcbsp_component,
&omap_mcbsp_dai, 1);
Your driver has only 1 DAI.
> mcbsp3_port: port {
> - cpu_dai3: endpoint {
> + cpu_dai3: endpoint@0 {
> dai-format = "dsp_a";
> frame-master = <&cpcap_audio_codec1>;
> bitclock-master = <&cpcap_audio_codec1>;
> remote-endpoint = <&cpcap_audio_codec1>;
> };
> + cpu_dai_mdm: endpoint@1 {
> + dai-format = "dsp_a";
> + frame-master = <&cpcap_audio_codec1>;
> + bitclock-master = <&cpcap_audio_codec1>;
> + remote-endpoint = <&mot_mdm6600_audio_codec0>;
> + };
And here, you have 1 port, 2 endpoint.
Then, asoc_simple_card_get_dai_id() should return 1.
And, your [2/2] patch,
I guess you are misunderstanding about "port" vs "endpoint",
or omap-mcbsp driver side need to update ?
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2018-12-11 5:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 2:05 [PATCH 0/2] Graph fixes for using multiple endpoints per port Tony Lindgren
2018-12-11 2:05 ` [PATCH 1/2] ASoC: simple-card-utils: revert port changes to follow graph binding Tony Lindgren
2018-12-11 2:05 ` [PATCH 2/2] ASoC: audio-graph-card: Fix parsing of multiple endpoints Tony Lindgren
2018-12-11 3:31 ` [PATCH 0/2] Graph fixes for using multiple endpoints per port Kuninori Morimoto
2018-12-11 4:52 ` Tony Lindgren
2018-12-11 5:16 ` Kuninori Morimoto [this message]
2018-12-11 5:30 ` Kuninori Morimoto
2018-12-11 5:44 ` Tony Lindgren
2018-12-11 5:35 ` Tony Lindgren
2018-12-11 6:14 ` Kuninori Morimoto
2018-12-11 14:16 ` Tony Lindgren
2018-12-11 23:16 ` Kuninori Morimoto
2018-12-12 0:12 ` Kuninori Morimoto
2018-12-12 0:43 ` Tony Lindgren
2018-12-12 0:50 ` Tony Lindgren
2018-12-12 0:19 ` Tony Lindgren
2018-12-12 2:11 ` Kuninori Morimoto
2018-12-12 6:51 ` [alsa-devel] " Kuninori Morimoto
2018-12-12 15:27 ` Tony Lindgren
2018-12-13 0:24 ` Kuninori Morimoto
2018-12-13 0:40 ` Tony Lindgren
2018-12-13 1:06 ` Kuninori Morimoto
2018-12-13 1:13 ` Tony Lindgren
2018-12-12 13:05 ` Peter Ujfalusi
2018-12-12 14:50 ` Tony Lindgren
2018-12-13 6:53 ` Peter Ujfalusi
2018-12-13 16:55 ` Tony Lindgren
2018-12-12 12:48 ` Peter Ujfalusi
2018-12-12 14:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s6obqkb.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).