From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Joerg Roedel <joro@8bytes.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 16/24] memory: tegra: Clean up error messages
Date: Wed, 12 Dec 2018 23:38:59 +0300 [thread overview]
Message-ID: <20181212203907.23461-17-digetx@gmail.com> (raw)
In-Reply-To: <20181212203907.23461-1-digetx@gmail.com>
Make all messages to start with a lower case and don't unnecessarily go
over 80 chars in the code.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/memory/tegra/mc.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index 570da2129fa6..0a53598d982f 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -163,7 +163,7 @@ static int tegra_mc_hotreset_assert(struct reset_controller_dev *rcdev,
/* block clients DMA requests */
err = rst_ops->block_dma(mc, rst);
if (err) {
- dev_err(mc->dev, "Failed to block %s DMA: %d\n",
+ dev_err(mc->dev, "failed to block %s DMA: %d\n",
rst->name, err);
return err;
}
@@ -173,7 +173,7 @@ static int tegra_mc_hotreset_assert(struct reset_controller_dev *rcdev,
/* wait for completion of the outstanding DMA requests */
while (!rst_ops->dma_idling(mc, rst)) {
if (!retries--) {
- dev_err(mc->dev, "Failed to flush %s DMA\n",
+ dev_err(mc->dev, "failed to flush %s DMA\n",
rst->name);
return -EBUSY;
}
@@ -186,7 +186,7 @@ static int tegra_mc_hotreset_assert(struct reset_controller_dev *rcdev,
/* clear clients DMA requests sitting before arbitration */
err = rst_ops->hotreset_assert(mc, rst);
if (err) {
- dev_err(mc->dev, "Failed to hot reset %s: %d\n",
+ dev_err(mc->dev, "failed to hot reset %s: %d\n",
rst->name, err);
return err;
}
@@ -215,7 +215,7 @@ static int tegra_mc_hotreset_deassert(struct reset_controller_dev *rcdev,
/* take out client from hot reset */
err = rst_ops->hotreset_deassert(mc, rst);
if (err) {
- dev_err(mc->dev, "Failed to deassert hot reset %s: %d\n",
+ dev_err(mc->dev, "failed to deassert hot reset %s: %d\n",
rst->name, err);
return err;
}
@@ -225,7 +225,7 @@ static int tegra_mc_hotreset_deassert(struct reset_controller_dev *rcdev,
/* allow new DMA requests to proceed to arbitration */
err = rst_ops->unblock_dma(mc, rst);
if (err) {
- dev_err(mc->dev, "Failed to unblock %s DMA : %d\n",
+ dev_err(mc->dev, "failed to unblock %s DMA : %d\n",
rst->name, err);
return err;
}
@@ -657,7 +657,8 @@ static int tegra_mc_probe(struct platform_device *pdev)
{
err = tegra_mc_setup_latency_allowance(mc);
if (err < 0) {
- dev_err(&pdev->dev, "failed to setup latency allowance: %d\n",
+ dev_err(&pdev->dev,
+ "failed to setup latency allowance: %d\n",
err);
return err;
}
@@ -678,7 +679,7 @@ static int tegra_mc_probe(struct platform_device *pdev)
return mc->irq;
}
- WARN(!mc->soc->client_id_mask, "Missing client ID mask for this SoC\n");
+ WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n");
mc_writel(mc, mc->soc->intmask, MC_INTMASK);
--
2.20.0
next prev parent reply other threads:[~2018-12-12 20:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 20:38 [PATCH v7 00/24] Tegra GART driver clean up and optimization Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 01/24] iommu/tegra: gart: Remove pr_fmt and clean up includes Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 02/24] iommu/tegra: gart: Clean up driver probe errors handling Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 03/24] iommu/tegra: gart: Ignore devices without IOMMU phandle in DT Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 04/24] iommu: Introduce iotlb_sync_map callback Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 05/24] iommu/tegra: gart: Optimize mapping / unmapping performance Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 06/24] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 07/24] ARM: dts: tegra20: Update Memory Controller node to the new binding Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 08/24] memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20 Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 09/24] memory: tegra: Adapt to Tegra20 device-tree binding changes Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 10/24] memory: tegra: Read client ID on GART page fault Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 11/24] memory: tegra: Use of_device_get_match_data() Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 12/24] memory: tegra: Use relaxed versions of readl/writel Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 13/24] iommu/tegra: gart: Integrate with Memory Controller driver Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 14/24] memory: tegra: Do not try to probe SMMU on Tegra20 Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 15/24] memory: tegra: Do not ask for IRQ sharing Dmitry Osipenko
2018-12-12 20:38 ` Dmitry Osipenko [this message]
2018-12-12 20:39 ` [PATCH v7 17/24] iommu/tegra: gart: Fix spinlock recursion Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 18/24] iommu/tegra: gart: Fix NULL pointer dereference Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 19/24] iommu/tegra: gart: Allow only one active domain at a time Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 20/24] iommu/tegra: gart: Don't use managed resources Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 21/24] iommu/tegra: gart: Prepend error/debug messages with "gart:" Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 22/24] iommu/tegra: gart: Don't detach devices from inactive domains Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 23/24] iommu/tegra: gart: Simplify clients-tracking code Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 24/24] iommu/tegra: gart: Perform code refactoring Dmitry Osipenko
2018-12-17 9:14 ` [PATCH v7 00/24] Tegra GART driver clean up and optimization Joerg Roedel
2018-12-17 12:22 ` Dmitry Osipenko
2019-01-15 16:33 ` Dmitry Osipenko
2019-01-16 12:55 ` Joerg Roedel
2019-01-16 13:41 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212203907.23461-17-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).