From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Joerg Roedel <joro@8bytes.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 20/24] iommu/tegra: gart: Don't use managed resources
Date: Wed, 12 Dec 2018 23:39:03 +0300 [thread overview]
Message-ID: <20181212203907.23461-21-digetx@gmail.com> (raw)
In-Reply-To: <20181212203907.23461-1-digetx@gmail.com>
GART is a part of the Memory Controller driver that is always built-in,
hence there is no benefit from the use of managed resources.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
---
drivers/iommu/tegra-gart.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
index 71ff22be9560..2e0e6aff8f70 100644
--- a/drivers/iommu/tegra-gart.c
+++ b/drivers/iommu/tegra-gart.c
@@ -173,7 +173,7 @@ static int gart_iommu_attach_dev(struct iommu_domain *domain,
struct gart_client *client, *c;
int err = 0;
- client = devm_kzalloc(gart->dev, sizeof(*c), GFP_KERNEL);
+ client = kzalloc(sizeof(*c), GFP_KERNEL);
if (!client)
return -ENOMEM;
client->dev = dev;
@@ -199,7 +199,7 @@ static int gart_iommu_attach_dev(struct iommu_domain *domain,
return 0;
fail:
- devm_kfree(gart->dev, client);
+ kfree(client);
spin_unlock(&gart->client_lock);
return err;
}
@@ -214,7 +214,7 @@ static void __gart_iommu_detach_dev(struct iommu_domain *domain,
list_for_each_entry(c, &gart->client, list) {
if (c->dev == dev) {
list_del(&c->list);
- devm_kfree(gart->dev, c);
+ kfree(c);
if (list_empty(&gart->client))
gart->active_domain = NULL;
dev_dbg(gart->dev, "Detached %s\n", dev_name(dev));
@@ -455,7 +455,7 @@ struct gart_device *tegra_gart_probe(struct device *dev, struct tegra_mc *mc)
return ERR_PTR(-ENXIO);
}
- gart = devm_kzalloc(dev, sizeof(*gart), GFP_KERNEL);
+ gart = kzalloc(sizeof(*gart), GFP_KERNEL);
if (!gart) {
dev_err(dev, "failed to allocate gart_device\n");
return ERR_PTR(-ENOMEM);
@@ -464,7 +464,7 @@ struct gart_device *tegra_gart_probe(struct device *dev, struct tegra_mc *mc)
ret = iommu_device_sysfs_add(&gart->iommu, dev, NULL, "gart");
if (ret) {
dev_err(dev, "Failed to register IOMMU in sysfs\n");
- return ERR_PTR(ret);
+ goto free_gart;
}
iommu_device_set_ops(&gart->iommu, &gart_iommu_ops);
@@ -502,6 +502,8 @@ struct gart_device *tegra_gart_probe(struct device *dev, struct tegra_mc *mc)
iommu_device_unregister(&gart->iommu);
remove_sysfs:
iommu_device_sysfs_remove(&gart->iommu);
+free_gart:
+ kfree(gart);
return ERR_PTR(ret);
}
--
2.20.0
next prev parent reply other threads:[~2018-12-12 20:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 20:38 [PATCH v7 00/24] Tegra GART driver clean up and optimization Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 01/24] iommu/tegra: gart: Remove pr_fmt and clean up includes Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 02/24] iommu/tegra: gart: Clean up driver probe errors handling Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 03/24] iommu/tegra: gart: Ignore devices without IOMMU phandle in DT Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 04/24] iommu: Introduce iotlb_sync_map callback Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 05/24] iommu/tegra: gart: Optimize mapping / unmapping performance Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 06/24] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 07/24] ARM: dts: tegra20: Update Memory Controller node to the new binding Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 08/24] memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20 Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 09/24] memory: tegra: Adapt to Tegra20 device-tree binding changes Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 10/24] memory: tegra: Read client ID on GART page fault Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 11/24] memory: tegra: Use of_device_get_match_data() Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 12/24] memory: tegra: Use relaxed versions of readl/writel Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 13/24] iommu/tegra: gart: Integrate with Memory Controller driver Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 14/24] memory: tegra: Do not try to probe SMMU on Tegra20 Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 15/24] memory: tegra: Do not ask for IRQ sharing Dmitry Osipenko
2018-12-12 20:38 ` [PATCH v7 16/24] memory: tegra: Clean up error messages Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 17/24] iommu/tegra: gart: Fix spinlock recursion Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 18/24] iommu/tegra: gart: Fix NULL pointer dereference Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 19/24] iommu/tegra: gart: Allow only one active domain at a time Dmitry Osipenko
2018-12-12 20:39 ` Dmitry Osipenko [this message]
2018-12-12 20:39 ` [PATCH v7 21/24] iommu/tegra: gart: Prepend error/debug messages with "gart:" Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 22/24] iommu/tegra: gart: Don't detach devices from inactive domains Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 23/24] iommu/tegra: gart: Simplify clients-tracking code Dmitry Osipenko
2018-12-12 20:39 ` [PATCH v7 24/24] iommu/tegra: gart: Perform code refactoring Dmitry Osipenko
2018-12-17 9:14 ` [PATCH v7 00/24] Tegra GART driver clean up and optimization Joerg Roedel
2018-12-17 12:22 ` Dmitry Osipenko
2019-01-15 16:33 ` Dmitry Osipenko
2019-01-16 12:55 ` Joerg Roedel
2019-01-16 13:41 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212203907.23461-21-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).