* [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook
@ 2018-12-12 21:03 Vijay Khemka
2018-12-12 21:03 ` [PATCH v4 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC Vijay Khemka
2018-12-13 1:03 ` [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook Joel Stanley
0 siblings, 2 replies; 4+ messages in thread
From: Vijay Khemka @ 2018-12-12 21:03 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Cc: vijaykhemka, openbmc @ lists . ozlabs . org
Added kcs device and lpc ctrl device to enable LPC clock in Facebook
Tiogapass device tree.
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
.../dts/aspeed-bmc-facebook-tiogapass.dts | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
index d9d7f208788a..9544fa2c1822 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
@@ -21,6 +21,18 @@
memory@80000000 {
reg = <0x80000000 0x20000000>;
};
+
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ flash_memory: region@98000000 {
+ no-map;
+ reg = <0x98000000 0x04000000>; /* 64M */
+ };
+ };
+
iio-hwmon {
compatible = "iio-hwmon";
oemname0 = "MB_P3V3";
@@ -62,6 +74,12 @@
};
};
+&lpc_ctrl {
+ status = "okay";
+ memory-region = <&flash_memory>;
+ flash = <&spi1>;
+};
+
&uart1 {
// Host Console
status = "okay";
@@ -75,6 +93,18 @@
status = "okay";
};
+&kcs2 {
+ // BMC KCS channel 2
+ status = "okay";
+ kcs_addr = <0xca8>;
+};
+
+&kcs3 {
+ // BMC KCS channel 3
+ status = "okay";
+ kcs_addr = <0xca2>;
+};
+
&mac0 {
status = "okay";
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v4 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC
2018-12-12 21:03 [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook Vijay Khemka
@ 2018-12-12 21:03 ` Vijay Khemka
2018-12-13 1:03 ` [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook Joel Stanley
1 sibling, 0 replies; 4+ messages in thread
From: Vijay Khemka @ 2018-12-12 21:03 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Cc: vijaykhemka, openbmc @ lists . ozlabs . org
Added kcs device support for lpc BMC.
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
arch/arm/boot/dts/aspeed-g5.dtsi | 33 +++++++++++++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index d107459fc0f8..2743f400aa29 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -330,8 +330,32 @@
ranges = <0x0 0x1e789000 0x1000>;
lpc_bmc: lpc-bmc@0 {
- compatible = "aspeed,ast2500-lpc-bmc";
+ compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
reg = <0x0 0x80>;
+ reg-io-width = <4>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x80>;
+
+ kcs1: kcs1@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ interrupts = <8>;
+ kcs_chan = <1>;
+ status = "disabled";
+ };
+ kcs2: kcs2@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ interrupts = <8>;
+ kcs_chan = <2>;
+ status = "disabled";
+ };
+ kcs3: kcs3@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ interrupts = <8>;
+ kcs_chan = <3>;
+ status = "disabled";
+ };
};
lpc_host: lpc-host@80 {
@@ -343,6 +367,13 @@
#size-cells = <1>;
ranges = <0x0 0x80 0x1e0>;
+ kcs4: kcs4@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ interrupts = <8>;
+ kcs_chan = <4>;
+ status = "disabled";
+ };
+
lpc_ctrl: lpc-ctrl@0 {
compatible = "aspeed,ast2500-lpc-ctrl";
reg = <0x0 0x80>;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook
2018-12-12 21:03 [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook Vijay Khemka
2018-12-12 21:03 ` [PATCH v4 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC Vijay Khemka
@ 2018-12-13 1:03 ` Joel Stanley
2018-12-13 19:18 ` Vijay Khemka
1 sibling, 1 reply; 4+ messages in thread
From: Joel Stanley @ 2018-12-13 1:03 UTC (permalink / raw)
To: vijaykhemka, Andrew Jeffery
Cc: Rob Herring, Mark Rutland, devicetree, Linux ARM, linux-aspeed,
Linux Kernel Mailing List, OpenBMC Maillist
On Thu, 13 Dec 2018 at 07:34, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
> Added kcs device and lpc ctrl device to enable LPC clock in Facebook
> Tiogapass device tree.
As we're going to re-spin, it's a good idea to have the KCS and LPC
changes in separate patches. I will take the KCS one straight away,
but the LPC one might need more work (see my comments below).
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> .../dts/aspeed-bmc-facebook-tiogapass.dts | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> index d9d7f208788a..9544fa2c1822 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> @@ -21,6 +21,18 @@
> memory@80000000 {
> reg = <0x80000000 0x20000000>;
> };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + flash_memory: region@98000000 {
> + no-map;
> + reg = <0x98000000 0x04000000>; /* 64M */
> + };
Are you using this to expose some RAM over LPC? If not, we don't want this here.
It is a flaw in the design of the driver that the reserved memory
region is required. We should change the driver to make it optional.
As a workaround, we could add this patch to the tiogapass device tree
but make it smaller so you're not losing 64MB of RAM.
> + };
> +
> iio-hwmon {
> compatible = "iio-hwmon";
> oemname0 = "MB_P3V3";
> @@ -62,6 +74,12 @@
> };
> };
>
> +&lpc_ctrl {
> + status = "okay";
> + memory-region = <&flash_memory>;
> + flash = <&spi1>;
> +};
> +
> &uart1 {
> // Host Console
> status = "okay";
> @@ -75,6 +93,18 @@
> status = "okay";
> };
>
> +&kcs2 {
> + // BMC KCS channel 2
> + status = "okay";
> + kcs_addr = <0xca8>;
> +};
> +
> +&kcs3 {
> + // BMC KCS channel 3
> + status = "okay";
> + kcs_addr = <0xca2>;
> +};
> +
> &mac0 {
> status = "okay";
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook
2018-12-13 1:03 ` [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook Joel Stanley
@ 2018-12-13 19:18 ` Vijay Khemka
0 siblings, 0 replies; 4+ messages in thread
From: Vijay Khemka @ 2018-12-13 19:18 UTC (permalink / raw)
To: Joel Stanley, Andrew Jeffery
Cc: Rob Herring, Mark Rutland, devicetree, Linux ARM, linux-aspeed,
Linux Kernel Mailing List, OpenBMC Maillist
On 12/12/18, 5:04 PM, "Joel Stanley" <joel@jms.id.au> wrote:
On Thu, 13 Dec 2018 at 07:34, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
> Added kcs device and lpc ctrl device to enable LPC clock in Facebook
> Tiogapass device tree.
As we're going to re-spin, it's a good idea to have the KCS and LPC
changes in separate patches. I will take the KCS one straight away,
but the LPC one might need more work (see my comments below).
Thanks Joel,
I will create different patches and resubmit again.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> .../dts/aspeed-bmc-facebook-tiogapass.dts | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> index d9d7f208788a..9544fa2c1822 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> @@ -21,6 +21,18 @@
> memory@80000000 {
> reg = <0x80000000 0x20000000>;
> };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + flash_memory: region@98000000 {
> + no-map;
> + reg = <0x98000000 0x04000000>; /* 64M */
> + };
Are you using this to expose some RAM over LPC? If not, we don't want this here.
No, we are not using currently.
It is a flaw in the design of the driver that the reserved memory
region is required. We should change the driver to make it optional.
I agree with you we should make this change in driver.
As a workaround, we could add this patch to the tiogapass device tree
but make it smaller so you're not losing 64MB of RAM.
I will make it to 4K.
> + };
> +
> iio-hwmon {
> compatible = "iio-hwmon";
> oemname0 = "MB_P3V3";
> @@ -62,6 +74,12 @@
> };
> };
>
> +&lpc_ctrl {
> + status = "okay";
> + memory-region = <&flash_memory>;
> + flash = <&spi1>;
> +};
> +
> &uart1 {
> // Host Console
> status = "okay";
> @@ -75,6 +93,18 @@
> status = "okay";
> };
>
> +&kcs2 {
> + // BMC KCS channel 2
> + status = "okay";
> + kcs_addr = <0xca8>;
> +};
> +
> +&kcs3 {
> + // BMC KCS channel 3
> + status = "okay";
> + kcs_addr = <0xca2>;
> +};
> +
> &mac0 {
> status = "okay";
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-13 19:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-12 21:03 [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook Vijay Khemka
2018-12-12 21:03 ` [PATCH v4 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC Vijay Khemka
2018-12-13 1:03 ` [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook Joel Stanley
2018-12-13 19:18 ` Vijay Khemka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).