From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Gregory Clement <gregory.clement@bootlin.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>
Subject: Re: [PATCH v2 10/12] ARM64: dts: marvell: armada-3720-espressobin: declare PCIe reset GPIO
Date: Thu, 13 Dec 2018 15:33:06 +0100 [thread overview]
Message-ID: <20181213153306.4fc3b511@xps13> (raw)
In-Reply-To: <20181212102142.16053-11-miquel.raynal@bootlin.com>
Hello,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Wed, 12 Dec 2018
11:21:40 +0100:
> Add a reset-gpios property to the PCIe node.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> index 094994a9c68e..76a508da80b9 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> @@ -46,6 +46,9 @@
> /* J9 */
> &pcie0 {
> status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie_pins>;
> + reset-gpios = <&gpiosb 3 GPIO_ACTIVE_HIGH>;
> };
>
> /* J6 */
While this change may be fine for platforms based on Armada 3700 SoC,
it is not for the EspressoBin that has no reset GPIO for PCIe and
instead uses this pin to control the Ethenet switch.
I will re-send a series without this patch. I think it does not hurt to
keep the previous patch adding the pinmux setting in the
Armada-37xx.dtsi file even without using it, so I will drop only this
patch.
Thanks,
Miquèl
next prev parent reply other threads:[~2018-12-13 14:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 10:21 [PATCH v2 00/12] Bring suspend to RAM support to PCIe Aardvark driver Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 01/12] PCI: aardvark: Configure more registers in the configuration helper Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 02/12] PCI: aardvark: Add reset GPIO support Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 03/12] PCI: aardvark: Add PHY support Miquel Raynal
2018-12-14 0:47 ` Marek Behun
2018-12-14 0:57 ` Marek Behun
2018-12-17 16:07 ` Miquel Raynal
2018-12-17 18:27 ` Baruch Siach
2018-12-18 8:12 ` Miquel Raynal
2018-12-17 21:34 ` Marek Behun
2018-12-18 8:18 ` Miquel Raynal
2018-12-18 8:23 ` Miquel Raynal
2018-12-18 13:09 ` Marek Behun
2018-12-18 13:41 ` Miquel Raynal
2018-12-19 15:28 ` Marek Behún
2018-12-19 16:48 ` Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 04/12] PCI: aardvark: Add clock support Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 05/12] PCI: aardvark: Add suspend to RAM support Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 06/12] dt-bindings: PCI: aardvark: Describe the reset-gpios property Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 07/12] dt-bindings: PCI: aardvark: Describe the clocks property Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 08/12] dt-bindings: PCI: aardvark: Describe the PHY property Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 09/12] ARM64: dts: marvell: armada-37xx: declare PCIe reset pin Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 10/12] ARM64: dts: marvell: armada-3720-espressobin: declare PCIe reset GPIO Miquel Raynal
2018-12-13 14:33 ` Miquel Raynal [this message]
2018-12-13 14:36 ` Thomas Petazzoni
2018-12-17 14:31 ` Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 11/12] ARM64: dts: marvell: armada-37xx: declare PCIe clock Miquel Raynal
2018-12-12 10:21 ` [PATCH v2 12/12] ARM64: dts: marvell: armada-3720-espressobin: declare PCIe PHY Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213153306.4fc3b511@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).