* [PATCH] arm64: dts: qcom: qcs404: Fix regulator supply names
@ 2018-12-13 18:32 Bjorn Andersson
2019-03-04 19:23 ` Niklas Cassel
2019-03-05 4:09 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Andersson @ 2018-12-13 18:32 UTC (permalink / raw)
To: Andy Gross, David Brown
Cc: Rob Herring, Mark Rutland, linux-arm-msm, devicetree,
linux-kernel, Nicolas Dechesne
The regulator definition got their supply names cleaned up during
upstreaming, so they no longer match the driver defined names. Update
the supply names.
Also fill out the missing voltage of SMPS 5.
Fixes: 0b363f5b871c ("arm64: dts: qcom: qcs404: Add PMS405 RPM regulators")
Reported-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 28 ++++++++++++------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
index a39924efebe4..d6cc3a96530e 100644
--- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
@@ -37,18 +37,18 @@
pms405-regulators {
compatible = "qcom,rpm-pms405-regulators";
- vdd-s1-supply = <&vph_pwr>;
- vdd-s2-supply = <&vph_pwr>;
- vdd-s3-supply = <&vph_pwr>;
- vdd-s4-supply = <&vph_pwr>;
- vdd-s5-supply = <&vph_pwr>;
- vdd-l1-l2-supply = <&vreg_s5_1p35>;
- vdd-l3-l8-supply = <&vreg_s5_1p35>;
- vdd-l4-supply = <&vreg_s5_1p35>;
- vdd-l5-l6-supply = <&vreg_s4_1p8>;
- vdd-l7-supply = <&vph_pwr>;
- vdd-l9-supply = <&vreg_s5_1p35>;
- vdd-l10-l11-l12-l13-supply = <&vph_pwr>;
+ vdd_s1-supply = <&vph_pwr>;
+ vdd_s2-supply = <&vph_pwr>;
+ vdd_s3-supply = <&vph_pwr>;
+ vdd_s4-supply = <&vph_pwr>;
+ vdd_s5-supply = <&vph_pwr>;
+ vdd_l1_l2-supply = <&vreg_s5_1p35>;
+ vdd_l3_l8-supply = <&vreg_s5_1p35>;
+ vdd_l4-supply = <&vreg_s5_1p35>;
+ vdd_l5_l6-supply = <&vreg_s4_1p8>;
+ vdd_l7-supply = <&vph_pwr>;
+ vdd_l9-supply = <&vreg_s5_1p35>;
+ vdd_l10_l11_l12_l13-supply = <&vph_pwr>;
vreg_s4_1p8: s4 {
regulator-min-microvolt = <1728000>;
@@ -56,8 +56,8 @@
};
vreg_s5_1p35: s5 {
- regulator-min-microvolt = <>;
- regulator-max-microvolt = <>;
+ regulator-min-microvolt = <1352000>;
+ regulator-max-microvolt = <1352000>;
};
vreg_l1_1p3: l1 {
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404: Fix regulator supply names
2018-12-13 18:32 [PATCH] arm64: dts: qcom: qcs404: Fix regulator supply names Bjorn Andersson
@ 2019-03-04 19:23 ` Niklas Cassel
2019-03-05 4:09 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Cassel @ 2019-03-04 19:23 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
linux-arm-msm, devicetree, linux-kernel, Nicolas Dechesne
On Thu, Dec 13, 2018 at 10:32:00AM -0800, Bjorn Andersson wrote:
> The regulator definition got their supply names cleaned up during
> upstreaming, so they no longer match the driver defined names. Update
> the supply names.
>
> Also fill out the missing voltage of SMPS 5.
>
> Fixes: 0b363f5b871c ("arm64: dts: qcom: qcs404: Add PMS405 RPM regulators")
> Reported-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 28 ++++++++++++------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index a39924efebe4..d6cc3a96530e 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -37,18 +37,18 @@
> pms405-regulators {
> compatible = "qcom,rpm-pms405-regulators";
>
> - vdd-s1-supply = <&vph_pwr>;
> - vdd-s2-supply = <&vph_pwr>;
> - vdd-s3-supply = <&vph_pwr>;
> - vdd-s4-supply = <&vph_pwr>;
> - vdd-s5-supply = <&vph_pwr>;
> - vdd-l1-l2-supply = <&vreg_s5_1p35>;
> - vdd-l3-l8-supply = <&vreg_s5_1p35>;
> - vdd-l4-supply = <&vreg_s5_1p35>;
> - vdd-l5-l6-supply = <&vreg_s4_1p8>;
> - vdd-l7-supply = <&vph_pwr>;
> - vdd-l9-supply = <&vreg_s5_1p35>;
> - vdd-l10-l11-l12-l13-supply = <&vph_pwr>;
> + vdd_s1-supply = <&vph_pwr>;
> + vdd_s2-supply = <&vph_pwr>;
> + vdd_s3-supply = <&vph_pwr>;
> + vdd_s4-supply = <&vph_pwr>;
> + vdd_s5-supply = <&vph_pwr>;
> + vdd_l1_l2-supply = <&vreg_s5_1p35>;
> + vdd_l3_l8-supply = <&vreg_s5_1p35>;
> + vdd_l4-supply = <&vreg_s5_1p35>;
> + vdd_l5_l6-supply = <&vreg_s4_1p8>;
> + vdd_l7-supply = <&vph_pwr>;
> + vdd_l9-supply = <&vreg_s5_1p35>;
> + vdd_l10_l11_l12_l13-supply = <&vph_pwr>;
>
> vreg_s4_1p8: s4 {
> regulator-min-microvolt = <1728000>;
> @@ -56,8 +56,8 @@
> };
>
> vreg_s5_1p35: s5 {
> - regulator-min-microvolt = <>;
> - regulator-max-microvolt = <>;
> + regulator-min-microvolt = <1352000>;
> + regulator-max-microvolt = <1352000>;
> };
>
> vreg_l1_1p3: l1 {
> --
> 2.18.0
>
Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404: Fix regulator supply names
2018-12-13 18:32 [PATCH] arm64: dts: qcom: qcs404: Fix regulator supply names Bjorn Andersson
2019-03-04 19:23 ` Niklas Cassel
@ 2019-03-05 4:09 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-03-05 4:09 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
linux-arm-msm, devicetree, linux-kernel, Nicolas Dechesne
On 13-12-18, 10:32, Bjorn Andersson wrote:
> The regulator definition got their supply names cleaned up during
> upstreaming, so they no longer match the driver defined names. Update
> the supply names.
>
> Also fill out the missing voltage of SMPS 5.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
we need to also fix sdm845 dts as well as patch up the binding doc
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-05 4:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 18:32 [PATCH] arm64: dts: qcom: qcs404: Fix regulator supply names Bjorn Andersson
2019-03-04 19:23 ` Niklas Cassel
2019-03-05 4:09 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).