From: Masayoshi Mizuma <msys.mizuma@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Chao Fan <fanc.fnst@cn.fujitsu.com>,
linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, keescook@chromium.org,
bhe@redhat.com, indou.takao@jp.fujitsu.com,
caoj.fnst@cn.fujitsu.com
Subject: Re: [PATCH v13 2/6] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC
Date: Thu, 13 Dec 2018 14:38:18 -0500 [thread overview]
Message-ID: <20181213193817.4ltrgctjfs5wvv4c@gabell> (raw)
In-Reply-To: <20181213192950.GE25287@zn.tnic>
On Thu, Dec 13, 2018 at 08:29:50PM +0100, Borislav Petkov wrote:
> On Thu, Dec 13, 2018 at 02:25:30PM -0500, Masayoshi Mizuma wrote:
> > > + len = cmdline_find_option("acpi_rsdp", val, MAX_ADDRESS_LENGTH+1);
> >
> > sizeof() is better here.
> >
> > len = cmdline_find_option("acpi_rsdp", val, sizeof(var));
>
> Why is it better?
>
> That makes you go look for the "val" variable and see what it's size is.
> MAX_ADDRESS_LENGTH+1 is OTOH explicit.
Ah, thanks, make sense.
- Masa
next prev parent reply other threads:[~2018-12-13 19:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 3:10 [PATCH v13 0/6] x86/boot/KASLR: Parse ACPI table and limit KASLR to choosing immovable memory Chao Fan
2018-12-12 3:10 ` [PATCH v13 1/6] x86/boot: Introduce kstrtoull() to boot directory instead of simple_strtoull() Chao Fan
2018-12-12 4:12 ` Chao Fan
2018-12-12 8:03 ` Baoquan He
2018-12-13 13:26 ` Borislav Petkov
2018-12-14 1:34 ` Chao Fan
2018-12-14 10:38 ` Borislav Petkov
2018-12-17 1:27 ` Chao Fan
2018-12-17 15:45 ` Borislav Petkov
2018-12-18 3:20 ` Chao Fan
2018-12-12 7:46 ` Baoquan He
2018-12-12 8:10 ` Chao Fan
2018-12-13 12:50 ` Borislav Petkov
2018-12-14 2:59 ` Chao Fan
2018-12-14 11:57 ` Borislav Petkov
2018-12-16 19:22 ` kbuild test robot
2018-12-16 20:31 ` Borislav Petkov
2018-12-12 3:10 ` [PATCH v13 2/6] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC Chao Fan
2018-12-13 19:25 ` Masayoshi Mizuma
2018-12-13 19:29 ` Borislav Petkov
2018-12-13 19:38 ` Masayoshi Mizuma [this message]
2018-12-14 1:32 ` Chao Fan
2018-12-13 19:42 ` Borislav Petkov
2018-12-14 1:31 ` Chao Fan
2018-12-12 3:10 ` [PATCH v13 3/6] x86/boot: Introduce efi_get_rsdp_addr() to find RSDP from EFI table Chao Fan
2018-12-13 20:23 ` Borislav Petkov
2018-12-14 1:28 ` Chao Fan
2018-12-17 17:16 ` Masayoshi Mizuma
2018-12-12 3:10 ` [PATCH v13 4/6] x86/boot: Introduce bios_get_rsdp_addr() to search RSDP in memory Chao Fan
2018-12-12 3:10 ` [PATCH v13 5/6] x86/boot: Parse SRAT from RSDP and store immovable memory Chao Fan
2018-12-12 3:10 ` [PATCH v13 6/6] x86/boot/KASLR: Limit KASLR to extracting kernel in " Chao Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213193817.4ltrgctjfs5wvv4c@gabell \
--to=msys.mizuma@gmail.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).