linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Chao Fan <fanc.fnst@cn.fujitsu.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, x86@kernel.org,
	bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, keescook@chromium.org, bhe@redhat.com,
	msys.mizuma@gmail.com, indou.takao@jp.fujitsu.com,
	caoj.fnst@cn.fujitsu.com, fanc.fnst@cn.fujitsu.com
Subject: Re: [PATCH v13 1/6] x86/boot: Introduce kstrtoull() to boot directory instead of simple_strtoull()
Date: Mon, 17 Dec 2018 03:22:39 +0800	[thread overview]
Message-ID: <201812170347.uTJ6Fwb8%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181212031053.1815-2-fanc.fnst@cn.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 4179 bytes --]

Hi Chao,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20-rc6 next-20181214]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chao-Fan/x86-boot-KASLR-Parse-ACPI-table-and-limit-KASLR-to-choosing-immovable-memory/20181214-082218
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:207:0,
                    from arch/x86/boot/string.c:17:
>> arch/x86/include/asm/div64.h:61:21: error: redefinition of 'div_u64_rem'
    #define div_u64_rem div_u64_rem
                        ^
>> arch/x86/boot/string.c:194:19: note: in expansion of macro 'div_u64_rem'
    static inline u64 div_u64_rem(u64 dividend, u32 divisor, u32 *remainder)
                      ^~~~~~~~~~~
   arch/x86/include/asm/div64.h:43:19: note: previous definition of 'div_u64_rem' was here
    static inline u64 div_u64_rem(u64 dividend, u32 divisor, u32 *remainder)
                      ^~~~~~~~~~~
--
   In file included from include/linux/kernel.h:207:0,
                    from arch/x86/boot/compressed/../string.c:17,
                    from arch/x86/boot/compressed/string.c:11:
>> arch/x86/include/asm/div64.h:61:21: error: redefinition of 'div_u64_rem'
    #define div_u64_rem div_u64_rem
                        ^
>> arch/x86/boot/compressed/../string.c:194:19: note: in expansion of macro 'div_u64_rem'
    static inline u64 div_u64_rem(u64 dividend, u32 divisor, u32 *remainder)
                      ^~~~~~~~~~~
   arch/x86/include/asm/div64.h:43:19: note: previous definition of 'div_u64_rem' was here
    static inline u64 div_u64_rem(u64 dividend, u32 divisor, u32 *remainder)
                      ^~~~~~~~~~~

vim +/div_u64_rem +61 arch/x86/include/asm/div64.h

428c5a23 include/asm-x86/div64.h Chris Snook  2007-10-20  42  
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  43  static inline u64 div_u64_rem(u64 dividend, u32 divisor, u32 *remainder)
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  44  {
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  45  	union {
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  46  		u64 v64;
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  47  		u32 v32[2];
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  48  	} d = { dividend };
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  49  	u32 upper;
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  50  
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  51  	upper = d.v32[1];
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  52  	d.v32[1] = 0;
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  53  	if (upper >= divisor) {
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  54  		d.v32[1] = upper / divisor;
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  55  		upper %= divisor;
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  56  	}
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  57  	asm ("divl %2" : "=a" (d.v32[0]), "=d" (*remainder) :
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  58  		"rm" (divisor), "0" (d.v32[0]), "1" (upper));
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  59  	return d.v64;
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  60  }
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01 @61  #define div_u64_rem	div_u64_rem
2418f4f2 include/asm-x86/div64.h Roman Zippel 2008-05-01  62  

:::::: The code at line 61 was first introduced by commit
:::::: 2418f4f28f8467b92a6177af32d05737ebf6206c introduce explicit signed/unsigned 64bit divide

:::::: TO: Roman Zippel <zippel@linux-m68k.org>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66054 bytes --]

  parent reply	other threads:[~2018-12-16 19:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12  3:10 [PATCH v13 0/6] x86/boot/KASLR: Parse ACPI table and limit KASLR to choosing immovable memory Chao Fan
2018-12-12  3:10 ` [PATCH v13 1/6] x86/boot: Introduce kstrtoull() to boot directory instead of simple_strtoull() Chao Fan
2018-12-12  4:12   ` Chao Fan
2018-12-12  8:03     ` Baoquan He
2018-12-13 13:26       ` Borislav Petkov
2018-12-14  1:34         ` Chao Fan
2018-12-14 10:38           ` Borislav Petkov
2018-12-17  1:27         ` Chao Fan
2018-12-17 15:45           ` Borislav Petkov
2018-12-18  3:20             ` Chao Fan
2018-12-12  7:46   ` Baoquan He
2018-12-12  8:10     ` Chao Fan
2018-12-13 12:50   ` Borislav Petkov
2018-12-14  2:59     ` Chao Fan
2018-12-14 11:57       ` Borislav Petkov
2018-12-16 19:22   ` kbuild test robot [this message]
2018-12-16 20:31     ` Borislav Petkov
2018-12-12  3:10 ` [PATCH v13 2/6] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC Chao Fan
2018-12-13 19:25   ` Masayoshi Mizuma
2018-12-13 19:29     ` Borislav Petkov
2018-12-13 19:38       ` Masayoshi Mizuma
2018-12-14  1:32     ` Chao Fan
2018-12-13 19:42   ` Borislav Petkov
2018-12-14  1:31     ` Chao Fan
2018-12-12  3:10 ` [PATCH v13 3/6] x86/boot: Introduce efi_get_rsdp_addr() to find RSDP from EFI table Chao Fan
2018-12-13 20:23   ` Borislav Petkov
2018-12-14  1:28     ` Chao Fan
2018-12-17 17:16   ` Masayoshi Mizuma
2018-12-12  3:10 ` [PATCH v13 4/6] x86/boot: Introduce bios_get_rsdp_addr() to search RSDP in memory Chao Fan
2018-12-12  3:10 ` [PATCH v13 5/6] x86/boot: Parse SRAT from RSDP and store immovable memory Chao Fan
2018-12-12  3:10 ` [PATCH v13 6/6] x86/boot/KASLR: Limit KASLR to extracting kernel in " Chao Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201812170347.uTJ6Fwb8%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=fanc.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=kbuild-all@01.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=msys.mizuma@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).