* [PATCH 2/5] ARM: dts: Remove unused properties from FSL QSPI driver nodes
2018-12-10 16:28 [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Schrempf Frieder
@ 2018-12-10 16:28 ` Schrempf Frieder
2018-12-10 16:28 ` [PATCH 1/5] arm64: " Schrempf Frieder
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Schrempf Frieder @ 2018-12-10 16:28 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Mark Rutland
Cc: boris.brezillon, linux-mtd, broonie, linux-spi, Schrempf Frieder,
linux-arm-kernel, devicetree, linux-kernel
From: Frieder Schrempf <frieder.schrempf@kontron.de>
The properties 'bus-num', 'fsl,spi-num-chipselects' and
'fsl,spi-flash-chipselects' were never read by the driver
and can be removed.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
index d01f64b..6bb7ce0 100644
--- a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
+++ b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
@@ -203,9 +203,6 @@
};
&qspi {
- bus-num = <0>;
- fsl,spi-num-chipselects = <2>;
- fsl,spi-flash-chipselects = <0>;
fsl,qspi-has-second-chip;
status = "okay";
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 1/5] arm64: dts: Remove unused properties from FSL QSPI driver nodes
2018-12-10 16:28 [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Schrempf Frieder
2018-12-10 16:28 ` [PATCH 2/5] ARM: dts: Remove unused properties from FSL QSPI driver nodes Schrempf Frieder
@ 2018-12-10 16:28 ` Schrempf Frieder
2018-12-10 16:28 ` [PATCH 4/5] arm64: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller Schrempf Frieder
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Schrempf Frieder @ 2018-12-10 16:28 UTC (permalink / raw)
To: Shawn Guo, Li Yang
Cc: boris.brezillon, linux-mtd, broonie, linux-spi, Schrempf Frieder,
Rob Herring, Mark Rutland, linux-arm-kernel, devicetree,
linux-kernel
From: Frieder Schrempf <frieder.schrempf@kontron.de>
The properties 'num-cs' and 'bus-num' were never read by the driver
and can be removed.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 1 -
arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 --
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 2 --
3 files changed, 5 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index dff3d64..d2c06ad4 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -135,7 +135,6 @@
};
&qspi {
- bus-num = <0>;
status = "okay";
qflash0: s25fl128s@0 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index e58a8ca..6ec1adb 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -163,8 +163,6 @@
};
&qspi {
- num-cs = <2>;
- bus-num = <0>;
status = "okay";
qflash0: s25fl128s@0 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
index a59b482..17f1298 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
@@ -99,8 +99,6 @@
};
&qspi {
- num-cs = <2>;
- bus-num = <0>;
status = "okay";
qflash0: s25fs512s@0 {
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/5] arm64: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
2018-12-10 16:28 [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Schrempf Frieder
2018-12-10 16:28 ` [PATCH 2/5] ARM: dts: Remove unused properties from FSL QSPI driver nodes Schrempf Frieder
2018-12-10 16:28 ` [PATCH 1/5] arm64: " Schrempf Frieder
@ 2018-12-10 16:28 ` Schrempf Frieder
2018-12-10 16:28 ` [PATCH 3/5] ARM: dts: imx6sx-sdb: Fix the reg properties for the FSL QSPI nodes Schrempf Frieder
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Schrempf Frieder @ 2018-12-10 16:28 UTC (permalink / raw)
To: Shawn Guo, Li Yang
Cc: boris.brezillon, linux-mtd, broonie, linux-spi, Schrempf Frieder,
Rob Herring, Mark Rutland, linux-arm-kernel, devicetree,
linux-kernel
From: Frieder Schrempf <frieder.schrempf@kontron.de>
We will move the FSL QSPI driver to the SPI framework soon. To
prepare and to make sure the full buswidth is used (as it is with
the current driver), let's add the right properties.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 2 ++
arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 ++
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 4 ++++
arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi | 4 ++++
4 files changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index d2c06ad4..8a50094 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -142,6 +142,8 @@
#address-cells = <1>;
#size-cells = <1>;
spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <0>;
};
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index 6ec1adb..2f220ec 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -170,6 +170,8 @@
#address-cells = <1>;
#size-cells = <1>;
spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <0>;
};
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
index 17f1298..07c665c 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
@@ -106,6 +106,8 @@
#address-cells = <1>;
#size-cells = <1>;
spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <0>;
};
@@ -114,6 +116,8 @@
#address-cells = <1>;
#size-cells = <1>;
spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <1>;
};
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi
index c11f52e..10d2fe0 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi
@@ -134,6 +134,8 @@
#size-cells = <1>;
compatible = "st,m25p80";
spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <0>;
};
flash2: s25fl256s1@2 {
@@ -141,6 +143,8 @@
#size-cells = <1>;
compatible = "st,m25p80";
spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <2>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/5] ARM: dts: imx6sx-sdb: Fix the reg properties for the FSL QSPI nodes
2018-12-10 16:28 [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Schrempf Frieder
` (2 preceding siblings ...)
2018-12-10 16:28 ` [PATCH 4/5] arm64: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller Schrempf Frieder
@ 2018-12-10 16:28 ` Schrempf Frieder
2018-12-10 16:28 ` [PATCH 5/5] ARM: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller Schrempf Frieder
2018-12-10 16:31 ` [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Schrempf Frieder
5 siblings, 0 replies; 11+ messages in thread
From: Schrempf Frieder @ 2018-12-10 16:28 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Rob Herring, Mark Rutland
Cc: boris.brezillon, linux-mtd, broonie, linux-spi, Schrempf Frieder,
linux-arm-kernel, devicetree, linux-kernel
From: Frieder Schrempf <frieder.schrempf@kontron.de>
The current driver does not use the reg properties, but we will
add a new driver soon. To make sure we have a consistent scheme,
let's fix the reg properties here.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
arch/arm/boot/dts/imx6sx-sdb-reva.dts | 4 ++--
arch/arm/boot/dts/imx6sx-sdb.dts | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx6sx-sdb-reva.dts b/arch/arm/boot/dts/imx6sx-sdb-reva.dts
index 9cc6ff2..344abc2 100644
--- a/arch/arm/boot/dts/imx6sx-sdb-reva.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb-reva.dts
@@ -134,8 +134,8 @@
spi-max-frequency = <66000000>;
};
- flash1: s25fl128s@1 {
- reg = <1>;
+ flash1: s25fl128s@2 {
+ reg = <2>;
#address-cells = <1>;
#size-cells = <1>;
compatible = "spansion,s25fl128s", "jedec,spi-nor";
diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
index 6dd9beb..5a39703 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb.dts
@@ -120,12 +120,12 @@
reg = <0>;
};
- flash1: n25q256a@1 {
+ flash1: n25q256a@2 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "micron,n25q256a", "jedec,spi-nor";
spi-max-frequency = <29000000>;
- reg = <1>;
+ reg = <2>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5/5] ARM: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
2018-12-10 16:28 [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Schrempf Frieder
` (3 preceding siblings ...)
2018-12-10 16:28 ` [PATCH 3/5] ARM: dts: imx6sx-sdb: Fix the reg properties for the FSL QSPI nodes Schrempf Frieder
@ 2018-12-10 16:28 ` Schrempf Frieder
2018-12-10 16:31 ` [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Schrempf Frieder
5 siblings, 0 replies; 11+ messages in thread
From: Schrempf Frieder @ 2018-12-10 16:28 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Rob Herring, Mark Rutland, Li Yang
Cc: boris.brezillon, linux-mtd, broonie, linux-spi, Schrempf Frieder,
linux-arm-kernel, devicetree, linux-kernel
From: Frieder Schrempf <frieder.schrempf@kontron.de>
We will move the FSL QSPI driver to the SPI framework soon. To
prepare and to make sure the full buswidth is used (as it is with
the current driver), let's add the right properties.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
arch/arm/boot/dts/imx6sx-sdb-reva.dts | 4 ++++
arch/arm/boot/dts/imx6sx-sdb.dts | 4 ++++
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 ++
arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 2 ++
4 files changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx-sdb-reva.dts b/arch/arm/boot/dts/imx6sx-sdb-reva.dts
index 344abc2..9997156 100644
--- a/arch/arm/boot/dts/imx6sx-sdb-reva.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb-reva.dts
@@ -132,6 +132,8 @@
#size-cells = <1>;
compatible = "spansion,s25fl128s", "jedec,spi-nor";
spi-max-frequency = <66000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
};
flash1: s25fl128s@2 {
@@ -140,5 +142,7 @@
#size-cells = <1>;
compatible = "spansion,s25fl128s", "jedec,spi-nor";
spi-max-frequency = <66000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
};
};
diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
index 5a39703..9acfda8 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb.dts
@@ -117,6 +117,8 @@
#size-cells = <1>;
compatible = "micron,n25q256a", "jedec,spi-nor";
spi-max-frequency = <29000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <0>;
};
@@ -125,6 +127,8 @@
#size-cells = <1>;
compatible = "micron,n25q256a", "jedec,spi-nor";
spi-max-frequency = <29000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <2>;
};
};
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
index 32a0723..c2c9a2a 100644
--- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
+++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
@@ -176,6 +176,8 @@
#size-cells = <1>;
compatible = "micron,n25q256a";
spi-max-frequency = <29000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <0>;
};
};
diff --git a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
index 6bb7ce0..6a83f30 100644
--- a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
+++ b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
@@ -211,6 +211,8 @@
#address-cells = <1>;
#size-cells = <1>;
spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
reg = <0>;
partitions@0 {
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver
2018-12-10 16:28 [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Schrempf Frieder
` (4 preceding siblings ...)
2018-12-10 16:28 ` [PATCH 5/5] ARM: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller Schrempf Frieder
@ 2018-12-10 16:31 ` Schrempf Frieder
2018-12-13 9:45 ` Schrempf Frieder
5 siblings, 1 reply; 11+ messages in thread
From: Schrempf Frieder @ 2018-12-10 16:31 UTC (permalink / raw)
To: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-arm-kernel, devicetree
Cc: boris.brezillon, linux-mtd, broonie, linux-spi, linux-kernel
Hi FSL/ARM maintainers,
On 10.12.18 17:26, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> We have prepared a new driver for the FSL QSPI controller that works under
> the SPI framework. The current devicetrees are broken because they use an
> inconsistent scheme for assigning the reg properties.
>
> As, in contrast to the current driver, the new driver will use the reg
> properties to select the correct chip, we need to fix them.
>
> We also add spi-[tx/rx]-bus-width to make sure the full buswidth will be used
> and while at it clean up and remove some unused properties.
could you please consider these devicetree patches for v4.21?
We have the new FSL QSPI driver under the SPI framework ([1]) ready, but
we need some small fixes to the devicetrees that are currently broken.
As the new driver depends on these changes (mainly the change to the reg
properties) and it is not possible to add compatibility for the old
bindings, it would be really nice to have them in v4.21, so we can queue
the driver for v4.22 or whatever the next release will be called.
Please also see [2] for some more explanation.
Thanks,
Frieder
[1] https://patchwork.ozlabs.org/cover/1007641/
[2] https://patchwork.ozlabs.org/patch/922817/#1925445
>
> Frieder Schrempf (5):
> arm64: dts: Remove unused properties from FSL QSPI driver nodes
> ARM: dts: Remove unused properties from FSL QSPI driver nodes
> ARM: dts: imx6sx-sdb: Fix the reg properties for the FSL QSPI nodes
> arm64: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
> ARM: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
>
> arch/arm/boot/dts/imx6sx-sdb-reva.dts | 8 ++++++--
> arch/arm/boot/dts/imx6sx-sdb.dts | 8 ++++++--
> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 ++
> arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 5 ++---
> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 3 ++-
> arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 4 ++--
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 6 ++++--
> arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi | 4 ++++
> 8 files changed, 28 insertions(+), 12 deletions(-)
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver
2018-12-10 16:31 ` [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Schrempf Frieder
@ 2018-12-13 9:45 ` Schrempf Frieder
2018-12-14 0:42 ` Shawn Guo
0 siblings, 1 reply; 11+ messages in thread
From: Schrempf Frieder @ 2018-12-13 9:45 UTC (permalink / raw)
To: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-arm-kernel, devicetree, Shawn Guo, Sascha Hauer
Cc: boris.brezillon, broonie, linux-mtd, linux-kernel, linux-spi
+ Shawn, Sascha
On 10.12.18 17:31, Schrempf Frieder wrote:
> Hi FSL/ARM maintainers,
>
> On 10.12.18 17:26, Schrempf Frieder wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> We have prepared a new driver for the FSL QSPI controller that works under
>> the SPI framework. The current devicetrees are broken because they use an
>> inconsistent scheme for assigning the reg properties.
>>
>> As, in contrast to the current driver, the new driver will use the reg
>> properties to select the correct chip, we need to fix them.
>>
>> We also add spi-[tx/rx]-bus-width to make sure the full buswidth will be used
>> and while at it clean up and remove some unused properties.
>
> could you please consider these devicetree patches for v4.21?
Any chance to get this merged? Otherwise we would need to postpone the
new driver even further.
All the changes to the devicetrees in this series are non-intrusive and
uncritical, anyway.
Thanks,
Frieder
>
> We have the new FSL QSPI driver under the SPI framework ([1]) ready, but
> we need some small fixes to the devicetrees that are currently broken.
>
> As the new driver depends on these changes (mainly the change to the reg
> properties) and it is not possible to add compatibility for the old
> bindings, it would be really nice to have them in v4.21, so we can queue
> the driver for v4.22 or whatever the next release will be called.
>
> Please also see [2] for some more explanation.
>
> Thanks,
> Frieder
>
> [1] https://patchwork.ozlabs.org/cover/1007641/
> [2] https://patchwork.ozlabs.org/patch/922817/#1925445
>
>>
>> Frieder Schrempf (5):
>> arm64: dts: Remove unused properties from FSL QSPI driver nodes
>> ARM: dts: Remove unused properties from FSL QSPI driver nodes
>> ARM: dts: imx6sx-sdb: Fix the reg properties for the FSL QSPI nodes
>> arm64: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
>> ARM: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
>>
>> arch/arm/boot/dts/imx6sx-sdb-reva.dts | 8 ++++++--
>> arch/arm/boot/dts/imx6sx-sdb.dts | 8 ++++++--
>> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 ++
>> arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 5 ++---
>> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 3 ++-
>> arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 4 ++--
>> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 6 ++++--
>> arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi | 4 ++++
>> 8 files changed, 28 insertions(+), 12 deletions(-)
>>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver
2018-12-13 9:45 ` Schrempf Frieder
@ 2018-12-14 0:42 ` Shawn Guo
2018-12-15 10:04 ` AW: " Schrempf Frieder
0 siblings, 1 reply; 11+ messages in thread
From: Shawn Guo @ 2018-12-14 0:42 UTC (permalink / raw)
To: Schrempf Frieder
Cc: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-arm-kernel, devicetree, Sascha Hauer, boris.brezillon,
broonie, linux-mtd, linux-kernel, linux-spi
On Thu, Dec 13, 2018 at 09:45:04AM +0000, Schrempf Frieder wrote:
> + Shawn, Sascha
>
> On 10.12.18 17:31, Schrempf Frieder wrote:
> > Hi FSL/ARM maintainers,
> >
> > On 10.12.18 17:26, Schrempf Frieder wrote:
> >> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>
> >> We have prepared a new driver for the FSL QSPI controller that works under
> >> the SPI framework. The current devicetrees are broken because they use an
> >> inconsistent scheme for assigning the reg properties.
> >>
> >> As, in contrast to the current driver, the new driver will use the reg
> >> properties to select the correct chip, we need to fix them.
> >>
> >> We also add spi-[tx/rx]-bus-width to make sure the full buswidth will be used
> >> and while at it clean up and remove some unused properties.
> >
> > could you please consider these devicetree patches for v4.21?
>
> Any chance to get this merged? Otherwise we would need to postpone the
> new driver even further.
As it came up a little bit late (the same day I sent pull request for
4.21), I was considering it as 4.22 material. But as you mentioned that
the series is non-intrusive, I can try to send it to arm-soc folk for
4.21 merge window, and then that will be their call. But before I do
it, I need you to double confirm that the series will not break anything
that is already working.
Shawn
>
> All the changes to the devicetrees in this series are non-intrusive and
> uncritical, anyway.
>
> Thanks,
> Frieder
>
> >
> > We have the new FSL QSPI driver under the SPI framework ([1]) ready, but
> > we need some small fixes to the devicetrees that are currently broken.
> >
> > As the new driver depends on these changes (mainly the change to the reg
> > properties) and it is not possible to add compatibility for the old
> > bindings, it would be really nice to have them in v4.21, so we can queue
> > the driver for v4.22 or whatever the next release will be called.
> >
> > Please also see [2] for some more explanation.
> >
> > Thanks,
> > Frieder
> >
> > [1] https://patchwork.ozlabs.org/cover/1007641/
> > [2] https://patchwork.ozlabs.org/patch/922817/#1925445
> >
> >>
> >> Frieder Schrempf (5):
> >> arm64: dts: Remove unused properties from FSL QSPI driver nodes
> >> ARM: dts: Remove unused properties from FSL QSPI driver nodes
> >> ARM: dts: imx6sx-sdb: Fix the reg properties for the FSL QSPI nodes
> >> arm64: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
> >> ARM: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
> >>
> >> arch/arm/boot/dts/imx6sx-sdb-reva.dts | 8 ++++++--
> >> arch/arm/boot/dts/imx6sx-sdb.dts | 8 ++++++--
> >> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 ++
> >> arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 5 ++---
> >> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 3 ++-
> >> arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 4 ++--
> >> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 6 ++++--
> >> arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi | 4 ++++
> >> 8 files changed, 28 insertions(+), 12 deletions(-)
> >>
> > ______________________________________________________
> > Linux MTD discussion mailing list
> > http://lists.infradead.org/mailman/listinfo/linux-mtd/
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* AW: [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver
2018-12-14 0:42 ` Shawn Guo
@ 2018-12-15 10:04 ` Schrempf Frieder
2018-12-16 7:51 ` Shawn Guo
0 siblings, 1 reply; 11+ messages in thread
From: Schrempf Frieder @ 2018-12-15 10:04 UTC (permalink / raw)
To: Shawn Guo
Cc: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-arm-kernel, devicetree, Sascha Hauer, boris.brezillon,
broonie, linux-mtd, linux-kernel, linux-spi
>On Thu, Dec 13, 2018 at 09:45:04AM +0000, Schrempf Frieder wrote:
>> + Shawn, Sascha
>>
>> On 10.12.18 17:31, Schrempf Frieder wrote:
>> > Hi FSL/ARM maintainers,
>> >
>> > On 10.12.18 17:26, Schrempf Frieder wrote:
>> >> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>> >>
>> >> We have prepared a new driver for the FSL QSPI controller that works under
>> >> the SPI framework. The current devicetrees are broken because they use an
>> >> inconsistent scheme for assigning the reg properties.
>> >>
>> >> As, in contrast to the current driver, the new driver will use the reg
>> >> properties to select the correct chip, we need to fix them.
>> >>
>> >> We also add spi-[tx/rx]-bus-width to make sure the full buswidth will be used
>> >> and while at it clean up and remove some unused properties.
>> >
>> > could you please consider these devicetree patches for v4.21?
>>
>> Any chance to get this merged? Otherwise we would need to postpone the
>> new driver even further.
>
>As it came up a little bit late (the same day I sent pull request for
>4.21), I was considering it as 4.22 material. But as you mentioned that
>the series is non-intrusive, I can try to send it to arm-soc folk for
>4.21 merge window, and then that will be their call. But before I do
>it, I need you to double confirm that the series will not break anything
>that is already working.
I can confirm, that the series does only remove or add properties to the
devicetree, that are currently not used by the driver. Therefore it won't break
anything.
Thanks,
Frieder
>
>Shawn
>
>>
>> All the changes to the devicetrees in this series are non-intrusive and
>> uncritical, anyway.
>>
>> Thanks,
>> Frieder
>>
>> >
>> > We have the new FSL QSPI driver under the SPI framework ([1]) ready, but
>> > we need some small fixes to the devicetrees that are currently broken.
>> >
>> > As the new driver depends on these changes (mainly the change to the reg
>> > properties) and it is not possible to add compatibility for the old
>> > bindings, it would be really nice to have them in v4.21, so we can queue
>> > the driver for v4.22 or whatever the next release will be called.
>> >
>> > Please also see [2] for some more explanation.
>> >
>> > Thanks,
>> > Frieder
>> >
>> > [1] https://patchwork.ozlabs.org/cover/1007641/
>> > [2] https://patchwork.ozlabs.org/patch/922817/#1925445
>> >
>> >>
>> >> Frieder Schrempf (5):
>> >> arm64: dts: Remove unused properties from FSL QSPI driver nodes
>> >> ARM: dts: Remove unused properties from FSL QSPI driver nodes
>> >> ARM: dts: imx6sx-sdb: Fix the reg properties for the FSL QSPI nodes
>> >> arm64: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
>> >> ARM: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
>> >>
>> >> arch/arm/boot/dts/imx6sx-sdb-reva.dts | 8 ++++++--
>> >> arch/arm/boot/dts/imx6sx-sdb.dts | 8 ++++++--
>> >> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 ++
>> >> arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 5 ++---
>> >> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 3 ++-
>> >> arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 4 ++--
>> >> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 6 ++++--
>> >> arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi | 4 ++++
>> >> 8 files changed, 28 insertions(+), 12 deletions(-)
>> >>
>> > ______________________________________________________
>> > Linux MTD discussion mailing list
>> > http://lists.infradead.org/mailman/listinfo/linux-mtd/
>> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver
2018-12-15 10:04 ` AW: " Schrempf Frieder
@ 2018-12-16 7:51 ` Shawn Guo
0 siblings, 0 replies; 11+ messages in thread
From: Shawn Guo @ 2018-12-16 7:51 UTC (permalink / raw)
To: Schrempf Frieder
Cc: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-arm-kernel, devicetree, Sascha Hauer, boris.brezillon,
broonie, linux-mtd, linux-kernel, linux-spi
On Sat, Dec 15, 2018 at 10:04:55AM +0000, Schrempf Frieder wrote:
> I can confirm, that the series does only remove or add properties to the
> devicetree, that are currently not used by the driver. Therefore it won't break
> anything.
Okay, applied the series.
Shawn
^ permalink raw reply [flat|nested] 11+ messages in thread