From: Petr Mladek <pmladek@suse.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Jessica Yu <jeyu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] livepatch: fix non-static warnings
Date: Mon, 17 Dec 2018 13:03:17 +0100 [thread overview]
Message-ID: <20181217120317.yhbvdavcau3wykzd@pathway.suse.cz> (raw)
In-Reply-To: <1544965657-26804-1-git-send-email-hofrat@osadl.org>
On Sun 2018-12-16 14:07:37, Nicholas Mc Guire wrote:
> Sparse reported warnings about non-static symbols. For the variables
> a simple static attribute is fine - for those symbols referenced by
> livepatch via klp_func the symbol-names must be unmodified in the
> symbol table - to resolve this the __noclone attribute is used
> for the shared statically declared functions.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Suggested-by: Joe Lawrence <joe.lawrence@redhat.com>
> Link: https://lkml.org/lkml/2018/12/13/827
This is misleading. The "Link:" tag should point to the mail
where the commited version of the patch was being discussed.
It can be added by the maintainer.
Also please do not use links to https://lkml.org.
Messages disappear from time to time. It is much better
to use the redirector:
https://lkml.kernel.org/r/<message_id>
Best Regards,
Petr
PS: I was about to add Reviewed-by tag. But Miroslav (sitting
next to me) found out that __noclone was not the best solution.
I suggest to always wait few days between re-sending a new
version. This subsystem has many active reviewers ;-)
next prev parent reply other threads:[~2018-12-17 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 13:07 [PATCH V2] livepatch: fix non-static warnings Nicholas Mc Guire
2018-12-17 12:03 ` Petr Mladek [this message]
2018-12-17 12:03 ` Miroslav Benes
2018-12-17 15:44 ` Joe Lawrence
2018-12-17 19:23 ` Nicholas Mc Guire
2018-12-18 9:00 ` Miroslav Benes
2018-12-18 8:49 ` Miroslav Benes
2018-12-18 15:18 ` Joe Lawrence
2019-01-22 16:30 ` Joe Lawrence
2019-01-23 1:10 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217120317.yhbvdavcau3wykzd@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=hofrat@osadl.org \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).