From: Joe Lawrence <joe.lawrence@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jessica Yu <jeyu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Petr Mladek <pmladek@suse.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] livepatch: fix non-static warnings
Date: Tue, 18 Dec 2018 10:18:37 -0500 [thread overview]
Message-ID: <adeb1bca-9fa1-b150-d551-a9cf0853a63b@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.21.1812180934090.9644@pobox.suse.cz>
On 12/18/2018 03:49 AM, Miroslav Benes wrote:
> On Mon, 17 Dec 2018, Joe Lawrence wrote:
>
>> I'm just being picky about its documentation and how we should note its
>> usage in the v3 patch. Think that s/__noclone/used/g of the v2 commit
>> message would be sufficient?
>
> We could rephrase it. After all it is not only about symbol names in the
> symbol table. The traceable/patchable code has to be present...
>
> "Sparse reported warnings about non-static symbols. For the variables
> a simple static attribute is fine - for the functions referenced by
> livepatch via klp_func the symbol-names must be unmodified in the
> symbol table and the patchable code has to be emitted.
>
> Attach __used attribute to the shared statically declared functions."
>
> ?
That works for me.
-- Joe
next prev parent reply other threads:[~2018-12-18 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 13:07 [PATCH V2] livepatch: fix non-static warnings Nicholas Mc Guire
2018-12-17 12:03 ` Petr Mladek
2018-12-17 12:03 ` Miroslav Benes
2018-12-17 15:44 ` Joe Lawrence
2018-12-17 19:23 ` Nicholas Mc Guire
2018-12-18 9:00 ` Miroslav Benes
2018-12-18 8:49 ` Miroslav Benes
2018-12-18 15:18 ` Joe Lawrence [this message]
2019-01-22 16:30 ` Joe Lawrence
2019-01-23 1:10 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adeb1bca-9fa1-b150-d551-a9cf0853a63b@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=hofrat@osadl.org \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).