From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Burton <paul.burton@mips.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Marek Vasut <marex@denx.de>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Burton <pburton@wavecomp.com>,
Daniel Jedrychowski <avistel@gmail.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"
Date: Mon, 17 Dec 2018 16:18:51 +0100 [thread overview]
Message-ID: <20181217151851.GA21564@kroah.com> (raw)
In-Reply-To: <20181216223510.hxsdotf332ousinh@pburton-laptop>
On Sun, Dec 16, 2018 at 10:35:12PM +0000, Paul Burton wrote:
> Hi Ezequiel,
>
> On Sun, Dec 16, 2018 at 07:28:22PM -0300, Ezequiel Garcia wrote:
> > On Sun, 16 Dec 2018 at 19:24, Paul Burton <paul.burton@mips.com> wrote:
> > > This helps, but it only addresses one part of one of the 4 reasons I
> > > listed as motivation for my revert. For example serial8250_do_shutdown()
> > > also clearly intends to disable the FIFOs.
> > >
> >
> > OK. So, let's fix that :-)
>
> I already did, or at least tried to, on Thursday [1].
>
> > By all means, it would be really nice to push forward and fix the garbage
> > issue on JZ4780, as well as the transmission issue on AM335x.
> >
> > AM335x is a wildly popular platform, and it's not funny to break it.
>
> Well, clearly not if it was broken in v4.10 & only just fixed..? And
> from Marek's commit message the patch in v4.10 doesn't break the whole
> system just RS485.
>
> > So, let's please stop discussing which board we'll break and just fix both.
>
> I completely agree that would be ideal and I wrote a patch hoping to do
> that on Thursday, but didn't get any response on testing. It's late in
> the cycle hence a revert made sense. Simple as that.
A revert makes sense now, I'll go queue this up, thanks.
greg k-h
next prev parent reply other threads:[~2018-12-17 15:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 0:41 [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again Paul Burton
2018-12-13 0:55 ` Marek Vasut
2018-12-13 1:48 ` Paul Burton
2018-12-13 2:27 ` Marek Vasut
2018-12-13 3:33 ` Paul Burton
2018-12-13 4:18 ` Marek Vasut
2018-12-13 5:11 ` Paul Burton
2018-12-13 14:51 ` Marek Vasut
2018-12-13 17:48 ` Paul Burton
2018-12-16 20:10 ` [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again" Paul Burton
2018-12-16 20:32 ` Marek Vasut
2018-12-16 21:31 ` Paul Burton
2018-12-16 21:45 ` Marek Vasut
2018-12-16 21:52 ` Ezequiel Garcia
2018-12-16 22:11 ` Marek Vasut
2018-12-16 22:24 ` Paul Burton
2018-12-16 22:28 ` Ezequiel Garcia
2018-12-16 22:35 ` Paul Burton
2018-12-17 15:18 ` Greg Kroah-Hartman [this message]
2018-12-17 15:43 ` Marek Vasut
2018-12-17 16:30 ` Ezequiel Garcia
2018-12-17 17:20 ` Marek Vasut
2018-12-19 0:12 ` Marek Vasut
2018-12-16 22:16 ` Paul Burton
2018-12-16 21:08 ` Marek Vasut
2018-12-16 21:39 ` Paul Burton
2018-12-16 22:01 ` Marek Vasut
2018-12-16 22:28 ` Paul Burton
2018-12-21 20:08 ` Marek Vasut
2018-12-21 21:08 ` Paul Burton
2018-12-21 22:02 ` Marek Vasut
2018-12-24 15:43 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217151851.GA21564@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=avistel@gmail.com \
--cc=ezequiel@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marex@denx.de \
--cc=paul.burton@mips.com \
--cc=pburton@wavecomp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).