linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices for Facebook
@ 2018-12-17 20:04 Vijay Khemka
  2018-12-17 20:04 ` [PATCH v2 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC Vijay Khemka
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Vijay Khemka @ 2018-12-17 20:04 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
	devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
  Cc: vijaykhemka, openbmc @ lists . ozlabs . org

Added ADC and other sensor devices in Facebook Tiogapass device tree.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
 .../dts/aspeed-bmc-facebook-tiogapass.dts     | 23 +++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
index f8e7b71af7e6..64039dddd853 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
@@ -21,6 +21,17 @@
 	memory@80000000 {
 		reg = <0x80000000 0x20000000>;
 	};
+
+	iio-hwmon {
+		compatible = "iio-hwmon";
+		io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
+					<&adc 4>, <&adc 5>, <&adc 6>;
+	};
+
+	iio-hwmon-battery {
+		compatible = "iio-hwmon";
+		io-channels = <&adc 7>;
+	};
 };
 
 &fmc {
@@ -64,6 +75,10 @@
 	use-ncsi;
 };
 
+&adc {
+	status = "okay";
+};
+
 &i2c0 {
 	status = "okay";
 	//Airmax Conn B, CPU0 PIROM, CPU1 PIROM
@@ -122,6 +137,10 @@
 
 &i2c8 {
 	status = "okay";
+	tmp421@1f {
+		compatible = "ti,tmp421";
+		reg = <0x1f>;
+	};
 	//Mezz Sensor SMBus
 };
 
@@ -140,7 +159,7 @@
 	};
 
 	fan@1 {
-		reg = <0x00>;
-		aspeed,fan-tach-ch = /bits/ 8 <0x01>;
+		reg = <0x01>;
+		aspeed,fan-tach-ch = /bits/ 8 <0x02>;
 	};
 };
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC
  2018-12-17 20:04 [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices for Facebook Vijay Khemka
@ 2018-12-17 20:04 ` Vijay Khemka
  2019-01-17  2:47   ` Joel Stanley
  2018-12-17 20:04 ` [PATCH v2 3/4] ARM: dts: aspeed: Add KCS for Facebook Vijay Khemka
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 10+ messages in thread
From: Vijay Khemka @ 2018-12-17 20:04 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
	devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
  Cc: vijaykhemka, openbmc @ lists . ozlabs . org

Added kcs device support for lpc BMC.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
 arch/arm/boot/dts/aspeed-g5.dtsi | 33 +++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index d107459fc0f8..2743f400aa29 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -330,8 +330,32 @@
 				ranges = <0x0 0x1e789000 0x1000>;
 
 				lpc_bmc: lpc-bmc@0 {
-					compatible = "aspeed,ast2500-lpc-bmc";
+					compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
 					reg = <0x0 0x80>;
+					reg-io-width = <4>;
+
+					#address-cells = <1>;
+					#size-cells = <1>;
+					ranges = <0x0 0x0 0x80>;
+
+					kcs1: kcs1@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						interrupts = <8>;
+						kcs_chan = <1>;
+						status = "disabled";
+					};
+					kcs2: kcs2@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						interrupts = <8>;
+						kcs_chan = <2>;
+						status = "disabled";
+					};
+					kcs3: kcs3@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						interrupts = <8>;
+						kcs_chan = <3>;
+						status = "disabled";
+					};
 				};
 
 				lpc_host: lpc-host@80 {
@@ -343,6 +367,13 @@
 					#size-cells = <1>;
 					ranges = <0x0 0x80 0x1e0>;
 
+					kcs4: kcs4@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						interrupts = <8>;
+						kcs_chan = <4>;
+						status = "disabled";
+					};
+
 					lpc_ctrl: lpc-ctrl@0 {
 						compatible = "aspeed,ast2500-lpc-ctrl";
 						reg = <0x0 0x80>;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 3/4] ARM: dts: aspeed: Add KCS for Facebook
  2018-12-17 20:04 [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices for Facebook Vijay Khemka
  2018-12-17 20:04 ` [PATCH v2 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC Vijay Khemka
@ 2018-12-17 20:04 ` Vijay Khemka
  2019-01-17  2:47   ` Joel Stanley
  2018-12-17 20:04 ` [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl " Vijay Khemka
  2019-01-17  2:46 ` [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices " Joel Stanley
  3 siblings, 1 reply; 10+ messages in thread
From: Vijay Khemka @ 2018-12-17 20:04 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
	devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
  Cc: vijaykhemka, openbmc @ lists . ozlabs . org

Added kcs device in Facebook Tiogapass device tree.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
 arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
index 64039dddd853..73e58a821613 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
@@ -67,6 +67,18 @@
 	status = "okay";
 };
 
+&kcs2 {
+	// BMC KCS channel 2
+	status = "okay";
+	kcs_addr = <0xca8>;
+};
+
+&kcs3 {
+	// BMC KCS channel 3
+	status = "okay";
+	kcs_addr = <0xca2>;
+};
+
 &mac0 {
 	status = "okay";
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook
  2018-12-17 20:04 [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices for Facebook Vijay Khemka
  2018-12-17 20:04 ` [PATCH v2 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC Vijay Khemka
  2018-12-17 20:04 ` [PATCH v2 3/4] ARM: dts: aspeed: Add KCS for Facebook Vijay Khemka
@ 2018-12-17 20:04 ` Vijay Khemka
  2018-12-20 18:05   ` Vijay Khemka
  2019-01-17  2:46 ` [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices " Joel Stanley
  3 siblings, 1 reply; 10+ messages in thread
From: Vijay Khemka @ 2018-12-17 20:04 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
	devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
  Cc: vijaykhemka, openbmc @ lists . ozlabs . org

Added lpc ctrl device to enable LPC clock in Facebook
Tiogapass device tree.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
 .../boot/dts/aspeed-bmc-facebook-tiogapass.dts  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
index 73e58a821613..ef7875b54562 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
@@ -22,6 +22,17 @@
 		reg = <0x80000000 0x20000000>;
 	};
 
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		flash_memory: region@98000000 {
+			no-map;
+			reg = <0x98000000 0x00001000>; /* 4K */
+		};
+	};
+
 	iio-hwmon {
 		compatible = "iio-hwmon";
 		io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
@@ -54,6 +65,12 @@
 	};
 };
 
+&lpc_ctrl {
+	status = "okay";
+	memory-region = <&flash_memory>;
+	flash = <&spi1>;
+};
+
 &uart1 {
 	// Host Console
 	status = "okay";
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook
  2018-12-17 20:04 ` [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl " Vijay Khemka
@ 2018-12-20 18:05   ` Vijay Khemka
  2019-01-17  2:48     ` Joel Stanley
  0 siblings, 1 reply; 10+ messages in thread
From: Vijay Khemka @ 2018-12-20 18:05 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
	devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
  Cc: openbmc @ lists . ozlabs . org

Joel, Can you please take care of these patches merge.

On 12/17/18, 12:04 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:

    Added lpc ctrl device to enable LPC clock in Facebook
    Tiogapass device tree.
    
    Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    ---
     .../boot/dts/aspeed-bmc-facebook-tiogapass.dts  | 17 +++++++++++++++++
     1 file changed, 17 insertions(+)
    
    diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    index 73e58a821613..ef7875b54562 100644
    --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    @@ -22,6 +22,17 @@
     		reg = <0x80000000 0x20000000>;
     	};
     
    +	reserved-memory {
    +		#address-cells = <1>;
    +		#size-cells = <1>;
    +		ranges;
    +
    +		flash_memory: region@98000000 {
    +			no-map;
    +			reg = <0x98000000 0x00001000>; /* 4K */
    +		};
    +	};
    +
     	iio-hwmon {
     		compatible = "iio-hwmon";
     		io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
    @@ -54,6 +65,12 @@
     	};
     };
     
    +&lpc_ctrl {
    +	status = "okay";
    +	memory-region = <&flash_memory>;
    +	flash = <&spi1>;
    +};
    +
     &uart1 {
     	// Host Console
     	status = "okay";
    -- 
    2.17.1
    
    


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices for Facebook
  2018-12-17 20:04 [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices for Facebook Vijay Khemka
                   ` (2 preceding siblings ...)
  2018-12-17 20:04 ` [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl " Vijay Khemka
@ 2019-01-17  2:46 ` Joel Stanley
  3 siblings, 0 replies; 10+ messages in thread
From: Joel Stanley @ 2019-01-17  2:46 UTC (permalink / raw)
  To: Vijay Khemka
  Cc: Rob Herring, Mark Rutland, Andrew Jeffery, devicetree, Linux ARM,
	linux-aspeed, Linux Kernel Mailing List,
	openbmc @ lists . ozlabs . org

On Tue, 18 Dec 2018 at 07:04, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
> Added ADC and other sensor devices in Facebook Tiogapass device tree.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

Applied to the aspeed tree for 5.1.

Cheers,

Joel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC
  2018-12-17 20:04 ` [PATCH v2 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC Vijay Khemka
@ 2019-01-17  2:47   ` Joel Stanley
  0 siblings, 0 replies; 10+ messages in thread
From: Joel Stanley @ 2019-01-17  2:47 UTC (permalink / raw)
  To: Vijay Khemka
  Cc: Rob Herring, Mark Rutland, Andrew Jeffery, devicetree, Linux ARM,
	linux-aspeed, Linux Kernel Mailing List,
	openbmc @ lists . ozlabs . org

On Tue, 18 Dec 2018 at 07:04, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
> Added kcs device support for lpc BMC.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

Applied to the aspeed tree for 5.1.

Cheers,

Joel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/4] ARM: dts: aspeed: Add KCS for Facebook
  2018-12-17 20:04 ` [PATCH v2 3/4] ARM: dts: aspeed: Add KCS for Facebook Vijay Khemka
@ 2019-01-17  2:47   ` Joel Stanley
  0 siblings, 0 replies; 10+ messages in thread
From: Joel Stanley @ 2019-01-17  2:47 UTC (permalink / raw)
  To: Vijay Khemka
  Cc: Rob Herring, Mark Rutland, Andrew Jeffery, devicetree, Linux ARM,
	linux-aspeed, Linux Kernel Mailing List,
	openbmc @ lists . ozlabs . org

On Tue, 18 Dec 2018 at 07:04, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
> Added kcs device in Facebook Tiogapass device tree.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

Applied to the aspeed tree for 5.1.

Cheers,

Joel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook
  2018-12-20 18:05   ` Vijay Khemka
@ 2019-01-17  2:48     ` Joel Stanley
  2019-01-17 18:53       ` Vijay Khemka
  0 siblings, 1 reply; 10+ messages in thread
From: Joel Stanley @ 2019-01-17  2:48 UTC (permalink / raw)
  To: Vijay Khemka
  Cc: Rob Herring, Mark Rutland, Andrew Jeffery, devicetree,
	linux-arm-kernel, linux-aspeed, linux-kernel,
	openbmc @ lists . ozlabs . org

On Fri, 21 Dec 2018 at 05:06, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
> On 12/17/18, 12:04 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:
>
>     Added lpc ctrl device to enable LPC clock in Facebook
>     Tiogapass device tree.
>
>     Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
>
> Joel, Can you please take care of these patches merge.

I did not apply this one as I think the description will change once
we've merged your aspeed-lpc-ctrl patch.

Cheers,

Joel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook
  2019-01-17  2:48     ` Joel Stanley
@ 2019-01-17 18:53       ` Vijay Khemka
  0 siblings, 0 replies; 10+ messages in thread
From: Vijay Khemka @ 2019-01-17 18:53 UTC (permalink / raw)
  To: Joel Stanley
  Cc: Rob Herring, Mark Rutland, Andrew Jeffery, devicetree,
	linux-arm-kernel, linux-aspeed, linux-kernel,
	openbmc @ lists . ozlabs . org



On 1/16/19, 6:49 PM, "Joel Stanley" <joel@jms.id.au> wrote:

    On Fri, 21 Dec 2018 at 05:06, Vijay Khemka <vijaykhemka@fb.com> wrote:
    >
    > On 12/17/18, 12:04 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:
    >
    >     Added lpc ctrl device to enable LPC clock in Facebook
    >     Tiogapass device tree.
    >
    >     Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    >
    > Joel, Can you please take care of these patches merge.
    
    I did not apply this one as I think the description will change once
    we've merged your aspeed-lpc-ctrl patch.

Yes I will update and send new one.
    
    Cheers,
    
    Joel
    


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-01-17 18:53 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-17 20:04 [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices for Facebook Vijay Khemka
2018-12-17 20:04 ` [PATCH v2 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC Vijay Khemka
2019-01-17  2:47   ` Joel Stanley
2018-12-17 20:04 ` [PATCH v2 3/4] ARM: dts: aspeed: Add KCS for Facebook Vijay Khemka
2019-01-17  2:47   ` Joel Stanley
2018-12-17 20:04 ` [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl " Vijay Khemka
2018-12-20 18:05   ` Vijay Khemka
2019-01-17  2:48     ` Joel Stanley
2019-01-17 18:53       ` Vijay Khemka
2019-01-17  2:46 ` [PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices " Joel Stanley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).