linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: xlnx: change license header format style
@ 2018-12-19  9:40 Maruthi Srinivas Bayyavarapu
  2018-12-19 15:17 ` Christoph Hellwig
  2018-12-20 16:00 ` Applied "ASoC: xlnx: change license header format style" to the asoc tree Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Maruthi Srinivas Bayyavarapu @ 2018-12-19  9:40 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Rob Herring, Mark Rutland, Vishal Sagar, Michal Simek,
	Maruthi Srinivas Bayyavarapu, devicetree, linux-kernel,
	alsa-devel, linux-arm-kernel

Changed License header from C to C++ style comment block.

Signed-off-by: Maruthi Srinivas Bayyavarapu <maruthi.srinivas.bayyavarapu@xilinx.com>
---
 sound/soc/xilinx/xlnx_i2s.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/sound/soc/xilinx/xlnx_i2s.c b/sound/soc/xilinx/xlnx_i2s.c
index d4ae9ef..8b35316 100644
--- a/sound/soc/xilinx/xlnx_i2s.c
+++ b/sound/soc/xilinx/xlnx_i2s.c
@@ -1,12 +1,11 @@
 // SPDX-License-Identifier: GPL-2.0
-/*
- * Xilinx ASoC I2S audio support
- *
- * Copyright (C) 2018 Xilinx, Inc.
- *
- * Author: Praveen Vuppala <praveenv@xilinx.com>
- * Author: Maruthi Srinivas Bayyavarapu <maruthis@xilinx.com>
- */
+//
+// Xilinx ASoC I2S audio support
+//
+// Copyright (C) 2018 Xilinx, Inc.
+//
+// Author: Praveen Vuppala <praveenv@xilinx.com>
+// Author: Maruthi Srinivas Bayyavarapu <maruthis@xilinx.com>
 
 #include <linux/io.h>
 #include <linux/module.h>
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: xlnx: change license header format style
  2018-12-19  9:40 [PATCH] ASoC: xlnx: change license header format style Maruthi Srinivas Bayyavarapu
@ 2018-12-19 15:17 ` Christoph Hellwig
  2018-12-19 16:24   ` Mark Brown
  2018-12-20 16:00 ` Applied "ASoC: xlnx: change license header format style" to the asoc tree Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2018-12-19 15:17 UTC (permalink / raw)
  To: Maruthi Srinivas Bayyavarapu
  Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Rob Herring, Mark Rutland, Vishal Sagar, Michal Simek,
	devicetree, linux-kernel, alsa-devel, linux-arm-kernel

On Wed, Dec 19, 2018 at 03:10:40PM +0530, Maruthi Srinivas Bayyavarapu wrote:
> Changed License header from C to C++ style comment block.

Why this completely pointless uglification that goes counter to
the common style all over the kernel?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: xlnx: change license header format style
  2018-12-19 15:17 ` Christoph Hellwig
@ 2018-12-19 16:24   ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2018-12-19 16:24 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Maruthi Srinivas Bayyavarapu, Liam Girdwood, Jaroslav Kysela,
	Takashi Iwai, Rob Herring, Mark Rutland, Vishal Sagar,
	Michal Simek, devicetree, linux-kernel, alsa-devel,
	linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

On Wed, Dec 19, 2018 at 07:17:04AM -0800, Christoph Hellwig wrote:
> On Wed, Dec 19, 2018 at 03:10:40PM +0530, Maruthi Srinivas Bayyavarapu wrote:
> > Changed License header from C to C++ style comment block.

> Why this completely pointless uglification that goes counter to
> the common style all over the kernel?

I asked for it, when you end up with a C++ comment immediately adjacent
to a C comment block it doesn't exactly look clean and intentional
either.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Applied "ASoC: xlnx: change license header format style" to the asoc tree
  2018-12-19  9:40 [PATCH] ASoC: xlnx: change license header format style Maruthi Srinivas Bayyavarapu
  2018-12-19 15:17 ` Christoph Hellwig
@ 2018-12-20 16:00 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2018-12-20 16:00 UTC (permalink / raw)
  To: Maruthi Srinivas Bayyavarapu
  Cc: Mark Brown, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Rob Herring, Mark Rutland, Vishal Sagar,
	Michal Simek, devicetree, linux-kernel, alsa-devel,
	linux-arm-kernel, alsa-devel

The patch

   ASoC: xlnx: change license header format style

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From b5ac0078aa6c40ea46760dcebf1ac4022217a51d Mon Sep 17 00:00:00 2001
From: Maruthi Srinivas Bayyavarapu <maruthi.srinivas.bayyavarapu@xilinx.com>
Date: Wed, 19 Dec 2018 15:10:40 +0530
Subject: [PATCH] ASoC: xlnx: change license header format style

Changed License header from C to C++ style comment block.

Signed-off-by: Maruthi Srinivas Bayyavarapu <maruthi.srinivas.bayyavarapu@xilinx.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/xilinx/xlnx_i2s.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/sound/soc/xilinx/xlnx_i2s.c b/sound/soc/xilinx/xlnx_i2s.c
index d4ae9eff41ce..8b353166ad44 100644
--- a/sound/soc/xilinx/xlnx_i2s.c
+++ b/sound/soc/xilinx/xlnx_i2s.c
@@ -1,12 +1,11 @@
 // SPDX-License-Identifier: GPL-2.0
-/*
- * Xilinx ASoC I2S audio support
- *
- * Copyright (C) 2018 Xilinx, Inc.
- *
- * Author: Praveen Vuppala <praveenv@xilinx.com>
- * Author: Maruthi Srinivas Bayyavarapu <maruthis@xilinx.com>
- */
+//
+// Xilinx ASoC I2S audio support
+//
+// Copyright (C) 2018 Xilinx, Inc.
+//
+// Author: Praveen Vuppala <praveenv@xilinx.com>
+// Author: Maruthi Srinivas Bayyavarapu <maruthis@xilinx.com>
 
 #include <linux/io.h>
 #include <linux/module.h>
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-12-20 16:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19  9:40 [PATCH] ASoC: xlnx: change license header format style Maruthi Srinivas Bayyavarapu
2018-12-19 15:17 ` Christoph Hellwig
2018-12-19 16:24   ` Mark Brown
2018-12-20 16:00 ` Applied "ASoC: xlnx: change license header format style" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).