* [PATCH] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through
@ 2018-12-20 15:43 Gustavo A. R. Silva
2018-12-21 0:48 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-12-20 15:43 UTC (permalink / raw)
To: Sathya Prakash, Chaitra P B, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen
Cc: MPT-FusionLinux.pdl, linux-scsi, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1475400 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 22df12698d43..6be39dc27103 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -10377,6 +10377,7 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
case MPI26_MFGPAGE_DEVID_CFG_SEC_3916:
dev_info(&pdev->dev,
"HBA is in Configurable Secure mode\n");
+ /* fall through */
case MPI26_MFGPAGE_DEVID_HARD_SEC_3816:
case MPI26_MFGPAGE_DEVID_HARD_SEC_3916:
ioc->is_aero_ioc = ioc->is_gen35_ioc = 1;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through
2018-12-20 15:43 [PATCH] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through Gustavo A. R. Silva
@ 2018-12-21 0:48 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-12-21 0:48 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Sathya Prakash, Chaitra P B, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen, MPT-FusionLinux.pdl,
linux-scsi, linux-kernel
Gustavo A.,
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
Applied to 4.21/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-21 0:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20 15:43 [PATCH] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through Gustavo A. R. Silva
2018-12-21 0:48 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).