From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Johan Hovold <johan@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Marcel Partap <mpartap@gmx.net>,
Merlijn Wajer <merlijn@wizzup.org>,
Michael Scott <hashcode0f@gmail.com>, NeKit <nekit1000@gmail.com>,
omerlle@gmail.com, Sebastian Reichel <sre@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Rob Herring <robh@kernel.org>
Subject: Re: WIP Droid 4 voice calls, GNSS & PM with a TS 27.010 serdev driver
Date: Sun, 23 Dec 2018 20:59:37 +0100 [thread overview]
Message-ID: <20181223195937.GE15237@amd> (raw)
In-Reply-To: <20181223155147.GI6707@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]
On Sun 2018-12-23 07:51:47, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [181223 11:11]:
> > I added some printks to motmdm_probe, and they don't appear to be
> > called. I wonder if I'm missing something else in the config? I do
> > have serial
> >
> > root@devuan:/my/ko# ls -al /dev/ttyS0
> > crw-rw---- 1 root dialout 4, 64 Dec 23 11:52 /dev/ttyS0
> >
> > but not gsm multiplex:
> >
> > root@devuan:/my/ko# ls -al /dev/gsm*
> > ls: cannot access '/dev/gsm*': No such file or directory
>
> Hmm with serdev you should not get /dev/ttyS0, so maybe you're missing:
>
> CONFIG_SERIAL_DEV_BUS=y
> CONFIG_SERIAL_DEV_CTRL_TTYPORT=y
I had those enabled.
I also have
CONFIG_SERIAL_OMAP=y
CONFIG_SERIAL_OMAP_CONSOLE=y
> Probably the Kconfig dependency should be for SERIAL_DEV_CTRL_TTYPORT
> instead of SERIAL_DEV_BUS in these patches if that helps.
>
> Or else you're missing the serdev related dts changes?
Thanks for the hints, but dts looks ok, too.
We still have
uart1: serial@0 {
compatible = "ti,omap4-uart";
in omap4-l4.dtsi, right? ...
I see that CONFIG_SERIAL_OMAP=y and 8250_omap handles same
hardware. Let me try disabling CONFIG_SERIAL_OMAP=y.
Best regards,
Pavel
Oh and you may want to apply this:
diff --git a/drivers/mfd/motorola-mdm.c b/drivers/mfd/motorola-mdm.c
index 2b7c324..2cdc9e8 100644
--- a/drivers/mfd/motorola-mdm.c
+++ b/drivers/mfd/motorola-mdm.c
@@ -1141,5 +1152,5 @@ module_serdev_device_driver(motmdm_driver);
MODULE_ALIAS("platform:motorola-mdm");
MODULE_DESCRIPTION("Motorola Modem TS 27.010 serdev driver");
-MODULE_AUTHOR("Tony Lindgren <tony@atomide.com");
+MODULE_AUTHOR("Tony Lindgren <tony@atomide.com>");
MODULE_LICENSE("GPL v2");
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-12-23 20:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 0:44 WIP Droid 4 voice calls, GNSS & PM with a TS 27.010 serdev driver Tony Lindgren
2018-12-18 12:46 ` Pavel Machek
2018-12-18 15:36 ` Tony Lindgren
2018-12-18 20:22 ` Pavel Machek
2018-12-18 21:53 ` Tony Lindgren
2019-01-16 13:48 ` Pavel Machek
2019-01-17 2:54 ` Tony Lindgren
2019-01-17 12:51 ` Pavel Machek
2018-12-22 23:05 ` Pavel Machek
2018-12-23 10:33 ` Pavel Machek
2018-12-23 11:10 ` Pavel Machek
2018-12-23 15:51 ` Tony Lindgren
2018-12-23 19:59 ` Pavel Machek [this message]
2018-12-26 21:16 ` Pavel Machek
2018-12-27 10:16 ` Pavel Machek
2018-12-28 19:31 ` Tony Lindgren
2018-12-28 20:46 ` Pavel Machek
2018-12-28 22:28 ` Tony Lindgren
2018-12-28 23:25 ` Pavel Machek
2018-12-28 23:34 ` Tony Lindgren
2018-12-31 22:20 ` Tony Lindgren
2019-01-16 13:58 ` Pavel Machek
2019-01-16 14:59 ` Tony Lindgren
2019-01-16 15:09 ` Tony Lindgren
2019-01-16 23:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181223195937.GE15237@amd \
--to=pavel@ucw.cz \
--cc=hashcode0f@gmail.com \
--cc=jarkko.nikula@bitmer.com \
--cc=johan@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=omerlle@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).