linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: wlan-ng: prism2fw.c: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning"
@ 2018-12-24 16:11 Prathamesh Deshpande
  2019-01-02  9:46 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Prathamesh Deshpande @ 2018-12-24 16:11 UTC (permalink / raw)
  To: osdevtc, gregkh; +Cc: devel, linux-kernel, prathameshdeshpande7

This patch removes unnecessary out of memory warning
message from wlan-ng prism2fw.c file.

Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
---
 drivers/staging/wlan-ng/prism2fw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index bb572b7..c040066 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -557,7 +557,6 @@ static int mkimage(struct imgchunk *clist, unsigned int *ccnt)
 	for (i = 0; i < *ccnt; i++) {
 		clist[i].data = kzalloc(clist[i].len, GFP_KERNEL);
 		if (!clist[i].data) {
-			pr_err("failed to allocate image space, exiting.\n");
 			return 1;
 		}
 		pr_debug("chunk[%d]: addr=0x%06x len=%d\n",
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: wlan-ng: prism2fw.c: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning"
  2018-12-24 16:11 [PATCH] staging: wlan-ng: prism2fw.c: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning" Prathamesh Deshpande
@ 2019-01-02  9:46 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-01-02  9:46 UTC (permalink / raw)
  To: Prathamesh Deshpande; +Cc: osdevtc, gregkh, devel, linux-kernel

The subject is too long.

On Mon, Dec 24, 2018 at 08:11:28AM -0800, Prathamesh Deshpande wrote:
> This patch removes unnecessary out of memory warning
> message from wlan-ng prism2fw.c file.
> 
> Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2fw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index bb572b7..c040066 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -557,7 +557,6 @@ static int mkimage(struct imgchunk *clist, unsigned int *ccnt)
>  	for (i = 0; i < *ccnt; i++) {
>  		clist[i].data = kzalloc(clist[i].len, GFP_KERNEL);
>  		if (!clist[i].data) {
> -			pr_err("failed to allocate image space, exiting.\n");
>  			return 1;
>  		}

Remove the curly braces.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-02  9:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-24 16:11 [PATCH] staging: wlan-ng: prism2fw.c: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning" Prathamesh Deshpande
2019-01-02  9:46 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).