* [PATCH v5 0/3] Stingray thermal driver support
@ 2018-10-16 15:11 Srinath Mannam
2018-10-16 15:11 ` [PATCH v5 1/3] dt-bindings: thermal: Add binding document for SR thermal Srinath Mannam
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Srinath Mannam @ 2018-10-16 15:11 UTC (permalink / raw)
To: daniel.lezcano, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland
Cc: devicetree, linux-kernel, bcm-kernel-feedback-list, Srinath Mannam
These patches adds the stingray thermal driver and its
corresponding DT nodes with documentation.
Changes from v4
- Addressed Rob Herring comments on DT parameters and
thermal driver architecture.
- Removed brcm,max-crit-temp DT parameter
- Changed driver to thermal sensor registration model.
- Added trip DT properties.
Changes from v3
- Addressed Daniel lezcano comments.
- Elaborated commit description of thermal driver patch.
- Added brcm,max-crit-temp DT parameter.
Changes from v2:
- All stingray TMON DT nodes are combine together into single.
Temperature registers are combined into one mem resource.
brcm,tmon-mask parameter has available TMONs mask value.
- All available TMONs are initialized together in single
instance of driver probe call.
Changes from v1:
- Fixed auto build sparce warning.
Pramod Kumar (3):
dt-bindings: thermal: Add binding document for SR thermal
thermal: broadcom: Add Stingray thermal driver
arm64: dts: stingray: Add Stingray Thermal DT support.
.../bindings/thermal/brcm,sr-thermal.txt | 105 ++++++++++++++++
.../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 +++++++++++++
drivers/thermal/Kconfig | 3 +-
drivers/thermal/broadcom/Kconfig | 9 ++
drivers/thermal/broadcom/Makefile | 1 +
drivers/thermal/broadcom/sr-thermal.c | 138 +++++++++++++++++++++
6 files changed, 344 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
create mode 100644 drivers/thermal/broadcom/sr-thermal.c
--
2.7.4
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH v5 1/3] dt-bindings: thermal: Add binding document for SR thermal 2018-10-16 15:11 [PATCH v5 0/3] Stingray thermal driver support Srinath Mannam @ 2018-10-16 15:11 ` Srinath Mannam 2018-10-18 14:36 ` Rob Herring 2018-10-16 15:11 ` [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver Srinath Mannam ` (3 subsequent siblings) 4 siblings, 1 reply; 14+ messages in thread From: Srinath Mannam @ 2018-10-16 15:11 UTC (permalink / raw) To: daniel.lezcano, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland Cc: devicetree, linux-kernel, bcm-kernel-feedback-list, Pramod Kumar, Srinath Mannam From: Pramod Kumar <pramod.kumar@broadcom.com> Add binding document for supported thermal implementation in Stingray. Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> Reviewed-by: Ray Jui <ray.jui@broadcom.com> Reviewed-by: Scott Branden <scott.branden@broadcom.com> --- .../bindings/thermal/brcm,sr-thermal.txt | 105 +++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt new file mode 100644 index 0000000..3ab3302 --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt @@ -0,0 +1,105 @@ +* Broadcom Stingray Thermal + +This binding describes thermal sensors that is part of Stingray SoCs. + +Required properties: +- compatible : Must be "brcm,sr-thermal" +- reg : Memory where tmon data will be available. +- brcm,tmon-mask: A one cell bit mask of valid TMON sources. + Each bit represents single TMON source. +- #thermal-sensor-cells : Thermal sensor phandler +- polling-delay: Max number of milliseconds to wait between polls. +- thermal-sensors: A list of thermal sensor phandles and specifier. + specifier value is tmon ID and it should be + in correspond with brcm,tmon-mask. +- temperature: trip temperature threshold in millicelsius. + +Example: + tmons { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x0 0x8f100000 0x100>; + + tmon: tmon@0 { + compatible = "brcm,sr-thermal"; + reg = <0x0 0x40>; + brcm,tmon-mask = <0x3f>; + #thermal-sensor-cells = <1>; + }; + }; + + thermal-zones { + ihost0_thermal: ihost0-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 0>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + ihost1_thermal: ihost1-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 1>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + ihost2_thermal: ihost2-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 2>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + ihost3_thermal: ihost3-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 3>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + crmu_thermal: crmu-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 4>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + nitro_thermal: nitro-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 5>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v5 1/3] dt-bindings: thermal: Add binding document for SR thermal 2018-10-16 15:11 ` [PATCH v5 1/3] dt-bindings: thermal: Add binding document for SR thermal Srinath Mannam @ 2018-10-18 14:36 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2018-10-18 14:36 UTC (permalink / raw) To: Srinath Mannam Cc: daniel.lezcano, Zhang Rui, Eduardo Valentin, Mark Rutland, devicetree, linux-kernel, bcm-kernel-feedback-list, Pramod Kumar, Srinath Mannam On Tue, 16 Oct 2018 20:41:18 +0530, Srinath Mannam wrote: > From: Pramod Kumar <pramod.kumar@broadcom.com> > > Add binding document for supported thermal implementation > in Stingray. > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > Reviewed-by: Scott Branden <scott.branden@broadcom.com> > --- > .../bindings/thermal/brcm,sr-thermal.txt | 105 +++++++++++++++++++++ > 1 file changed, 105 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver 2018-10-16 15:11 [PATCH v5 0/3] Stingray thermal driver support Srinath Mannam 2018-10-16 15:11 ` [PATCH v5 1/3] dt-bindings: thermal: Add binding document for SR thermal Srinath Mannam @ 2018-10-16 15:11 ` Srinath Mannam 2019-01-02 20:03 ` Eduardo Valentin 2018-10-16 15:11 ` [PATCH v5 3/3] arm64: dts: stingray: Add Stingray Thermal DT support Srinath Mannam ` (2 subsequent siblings) 4 siblings, 1 reply; 14+ messages in thread From: Srinath Mannam @ 2018-10-16 15:11 UTC (permalink / raw) To: daniel.lezcano, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland Cc: devicetree, linux-kernel, bcm-kernel-feedback-list, Pramod Kumar, Srinath Mannam From: Pramod Kumar <pramod.kumar@broadcom.com> Stingray SoC has six temperature sensor and those are configured, controlled and accessed to read temperature and update in DDR memory using m0 firmware. All six sensors has been given 4 bytes of memory in DDR to write temperature in millivolts. This thermal driver read temperature values from DDR because no direct access to sensors. Like this all temparature sensors are monitored and trips at critical temperature. If driver can't handle thermal runaways because of any unknown reason, then firmware in m0 Processor will handle. Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> Reviewed-by: Ray Jui <ray.jui@broadcom.com> Reviewed-by: Scott Branden <scott.branden@broadcom.com> Reviewed-by: Vikram Prakash <vikram.prakash@broadcom.com> --- drivers/thermal/Kconfig | 3 +- drivers/thermal/broadcom/Kconfig | 9 +++ drivers/thermal/broadcom/Makefile | 1 + drivers/thermal/broadcom/sr-thermal.c | 138 ++++++++++++++++++++++++++++++++++ 4 files changed, 150 insertions(+), 1 deletion(-) create mode 100644 drivers/thermal/broadcom/sr-thermal.c diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 0e69edc..5f9f070 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -416,7 +416,8 @@ config MTK_THERMAL controller present in Mediatek SoCs menu "Broadcom thermal drivers" -depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST +depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || ARCH_BCM_IPROC || \ + COMPILE_TEST source "drivers/thermal/broadcom/Kconfig" endmenu diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig index c106a15..dc9a9bd 100644 --- a/drivers/thermal/broadcom/Kconfig +++ b/drivers/thermal/broadcom/Kconfig @@ -22,3 +22,12 @@ config BCM_NS_THERMAL BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device Management Unit) block with a thermal sensor that allows checking CPU temperature. + +config BCM_SR_THERMAL + tristate "Stingray thermal driver" + depends on ARCH_BCM_IPROC || COMPILE_TEST + default ARCH_BCM_IPROC + help + Support for the Stingray family of SoCs. Its different blocks like + iHost, CRMU and NITRO has thermal sensor that allows checking its + temperature. diff --git a/drivers/thermal/broadcom/Makefile b/drivers/thermal/broadcom/Makefile index fae10ec..79df69e 100644 --- a/drivers/thermal/broadcom/Makefile +++ b/drivers/thermal/broadcom/Makefile @@ -1,3 +1,4 @@ obj-$(CONFIG_BCM2835_THERMAL) += bcm2835_thermal.o obj-$(CONFIG_BRCMSTB_THERMAL) += brcmstb_thermal.o obj-$(CONFIG_BCM_NS_THERMAL) += ns-thermal.o +obj-$(CONFIG_BCM_SR_THERMAL) += sr-thermal.o diff --git a/drivers/thermal/broadcom/sr-thermal.c b/drivers/thermal/broadcom/sr-thermal.c new file mode 100644 index 0000000..f45e12e --- /dev/null +++ b/drivers/thermal/broadcom/sr-thermal.c @@ -0,0 +1,138 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2018 Broadcom + */ + +#include <linux/acpi.h> +#include <linux/module.h> +#include <linux/of_address.h> +#include <linux/platform_device.h> +#include <linux/thermal.h> + +/* + * In stingray thermal IO memory, + * Total Number of available TMONs MASK is at offset 0 + * temperature registers BASE is at 4 byte offset. + * Each TMON temperature register size is 4. + */ +#define SR_TMON_TEMP_BASE(id) ((id) * 0x4) + +#define SR_TMON_MAX_LIST 6 + +struct sr_tmon { + struct thermal_zone_device *tz; + unsigned int crit_temp; + unsigned int tmon_id; + struct sr_thermal *priv; +}; + +struct sr_thermal { + void __iomem *regs; + unsigned int max_crit_temp; + struct sr_tmon tmon[SR_TMON_MAX_LIST]; +}; + +static int sr_get_temp(void *data, int *temp) +{ + struct sr_tmon *tmon = data; + struct sr_thermal *sr_thermal = tmon->priv; + + *temp = readl(sr_thermal->regs + SR_TMON_TEMP_BASE(tmon->tmon_id)); + + return 0; +} + +static const struct thermal_zone_of_device_ops sr_tz_ops = { + .get_temp = sr_get_temp, +}; + +static int sr_thermal_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct sr_thermal *sr_thermal; + struct sr_tmon *tmon; + struct resource *res; + uint32_t sr_tmon_list = 0; + unsigned int i; + int ret; + + sr_thermal = devm_kzalloc(dev, sizeof(*sr_thermal), GFP_KERNEL); + if (!sr_thermal) + return -ENOMEM; + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + sr_thermal->regs = (void __iomem *)devm_memremap(&pdev->dev, res->start, + resource_size(res), + MEMREMAP_WB); + if (IS_ERR(sr_thermal->regs)) { + dev_err(dev, "failed to get io address\n"); + return PTR_ERR(sr_thermal->regs); + } + + ret = device_property_read_u32(dev, "brcm,tmon-mask", &sr_tmon_list); + if (ret) + return ret; + + tmon = sr_thermal->tmon; + for (i = 0; i < SR_TMON_MAX_LIST; i++, tmon++) { + + if (!(sr_tmon_list & BIT(i))) + continue; + + /* Flush temperature registers */ + writel(0, sr_thermal->regs + SR_TMON_TEMP_BASE(i)); + tmon->tmon_id = i; + tmon->priv = sr_thermal; + tmon->tz = devm_thermal_zone_of_sensor_register(dev, i, tmon, + &sr_tz_ops); + if (IS_ERR(tmon->tz)) + return PTR_ERR(tmon->tz); + + dev_info(dev, "thermal sensor %d registered\n", i); + } + platform_set_drvdata(pdev, sr_thermal); + + return 0; +} + +static int sr_thermal_remove(struct platform_device *pdev) +{ + struct sr_thermal *sr_thermal = platform_get_drvdata(pdev); + unsigned int i; + struct sr_tmon *tmon; + + tmon = sr_thermal->tmon; + for (i = 0; i < SR_TMON_MAX_LIST; i++, tmon++) + if (tmon->tz) + devm_thermal_zone_of_sensor_unregister(&pdev->dev, + tmon->tz); + + return 0; +} + +static const struct of_device_id sr_thermal_of_match[] = { + { .compatible = "brcm,sr-thermal", }, + {}, +}; +MODULE_DEVICE_TABLE(of, sr_thermal_of_match); + +static const struct acpi_device_id sr_thermal_acpi_ids[] = { + { .id = "BRCM0500" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(acpi, sr_thermal_acpi_ids); + +static struct platform_driver sr_thermal_driver = { + .probe = sr_thermal_probe, + .remove = sr_thermal_remove, + .driver = { + .name = "sr-thermal", + .of_match_table = sr_thermal_of_match, + .acpi_match_table = ACPI_PTR(sr_thermal_acpi_ids), + }, +}; +module_platform_driver(sr_thermal_driver); + +MODULE_AUTHOR("Pramod Kumar <pramod.kumar@broadcom.com>"); +MODULE_DESCRIPTION("Stingray thermal driver"); +MODULE_LICENSE("GPL v2"); -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver 2018-10-16 15:11 ` [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver Srinath Mannam @ 2019-01-02 20:03 ` Eduardo Valentin 2019-01-03 6:28 ` Srinath Mannam 0 siblings, 1 reply; 14+ messages in thread From: Eduardo Valentin @ 2019-01-02 20:03 UTC (permalink / raw) To: Srinath Mannam Cc: daniel.lezcano, Zhang Rui, Rob Herring, Mark Rutland, devicetree, linux-kernel, bcm-kernel-feedback-list, Pramod Kumar On Tue, Oct 16, 2018 at 08:41:19PM +0530, Srinath Mannam wrote: > From: Pramod Kumar <pramod.kumar@broadcom.com> > > Stingray SoC has six temperature sensor and those are > configured, controlled and accessed to read temperature > and update in DDR memory using m0 firmware. > All six sensors has been given 4 bytes of memory in DDR > to write temperature in millivolts. > > This thermal driver read temperature values from DDR > because no direct access to sensors. > Like this all temparature sensors are monitored and > trips at critical temperature. > > If driver can't handle thermal runaways because of > any unknown reason, then firmware in m0 Processor > will handle. > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > Reviewed-by: Scott Branden <scott.branden@broadcom.com> > Reviewed-by: Vikram Prakash <vikram.prakash@broadcom.com> > --- > drivers/thermal/Kconfig | 3 +- > drivers/thermal/broadcom/Kconfig | 9 +++ > drivers/thermal/broadcom/Makefile | 1 + > drivers/thermal/broadcom/sr-thermal.c | 138 ++++++++++++++++++++++++++++++++++ > 4 files changed, 150 insertions(+), 1 deletion(-) > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 0e69edc..5f9f070 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -416,7 +416,8 @@ config MTK_THERMAL > controller present in Mediatek SoCs > > menu "Broadcom thermal drivers" > -depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST > +depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || ARCH_BCM_IPROC || \ > + COMPILE_TEST > source "drivers/thermal/broadcom/Kconfig" > endmenu > > diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig > index c106a15..dc9a9bd 100644 > --- a/drivers/thermal/broadcom/Kconfig > +++ b/drivers/thermal/broadcom/Kconfig > @@ -22,3 +22,12 @@ config BCM_NS_THERMAL > BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device > Management Unit) block with a thermal sensor that allows checking CPU > temperature. > + > +config BCM_SR_THERMAL > + tristate "Stingray thermal driver" > + depends on ARCH_BCM_IPROC || COMPILE_TEST > + default ARCH_BCM_IPROC > + help > + Support for the Stingray family of SoCs. Its different blocks like > + iHost, CRMU and NITRO has thermal sensor that allows checking its > + temperature. > diff --git a/drivers/thermal/broadcom/Makefile b/drivers/thermal/broadcom/Makefile > index fae10ec..79df69e 100644 > --- a/drivers/thermal/broadcom/Makefile > +++ b/drivers/thermal/broadcom/Makefile > @@ -1,3 +1,4 @@ > obj-$(CONFIG_BCM2835_THERMAL) += bcm2835_thermal.o > obj-$(CONFIG_BRCMSTB_THERMAL) += brcmstb_thermal.o > obj-$(CONFIG_BCM_NS_THERMAL) += ns-thermal.o > +obj-$(CONFIG_BCM_SR_THERMAL) += sr-thermal.o > diff --git a/drivers/thermal/broadcom/sr-thermal.c b/drivers/thermal/broadcom/sr-thermal.c > new file mode 100644 > index 0000000..f45e12e > --- /dev/null > +++ b/drivers/thermal/broadcom/sr-thermal.c > @@ -0,0 +1,138 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2018 Broadcom > + */ > + > +#include <linux/acpi.h> > +#include <linux/module.h> > +#include <linux/of_address.h> > +#include <linux/platform_device.h> > +#include <linux/thermal.h> > + > +/* > + * In stingray thermal IO memory, > + * Total Number of available TMONs MASK is at offset 0 > + * temperature registers BASE is at 4 byte offset. > + * Each TMON temperature register size is 4. > + */ > +#define SR_TMON_TEMP_BASE(id) ((id) * 0x4) > + > +#define SR_TMON_MAX_LIST 6 > + > +struct sr_tmon { > + struct thermal_zone_device *tz; > + unsigned int crit_temp; > + unsigned int tmon_id; > + struct sr_thermal *priv; > +}; > + > +struct sr_thermal { > + void __iomem *regs; > + unsigned int max_crit_temp; > + struct sr_tmon tmon[SR_TMON_MAX_LIST]; > +}; > + > +static int sr_get_temp(void *data, int *temp) > +{ > + struct sr_tmon *tmon = data; > + struct sr_thermal *sr_thermal = tmon->priv; > + > + *temp = readl(sr_thermal->regs + SR_TMON_TEMP_BASE(tmon->tmon_id)); > + > + return 0; > +} > + > +static const struct thermal_zone_of_device_ops sr_tz_ops = { > + .get_temp = sr_get_temp, > +}; > + > +static int sr_thermal_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct sr_thermal *sr_thermal; > + struct sr_tmon *tmon; > + struct resource *res; > + uint32_t sr_tmon_list = 0; > + unsigned int i; > + int ret; > + > + sr_thermal = devm_kzalloc(dev, sizeof(*sr_thermal), GFP_KERNEL); > + if (!sr_thermal) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + sr_thermal->regs = (void __iomem *)devm_memremap(&pdev->dev, res->start, > + resource_size(res), > + MEMREMAP_WB); > + if (IS_ERR(sr_thermal->regs)) { > + dev_err(dev, "failed to get io address\n"); > + return PTR_ERR(sr_thermal->regs); > + } > + > + ret = device_property_read_u32(dev, "brcm,tmon-mask", &sr_tmon_list); > + if (ret) > + return ret; > + > + tmon = sr_thermal->tmon; > + for (i = 0; i < SR_TMON_MAX_LIST; i++, tmon++) { > + > + if (!(sr_tmon_list & BIT(i))) > + continue; > + > + /* Flush temperature registers */ > + writel(0, sr_thermal->regs + SR_TMON_TEMP_BASE(i)); > + tmon->tmon_id = i; > + tmon->priv = sr_thermal; > + tmon->tz = devm_thermal_zone_of_sensor_register(dev, i, tmon, > + &sr_tz_ops); > + if (IS_ERR(tmon->tz)) > + return PTR_ERR(tmon->tz); > + > + dev_info(dev, "thermal sensor %d registered\n", i); > Does this really need to be dev_info() level? Usually just pollutes boot message logs.. + } > + platform_set_drvdata(pdev, sr_thermal); > + > + return 0; > +} > + > +static int sr_thermal_remove(struct platform_device *pdev) > +{ > + struct sr_thermal *sr_thermal = platform_get_drvdata(pdev); > + unsigned int i; > + struct sr_tmon *tmon; > + > + tmon = sr_thermal->tmon; > + for (i = 0; i < SR_TMON_MAX_LIST; i++, tmon++) > + if (tmon->tz) > + devm_thermal_zone_of_sensor_unregister(&pdev->dev, > + tmon->tz); Why did you need to explicitly call devm_.*unregister()? > + > + return 0; > +} > + > +static const struct of_device_id sr_thermal_of_match[] = { > + { .compatible = "brcm,sr-thermal", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, sr_thermal_of_match); > + > +static const struct acpi_device_id sr_thermal_acpi_ids[] = { > + { .id = "BRCM0500" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(acpi, sr_thermal_acpi_ids); > + > +static struct platform_driver sr_thermal_driver = { > + .probe = sr_thermal_probe, > + .remove = sr_thermal_remove, > + .driver = { > + .name = "sr-thermal", > + .of_match_table = sr_thermal_of_match, > + .acpi_match_table = ACPI_PTR(sr_thermal_acpi_ids), > + }, > +}; > +module_platform_driver(sr_thermal_driver); > + > +MODULE_AUTHOR("Pramod Kumar <pramod.kumar@broadcom.com>"); > +MODULE_DESCRIPTION("Stingray thermal driver"); > +MODULE_LICENSE("GPL v2"); > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver 2019-01-02 20:03 ` Eduardo Valentin @ 2019-01-03 6:28 ` Srinath Mannam 0 siblings, 0 replies; 14+ messages in thread From: Srinath Mannam @ 2019-01-03 6:28 UTC (permalink / raw) To: Eduardo Valentin Cc: Daniel Lezcano, Zhang Rui, Rob Herring, Mark Rutland, devicetree, Linux Kernel Mailing List, BCM Kernel Feedback, Pramod Kumar Hi Eduardo Valentin, Thank you for the review. I will address your comments in next patchset. Please find my comments in lined. On Thu, Jan 3, 2019 at 1:33 AM Eduardo Valentin <edubezval@gmail.com> wrote: > > On Tue, Oct 16, 2018 at 08:41:19PM +0530, Srinath Mannam wrote: > > From: Pramod Kumar <pramod.kumar@broadcom.com> > > > > Stingray SoC has six temperature sensor and those are > > configured, controlled and accessed to read temperature > > and update in DDR memory using m0 firmware. > > All six sensors has been given 4 bytes of memory in DDR > > to write temperature in millivolts. > > > > This thermal driver read temperature values from DDR > > because no direct access to sensors. > > Like this all temparature sensors are monitored and > > trips at critical temperature. > > > > If driver can't handle thermal runaways because of > > any unknown reason, then firmware in m0 Processor > > will handle. > > > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > > Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> > > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > > Reviewed-by: Scott Branden <scott.branden@broadcom.com> > > Reviewed-by: Vikram Prakash <vikram.prakash@broadcom.com> > > --- > > drivers/thermal/Kconfig | 3 +- > > drivers/thermal/broadcom/Kconfig | 9 +++ > > drivers/thermal/broadcom/Makefile | 1 + > > drivers/thermal/broadcom/sr-thermal.c | 138 ++++++++++++++++++++++++++++++++++ > > 4 files changed, 150 insertions(+), 1 deletion(-) > > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 0e69edc..5f9f070 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -416,7 +416,8 @@ config MTK_THERMAL > > controller present in Mediatek SoCs > > > > menu "Broadcom thermal drivers" > > -depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST > > +depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || ARCH_BCM_IPROC || \ > > + COMPILE_TEST > > source "drivers/thermal/broadcom/Kconfig" > > endmenu > > > > diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig > > index c106a15..dc9a9bd 100644 > > --- a/drivers/thermal/broadcom/Kconfig > > +++ b/drivers/thermal/broadcom/Kconfig > > @@ -22,3 +22,12 @@ config BCM_NS_THERMAL > > BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device > > Management Unit) block with a thermal sensor that allows checking CPU > > temperature. > > + > > +config BCM_SR_THERMAL > > + tristate "Stingray thermal driver" > > + depends on ARCH_BCM_IPROC || COMPILE_TEST > > + default ARCH_BCM_IPROC > > + help > > + Support for the Stingray family of SoCs. Its different blocks like > > + iHost, CRMU and NITRO has thermal sensor that allows checking its > > + temperature. > > diff --git a/drivers/thermal/broadcom/Makefile b/drivers/thermal/broadcom/Makefile > > index fae10ec..79df69e 100644 > > --- a/drivers/thermal/broadcom/Makefile > > +++ b/drivers/thermal/broadcom/Makefile > > @@ -1,3 +1,4 @@ > > obj-$(CONFIG_BCM2835_THERMAL) += bcm2835_thermal.o > > obj-$(CONFIG_BRCMSTB_THERMAL) += brcmstb_thermal.o > > obj-$(CONFIG_BCM_NS_THERMAL) += ns-thermal.o > > +obj-$(CONFIG_BCM_SR_THERMAL) += sr-thermal.o > > diff --git a/drivers/thermal/broadcom/sr-thermal.c b/drivers/thermal/broadcom/sr-thermal.c > > new file mode 100644 > > index 0000000..f45e12e > > --- /dev/null > > +++ b/drivers/thermal/broadcom/sr-thermal.c > > @@ -0,0 +1,138 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2018 Broadcom > > + */ > > + > > +#include <linux/acpi.h> > > +#include <linux/module.h> > > +#include <linux/of_address.h> > > +#include <linux/platform_device.h> > > +#include <linux/thermal.h> > > + > > +/* > > + * In stingray thermal IO memory, > > + * Total Number of available TMONs MASK is at offset 0 > > + * temperature registers BASE is at 4 byte offset. > > + * Each TMON temperature register size is 4. > > + */ > > +#define SR_TMON_TEMP_BASE(id) ((id) * 0x4) > > + > > +#define SR_TMON_MAX_LIST 6 > > + > > +struct sr_tmon { > > + struct thermal_zone_device *tz; > > + unsigned int crit_temp; > > + unsigned int tmon_id; > > + struct sr_thermal *priv; > > +}; > > + > > +struct sr_thermal { > > + void __iomem *regs; > > + unsigned int max_crit_temp; > > + struct sr_tmon tmon[SR_TMON_MAX_LIST]; > > +}; > > + > > +static int sr_get_temp(void *data, int *temp) > > +{ > > + struct sr_tmon *tmon = data; > > + struct sr_thermal *sr_thermal = tmon->priv; > > + > > + *temp = readl(sr_thermal->regs + SR_TMON_TEMP_BASE(tmon->tmon_id)); > > + > > + return 0; > > +} > > + > > +static const struct thermal_zone_of_device_ops sr_tz_ops = { > > + .get_temp = sr_get_temp, > > +}; > > + > > +static int sr_thermal_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct sr_thermal *sr_thermal; > > + struct sr_tmon *tmon; > > + struct resource *res; > > + uint32_t sr_tmon_list = 0; > > + unsigned int i; > > + int ret; > > + > > + sr_thermal = devm_kzalloc(dev, sizeof(*sr_thermal), GFP_KERNEL); > > + if (!sr_thermal) > > + return -ENOMEM; > > + > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + sr_thermal->regs = (void __iomem *)devm_memremap(&pdev->dev, res->start, > > + resource_size(res), > > + MEMREMAP_WB); > > + if (IS_ERR(sr_thermal->regs)) { > > + dev_err(dev, "failed to get io address\n"); > > + return PTR_ERR(sr_thermal->regs); > > + } > > + > > + ret = device_property_read_u32(dev, "brcm,tmon-mask", &sr_tmon_list); > > + if (ret) > > + return ret; > > + > > + tmon = sr_thermal->tmon; > > + for (i = 0; i < SR_TMON_MAX_LIST; i++, tmon++) { > > + > > + if (!(sr_tmon_list & BIT(i))) > > + continue; > > + > > + /* Flush temperature registers */ > > + writel(0, sr_thermal->regs + SR_TMON_TEMP_BASE(i)); > > + tmon->tmon_id = i; > > + tmon->priv = sr_thermal; > > + tmon->tz = devm_thermal_zone_of_sensor_register(dev, i, tmon, > > + &sr_tz_ops); > > + if (IS_ERR(tmon->tz)) > > + return PTR_ERR(tmon->tz); > > + > > + dev_info(dev, "thermal sensor %d registered\n", i); > > > > Does this really need to be dev_info() level? Usually just pollutes boot > message logs.. I will change dev_info to dev_dbg. > > + } > > + platform_set_drvdata(pdev, sr_thermal); > > + > > + return 0; > > +} > > + > > +static int sr_thermal_remove(struct platform_device *pdev) > > +{ > > + struct sr_thermal *sr_thermal = platform_get_drvdata(pdev); > > + unsigned int i; > > + struct sr_tmon *tmon; > > + > > + tmon = sr_thermal->tmon; > > + for (i = 0; i < SR_TMON_MAX_LIST; i++, tmon++) > > + if (tmon->tz) > > + devm_thermal_zone_of_sensor_unregister(&pdev->dev, > > + tmon->tz); > > Why did you need to explicitly call devm_.*unregister()? Yes, this call is not required I will remove sr_thermal_remove function completely. > > > + > > + return 0; > > +} > > + > > +static const struct of_device_id sr_thermal_of_match[] = { > > + { .compatible = "brcm,sr-thermal", }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, sr_thermal_of_match); > > + > > +static const struct acpi_device_id sr_thermal_acpi_ids[] = { > > + { .id = "BRCM0500" }, > > + { /* sentinel */ } > > +}; > > +MODULE_DEVICE_TABLE(acpi, sr_thermal_acpi_ids); > > + > > +static struct platform_driver sr_thermal_driver = { > > + .probe = sr_thermal_probe, > > + .remove = sr_thermal_remove, > > + .driver = { > > + .name = "sr-thermal", > > + .of_match_table = sr_thermal_of_match, > > + .acpi_match_table = ACPI_PTR(sr_thermal_acpi_ids), > > + }, > > +}; > > +module_platform_driver(sr_thermal_driver); > > + > > +MODULE_AUTHOR("Pramod Kumar <pramod.kumar@broadcom.com>"); > > +MODULE_DESCRIPTION("Stingray thermal driver"); > > +MODULE_LICENSE("GPL v2"); > > -- > > 2.7.4 > > Regards, Srinath. ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v5 3/3] arm64: dts: stingray: Add Stingray Thermal DT support. 2018-10-16 15:11 [PATCH v5 0/3] Stingray thermal driver support Srinath Mannam 2018-10-16 15:11 ` [PATCH v5 1/3] dt-bindings: thermal: Add binding document for SR thermal Srinath Mannam 2018-10-16 15:11 ` [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver Srinath Mannam @ 2018-10-16 15:11 ` Srinath Mannam 2018-10-18 19:10 ` [PATCH v5 0/3] Stingray thermal driver support Scott Branden 2018-11-07 22:15 ` Florian Fainelli 4 siblings, 0 replies; 14+ messages in thread From: Srinath Mannam @ 2018-10-16 15:11 UTC (permalink / raw) To: daniel.lezcano, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland Cc: devicetree, linux-kernel, bcm-kernel-feedback-list, Pramod Kumar, Srinath Mannam From: Pramod Kumar <pramod.kumar@broadcom.com> Add DT nodes for thermal zones memory base address to read temperature. Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> Reviewed-by: Ray Jui <ray.jui@broadcom.com> Reviewed-by: Scott Branden <scott.branden@broadcom.com> --- .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 ++++++++++++++++++++++ 1 file changed, 89 insertions(+) diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi index e283480..0d246ba 100644 --- a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi +++ b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi @@ -612,4 +612,93 @@ status = "disabled"; }; }; + + tmons { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x0 0x8f100000 0x100>; + + tmon: tmon@0 { + compatible = "brcm,sr-thermal"; + reg = <0x0 0x40>; + brcm,tmon-mask = <0x3f>; + #thermal-sensor-cells = <1>; + }; + }; + + thermal-zones { + ihost0_thermal: ihost0-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 0>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + ihost1_thermal: ihost1-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 1>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + ihost2_thermal: ihost2-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 2>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + ihost3_thermal: ihost3-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 3>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + crmu_thermal: crmu-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 4>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + nitro_thermal: nitro-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + thermal-sensors = <&tmon 5>; + trips { + cpu-crit { + temperature = <105000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + }; }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] Stingray thermal driver support 2018-10-16 15:11 [PATCH v5 0/3] Stingray thermal driver support Srinath Mannam ` (2 preceding siblings ...) 2018-10-16 15:11 ` [PATCH v5 3/3] arm64: dts: stingray: Add Stingray Thermal DT support Srinath Mannam @ 2018-10-18 19:10 ` Scott Branden 2018-11-07 22:15 ` Florian Fainelli 4 siblings, 0 replies; 14+ messages in thread From: Scott Branden @ 2018-10-18 19:10 UTC (permalink / raw) To: Srinath Mannam, daniel.lezcano, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland Cc: devicetree, linux-kernel, bcm-kernel-feedback-list All Acked-by: Scott Branden <scott.branden@broadcom.com> On 2018-10-16 8:11 a.m., Srinath Mannam wrote: > These patches adds the stingray thermal driver and its > corresponding DT nodes with documentation. > > Changes from v4 > - Addressed Rob Herring comments on DT parameters and > thermal driver architecture. > - Removed brcm,max-crit-temp DT parameter > - Changed driver to thermal sensor registration model. > - Added trip DT properties. > > Changes from v3 > - Addressed Daniel lezcano comments. > - Elaborated commit description of thermal driver patch. > - Added brcm,max-crit-temp DT parameter. > > Changes from v2: > - All stingray TMON DT nodes are combine together into single. > Temperature registers are combined into one mem resource. > brcm,tmon-mask parameter has available TMONs mask value. > - All available TMONs are initialized together in single > instance of driver probe call. > > Changes from v1: > - Fixed auto build sparce warning. > > Pramod Kumar (3): > dt-bindings: thermal: Add binding document for SR thermal > thermal: broadcom: Add Stingray thermal driver > arm64: dts: stingray: Add Stingray Thermal DT support. > > .../bindings/thermal/brcm,sr-thermal.txt | 105 ++++++++++++++++ > .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 +++++++++++++ > drivers/thermal/Kconfig | 3 +- > drivers/thermal/broadcom/Kconfig | 9 ++ > drivers/thermal/broadcom/Makefile | 1 + > drivers/thermal/broadcom/sr-thermal.c | 138 +++++++++++++++++++++ > 6 files changed, 344 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] Stingray thermal driver support 2018-10-16 15:11 [PATCH v5 0/3] Stingray thermal driver support Srinath Mannam ` (3 preceding siblings ...) 2018-10-18 19:10 ` [PATCH v5 0/3] Stingray thermal driver support Scott Branden @ 2018-11-07 22:15 ` Florian Fainelli 2018-12-05 3:17 ` Srinath Mannam 4 siblings, 1 reply; 14+ messages in thread From: Florian Fainelli @ 2018-11-07 22:15 UTC (permalink / raw) To: Srinath Mannam, daniel.lezcano, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland Cc: devicetree, linux-kernel, bcm-kernel-feedback-list On 10/16/2018 8:11 AM, Srinath Mannam wrote: > These patches adds the stingray thermal driver and its > corresponding DT nodes with documentation. Can we get feedback from the thermal maintains whether this is acceptable or not? > > Changes from v4 > - Addressed Rob Herring comments on DT parameters and > thermal driver architecture. > - Removed brcm,max-crit-temp DT parameter > - Changed driver to thermal sensor registration model. > - Added trip DT properties. > > Changes from v3 > - Addressed Daniel lezcano comments. > - Elaborated commit description of thermal driver patch. > - Added brcm,max-crit-temp DT parameter. > > Changes from v2: > - All stingray TMON DT nodes are combine together into single. > Temperature registers are combined into one mem resource. > brcm,tmon-mask parameter has available TMONs mask value. > - All available TMONs are initialized together in single > instance of driver probe call. > > Changes from v1: > - Fixed auto build sparce warning. > > Pramod Kumar (3): > dt-bindings: thermal: Add binding document for SR thermal > thermal: broadcom: Add Stingray thermal driver > arm64: dts: stingray: Add Stingray Thermal DT support. > > .../bindings/thermal/brcm,sr-thermal.txt | 105 ++++++++++++++++ > .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 +++++++++++++ > drivers/thermal/Kconfig | 3 +- > drivers/thermal/broadcom/Kconfig | 9 ++ > drivers/thermal/broadcom/Makefile | 1 + > drivers/thermal/broadcom/sr-thermal.c | 138 +++++++++++++++++++++ > 6 files changed, 344 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > -- Florian ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] Stingray thermal driver support 2018-11-07 22:15 ` Florian Fainelli @ 2018-12-05 3:17 ` Srinath Mannam 2018-12-31 22:15 ` Florian Fainelli 0 siblings, 1 reply; 14+ messages in thread From: Srinath Mannam @ 2018-12-05 3:17 UTC (permalink / raw) To: Florian Fainelli Cc: Daniel Lezcano, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland, devicetree, Linux Kernel Mailing List, BCM Kernel Feedback Hi, Could you please provide your feedback to this patch series? Regards, Srinath. On Thu, Nov 8, 2018 at 3:45 AM Florian Fainelli <f.fainelli@gmail.com> wrote: > > > > On 10/16/2018 8:11 AM, Srinath Mannam wrote: > > These patches adds the stingray thermal driver and its > > corresponding DT nodes with documentation. > > Can we get feedback from the thermal maintains whether this is > acceptable or not? > > > > > Changes from v4 > > - Addressed Rob Herring comments on DT parameters and > > thermal driver architecture. > > - Removed brcm,max-crit-temp DT parameter > > - Changed driver to thermal sensor registration model. > > - Added trip DT properties. > > > > Changes from v3 > > - Addressed Daniel lezcano comments. > > - Elaborated commit description of thermal driver patch. > > - Added brcm,max-crit-temp DT parameter. > > > > Changes from v2: > > - All stingray TMON DT nodes are combine together into single. > > Temperature registers are combined into one mem resource. > > brcm,tmon-mask parameter has available TMONs mask value. > > - All available TMONs are initialized together in single > > instance of driver probe call. > > > > Changes from v1: > > - Fixed auto build sparce warning. > > > > Pramod Kumar (3): > > dt-bindings: thermal: Add binding document for SR thermal > > thermal: broadcom: Add Stingray thermal driver > > arm64: dts: stingray: Add Stingray Thermal DT support. > > > > .../bindings/thermal/brcm,sr-thermal.txt | 105 ++++++++++++++++ > > .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 +++++++++++++ > > drivers/thermal/Kconfig | 3 +- > > drivers/thermal/broadcom/Kconfig | 9 ++ > > drivers/thermal/broadcom/Makefile | 1 + > > drivers/thermal/broadcom/sr-thermal.c | 138 +++++++++++++++++++++ > > 6 files changed, 344 insertions(+), 1 deletion(-) > > create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > > > > -- > Florian ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] Stingray thermal driver support 2018-12-05 3:17 ` Srinath Mannam @ 2018-12-31 22:15 ` Florian Fainelli 2019-01-01 14:04 ` Zhang Rui 0 siblings, 1 reply; 14+ messages in thread From: Florian Fainelli @ 2018-12-31 22:15 UTC (permalink / raw) To: Srinath Mannam, Florian Fainelli, Daniel Lezcano, Zhang Rui, Eduardo Valentin Cc: Rob Herring, Mark Rutland, devicetree, Linux Kernel Mailing List, BCM Kernel Feedback On 04/12/2018 19:17, Srinath Mannam wrote: > Hi, > > Could you please provide your feedback to this patch series? Rui or Eduardo can we get either one of you to review the thermal driver parts of this patch series? Why do we constantly have to chase people to respond in this specific subsystem? > > Regards, > Srinath. > On Thu, Nov 8, 2018 at 3:45 AM Florian Fainelli <f.fainelli@gmail.com> wrote: >> >> >> >> On 10/16/2018 8:11 AM, Srinath Mannam wrote: >>> These patches adds the stingray thermal driver and its >>> corresponding DT nodes with documentation. >> >> Can we get feedback from the thermal maintains whether this is >> acceptable or not? >> >>> >>> Changes from v4 >>> - Addressed Rob Herring comments on DT parameters and >>> thermal driver architecture. >>> - Removed brcm,max-crit-temp DT parameter >>> - Changed driver to thermal sensor registration model. >>> - Added trip DT properties. >>> >>> Changes from v3 >>> - Addressed Daniel lezcano comments. >>> - Elaborated commit description of thermal driver patch. >>> - Added brcm,max-crit-temp DT parameter. >>> >>> Changes from v2: >>> - All stingray TMON DT nodes are combine together into single. >>> Temperature registers are combined into one mem resource. >>> brcm,tmon-mask parameter has available TMONs mask value. >>> - All available TMONs are initialized together in single >>> instance of driver probe call. >>> >>> Changes from v1: >>> - Fixed auto build sparce warning. >>> >>> Pramod Kumar (3): >>> dt-bindings: thermal: Add binding document for SR thermal >>> thermal: broadcom: Add Stingray thermal driver >>> arm64: dts: stingray: Add Stingray Thermal DT support. >>> >>> .../bindings/thermal/brcm,sr-thermal.txt | 105 ++++++++++++++++ >>> .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 +++++++++++++ >>> drivers/thermal/Kconfig | 3 +- >>> drivers/thermal/broadcom/Kconfig | 9 ++ >>> drivers/thermal/broadcom/Makefile | 1 + >>> drivers/thermal/broadcom/sr-thermal.c | 138 +++++++++++++++++++++ >>> 6 files changed, 344 insertions(+), 1 deletion(-) >>> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>> create mode 100644 drivers/thermal/broadcom/sr-thermal.c >>> >> >> -- >> Florian -- Florian ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] Stingray thermal driver support 2018-12-31 22:15 ` Florian Fainelli @ 2019-01-01 14:04 ` Zhang Rui 2019-01-01 16:07 ` Eduardo Valentin 0 siblings, 1 reply; 14+ messages in thread From: Zhang Rui @ 2019-01-01 14:04 UTC (permalink / raw) To: Florian Fainelli, Srinath Mannam, Florian Fainelli, Daniel Lezcano, Eduardo Valentin Cc: Rob Herring, Mark Rutland, devicetree, Linux Kernel Mailing List, BCM Kernel Feedback On 一, 2018-12-31 at 14:15 -0800, Florian Fainelli wrote: > > On 04/12/2018 19:17, Srinath Mannam wrote: > > > > Hi, > > > > Could you please provide your feedback to this patch series? > Rui or Eduardo can we get either one of you to review the thermal > driver > parts of this patch series? Why do we constantly have to chase people > to > respond in this specific subsystem? > Eduardo, can you please take a look at this patch series? thanks, rui > > > > > > Regards, > > Srinath. > > On Thu, Nov 8, 2018 at 3:45 AM Florian Fainelli <f.fainelli@gmail.c > > om> wrote: > > > > > > > > > > > > > > > On 10/16/2018 8:11 AM, Srinath Mannam wrote: > > > > > > > > These patches adds the stingray thermal driver and its > > > > corresponding DT nodes with documentation. > > > Can we get feedback from the thermal maintains whether this is > > > acceptable or not? > > > > > > > > > > > > > > > Changes from v4 > > > > - Addressed Rob Herring comments on DT parameters and > > > > thermal driver architecture. > > > > - Removed brcm,max-crit-temp DT parameter > > > > - Changed driver to thermal sensor registration model. > > > > - Added trip DT properties. > > > > > > > > Changes from v3 > > > > - Addressed Daniel lezcano comments. > > > > - Elaborated commit description of thermal driver patch. > > > > - Added brcm,max-crit-temp DT parameter. > > > > > > > > Changes from v2: > > > > - All stingray TMON DT nodes are combine together into > > > > single. > > > > Temperature registers are combined into one mem resource. > > > > brcm,tmon-mask parameter has available TMONs mask value. > > > > - All available TMONs are initialized together in single > > > > instance of driver probe call. > > > > > > > > Changes from v1: > > > > - Fixed auto build sparce warning. > > > > > > > > Pramod Kumar (3): > > > > dt-bindings: thermal: Add binding document for SR thermal > > > > thermal: broadcom: Add Stingray thermal driver > > > > arm64: dts: stingray: Add Stingray Thermal DT support. > > > > > > > > .../bindings/thermal/brcm,sr-thermal.txt | 105 > > > > ++++++++++++++++ > > > > .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 > > > > +++++++++++++ > > > > drivers/thermal/Kconfig | 3 +- > > > > drivers/thermal/broadcom/Kconfig | 9 ++ > > > > drivers/thermal/broadcom/Makefile | 1 + > > > > drivers/thermal/broadcom/sr-thermal.c | 138 > > > > +++++++++++++++++++++ > > > > 6 files changed, 344 insertions(+), 1 deletion(-) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > > > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > > > > > > > -- > > > Florian ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] Stingray thermal driver support 2019-01-01 14:04 ` Zhang Rui @ 2019-01-01 16:07 ` Eduardo Valentin 2019-01-02 4:32 ` Srinath Mannam 0 siblings, 1 reply; 14+ messages in thread From: Eduardo Valentin @ 2019-01-01 16:07 UTC (permalink / raw) To: Zhang Rui Cc: Florian Fainelli, Srinath Mannam, Florian Fainelli, Daniel Lezcano, Rob Herring, Mark Rutland, devicetree, Linux Kernel Mailing List, BCM Kernel Feedback On Tue, Jan 01, 2019 at 10:04:39PM +0800, Zhang Rui wrote: > On 一, 2018-12-31 at 14:15 -0800, Florian Fainelli wrote: > > > > On 04/12/2018 19:17, Srinath Mannam wrote: > > > > > > Hi, > > > > > > Could you please provide your feedback to this patch series? > > Rui or Eduardo can we get either one of you to review the thermal > > driver > > parts of this patch series? Why do we constantly have to chase people > > to > > respond in this specific subsystem? > > > Eduardo, can you please take a look at this patch series? Yup, I will take a look. > > thanks, > rui > > > > > > > > > Regards, > > > Srinath. > > > On Thu, Nov 8, 2018 at 3:45 AM Florian Fainelli <f.fainelli@gmail.c > > > om> wrote: > > > > > > > > > > > > > > > > > > > > On 10/16/2018 8:11 AM, Srinath Mannam wrote: > > > > > > > > > > These patches adds the stingray thermal driver and its > > > > > corresponding DT nodes with documentation. > > > > Can we get feedback from the thermal maintains whether this is > > > > acceptable or not? > > > > > > > > > > > > > > > > > > > Changes from v4 > > > > > - Addressed Rob Herring comments on DT parameters and > > > > > thermal driver architecture. > > > > > - Removed brcm,max-crit-temp DT parameter > > > > > - Changed driver to thermal sensor registration model. > > > > > - Added trip DT properties. > > > > > > > > > > Changes from v3 > > > > > - Addressed Daniel lezcano comments. > > > > > - Elaborated commit description of thermal driver patch. > > > > > - Added brcm,max-crit-temp DT parameter. > > > > > > > > > > Changes from v2: > > > > > - All stingray TMON DT nodes are combine together into > > > > > single. > > > > > Temperature registers are combined into one mem resource. > > > > > brcm,tmon-mask parameter has available TMONs mask value. > > > > > - All available TMONs are initialized together in single > > > > > instance of driver probe call. > > > > > > > > > > Changes from v1: > > > > > - Fixed auto build sparce warning. > > > > > > > > > > Pramod Kumar (3): > > > > > dt-bindings: thermal: Add binding document for SR thermal > > > > > thermal: broadcom: Add Stingray thermal driver > > > > > arm64: dts: stingray: Add Stingray Thermal DT support. > > > > > > > > > > .../bindings/thermal/brcm,sr-thermal.txt | 105 > > > > > ++++++++++++++++ > > > > > .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 > > > > > +++++++++++++ > > > > > drivers/thermal/Kconfig | 3 +- > > > > > drivers/thermal/broadcom/Kconfig | 9 ++ > > > > > drivers/thermal/broadcom/Makefile | 1 + > > > > > drivers/thermal/broadcom/sr-thermal.c | 138 > > > > > +++++++++++++++++++++ > > > > > 6 files changed, 344 insertions(+), 1 deletion(-) > > > > > create mode 100644 > > > > > Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > > > > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > > > > > > > > > -- > > > > Florian ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] Stingray thermal driver support 2019-01-01 16:07 ` Eduardo Valentin @ 2019-01-02 4:32 ` Srinath Mannam 0 siblings, 0 replies; 14+ messages in thread From: Srinath Mannam @ 2019-01-02 4:32 UTC (permalink / raw) To: Eduardo Valentin Cc: Zhang Rui, Florian Fainelli, Florian Fainelli, Daniel Lezcano, Rob Herring, Mark Rutland, devicetree, Linux Kernel Mailing List, BCM Kernel Feedback Hi Rui, Eduardo, Wish you very happy new year and Thank you very much for your response. Regards, Srinath. On Tue, Jan 1, 2019 at 9:37 PM Eduardo Valentin <edubezval@gmail.com> wrote: > > On Tue, Jan 01, 2019 at 10:04:39PM +0800, Zhang Rui wrote: > > On 一, 2018-12-31 at 14:15 -0800, Florian Fainelli wrote: > > > > > > On 04/12/2018 19:17, Srinath Mannam wrote: > > > > > > > > Hi, > > > > > > > > Could you please provide your feedback to this patch series? > > > Rui or Eduardo can we get either one of you to review the thermal > > > driver > > > parts of this patch series? Why do we constantly have to chase people > > > to > > > respond in this specific subsystem? > > > > > Eduardo, can you please take a look at this patch series? > > Yup, I will take a look. > > > > > thanks, > > rui > > > > > > > > > > > > Regards, > > > > Srinath. > > > > On Thu, Nov 8, 2018 at 3:45 AM Florian Fainelli <f.fainelli@gmail.c > > > > om> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > On 10/16/2018 8:11 AM, Srinath Mannam wrote: > > > > > > > > > > > > These patches adds the stingray thermal driver and its > > > > > > corresponding DT nodes with documentation. > > > > > Can we get feedback from the thermal maintains whether this is > > > > > acceptable or not? > > > > > > > > > > > > > > > > > > > > > > > Changes from v4 > > > > > > - Addressed Rob Herring comments on DT parameters and > > > > > > thermal driver architecture. > > > > > > - Removed brcm,max-crit-temp DT parameter > > > > > > - Changed driver to thermal sensor registration model. > > > > > > - Added trip DT properties. > > > > > > > > > > > > Changes from v3 > > > > > > - Addressed Daniel lezcano comments. > > > > > > - Elaborated commit description of thermal driver patch. > > > > > > - Added brcm,max-crit-temp DT parameter. > > > > > > > > > > > > Changes from v2: > > > > > > - All stingray TMON DT nodes are combine together into > > > > > > single. > > > > > > Temperature registers are combined into one mem resource. > > > > > > brcm,tmon-mask parameter has available TMONs mask value. > > > > > > - All available TMONs are initialized together in single > > > > > > instance of driver probe call. > > > > > > > > > > > > Changes from v1: > > > > > > - Fixed auto build sparce warning. > > > > > > > > > > > > Pramod Kumar (3): > > > > > > dt-bindings: thermal: Add binding document for SR thermal > > > > > > thermal: broadcom: Add Stingray thermal driver > > > > > > arm64: dts: stingray: Add Stingray Thermal DT support. > > > > > > > > > > > > .../bindings/thermal/brcm,sr-thermal.txt | 105 > > > > > > ++++++++++++++++ > > > > > > .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 > > > > > > +++++++++++++ > > > > > > drivers/thermal/Kconfig | 3 +- > > > > > > drivers/thermal/broadcom/Kconfig | 9 ++ > > > > > > drivers/thermal/broadcom/Makefile | 1 + > > > > > > drivers/thermal/broadcom/sr-thermal.c | 138 > > > > > > +++++++++++++++++++++ > > > > > > 6 files changed, 344 insertions(+), 1 deletion(-) > > > > > > create mode 100644 > > > > > > Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > > > > > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > > > > > > > > > > > -- > > > > > Florian ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-01-03 6:28 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-10-16 15:11 [PATCH v5 0/3] Stingray thermal driver support Srinath Mannam 2018-10-16 15:11 ` [PATCH v5 1/3] dt-bindings: thermal: Add binding document for SR thermal Srinath Mannam 2018-10-18 14:36 ` Rob Herring 2018-10-16 15:11 ` [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver Srinath Mannam 2019-01-02 20:03 ` Eduardo Valentin 2019-01-03 6:28 ` Srinath Mannam 2018-10-16 15:11 ` [PATCH v5 3/3] arm64: dts: stingray: Add Stingray Thermal DT support Srinath Mannam 2018-10-18 19:10 ` [PATCH v5 0/3] Stingray thermal driver support Scott Branden 2018-11-07 22:15 ` Florian Fainelli 2018-12-05 3:17 ` Srinath Mannam 2018-12-31 22:15 ` Florian Fainelli 2019-01-01 14:04 ` Zhang Rui 2019-01-01 16:07 ` Eduardo Valentin 2019-01-02 4:32 ` Srinath Mannam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).