* [PATCHv3 0/2] tools: Various build flags fixes
@ 2019-01-03 16:13 Jiri Olsa
2019-01-03 16:13 ` [PATCH 1/2] tools thermal tmon: Use -O3 instead of -O1 if available Jiri Olsa
2019-01-03 16:13 ` [PATCH 2/2] tools iio: Override CFLAGS assignments Jiri Olsa
0 siblings, 2 replies; 5+ messages in thread
From: Jiri Olsa @ 2019-01-03 16:13 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Hartmut Knaack, Jonathan Cameron, Lars-Peter Clausen, Len Brown,
Markus Mayer, Shuah Khan, Thomas Renninger, Zhang Rui, lkml,
Ingo Molnar, Namhyung Kim, Alexander Shishkin, Peter Zijlstra
hi,
while hardening some of the tools rpm, we noticed we
can't pass build flags to some of them.
Sending separate tools fixes for what we found. It's
mostly override for CFLAGS and adding LDFLAGS to the
build commands.
Any additional reviews would be great.. ;-)
v3 changes:
- 4 more patches accepted, still 2 to go
- rebased on top of Arnaldo's perf/core
v2 changes:
- 4 patches already accepted, still 6 to go
- adding more people to cc
Also available in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
tools/flags_v3
thanks,
jirka
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Len Brown <len.brown@intel.com>
Cc: Markus Mayer <mmayer@broadcom.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Len Brown <len.brown@intel.com>
Cc: Thomas Renninger <trenn@suse.com>
Cc: Zhang Rui <rui.zhang@intel.com>
---
Jiri Olsa (2):
tools thermal tmon: Use -O3 instead of -O1 if available
tools iio: Override CFLAGS assignments
tools/iio/Makefile | 2 +-
tools/thermal/tmon/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] tools thermal tmon: Use -O3 instead of -O1 if available
2019-01-03 16:13 [PATCHv3 0/2] tools: Various build flags fixes Jiri Olsa
@ 2019-01-03 16:13 ` Jiri Olsa
2019-01-08 15:39 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2019-01-03 16:13 ` [PATCH 2/2] tools iio: Override CFLAGS assignments Jiri Olsa
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Olsa @ 2019-01-03 16:13 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Brian Norris, Zhang Rui, Markus Mayer, lkml, Ingo Molnar,
Namhyung Kim, Alexander Shishkin, Peter Zijlstra
Using -O3 instead of -O1 if it's supported by compiler.
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Markus Mayer <mmayer@broadcom.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/thermal/tmon/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon/Makefile
index 89a2444c1df2..59e417ec3e13 100644
--- a/tools/thermal/tmon/Makefile
+++ b/tools/thermal/tmon/Makefile
@@ -6,7 +6,7 @@ VERSION = 1.0
BINDIR=usr/bin
WARNFLAGS=-Wall -Wshadow -W -Wformat -Wimplicit-function-declaration -Wimplicit-int
-override CFLAGS+= -O1 ${WARNFLAGS}
+override CFLAGS+= $(call cc-option,-O3,-O1) ${WARNFLAGS}
# Add "-fstack-protector" only if toolchain supports it.
override CFLAGS+= $(call cc-option,-fstack-protector-strong)
CC?= $(CROSS_COMPILE)gcc
--
2.17.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [tip:perf/urgent] tools thermal tmon: Use -O3 instead of -O1 if available
2019-01-03 16:13 ` [PATCH 1/2] tools thermal tmon: Use -O3 instead of -O1 if available Jiri Olsa
@ 2019-01-08 15:39 ` tip-bot for Jiri Olsa
0 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Jiri Olsa @ 2019-01-08 15:39 UTC (permalink / raw)
To: linux-tip-commits
Cc: hpa, acme, mmayer, jolsa, linux-kernel, peterz, namhyung,
alexander.shishkin, computersforpeace, mingo, rui.zhang, tglx
Commit-ID: 302df34c4e64b9e83ee31cbf508b38b62b428bd6
Gitweb: https://git.kernel.org/tip/302df34c4e64b9e83ee31cbf508b38b62b428bd6
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Thu, 3 Jan 2019 17:13:49 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 4 Jan 2019 12:54:49 -0300
tools thermal tmon: Use -O3 instead of -O1 if available
Using -O3 instead of -O1 if it's supported by compiler.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Markus Mayer <mmayer@broadcom.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Zhang Rui <rui.zhang@intel.com>
Link: http://lkml.kernel.org/r/20190103161350.11446-2-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/thermal/tmon/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon/Makefile
index 89a2444c1df2..59e417ec3e13 100644
--- a/tools/thermal/tmon/Makefile
+++ b/tools/thermal/tmon/Makefile
@@ -6,7 +6,7 @@ VERSION = 1.0
BINDIR=usr/bin
WARNFLAGS=-Wall -Wshadow -W -Wformat -Wimplicit-function-declaration -Wimplicit-int
-override CFLAGS+= -O1 ${WARNFLAGS}
+override CFLAGS+= $(call cc-option,-O3,-O1) ${WARNFLAGS}
# Add "-fstack-protector" only if toolchain supports it.
override CFLAGS+= $(call cc-option,-fstack-protector-strong)
CC?= $(CROSS_COMPILE)gcc
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] tools iio: Override CFLAGS assignments
2019-01-03 16:13 [PATCHv3 0/2] tools: Various build flags fixes Jiri Olsa
2019-01-03 16:13 ` [PATCH 1/2] tools thermal tmon: Use -O3 instead of -O1 if available Jiri Olsa
@ 2019-01-03 16:13 ` Jiri Olsa
2019-01-08 15:39 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Olsa @ 2019-01-03 16:13 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Andy Shevchenko, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, lkml, Ingo Molnar, Namhyung Kim,
Alexander Shishkin, Peter Zijlstra
So user could specify outside CFLAGS values.
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/iio/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/iio/Makefile b/tools/iio/Makefile
index 332ed2f6c2c2..e22378dba244 100644
--- a/tools/iio/Makefile
+++ b/tools/iio/Makefile
@@ -12,7 +12,7 @@ endif
# (this improves performance and avoids hard-to-debug behaviour);
MAKEFLAGS += -r
-CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
+override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
ALL_TARGETS := iio_event_monitor lsiio iio_generic_buffer
ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))
--
2.17.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [tip:perf/urgent] tools iio: Override CFLAGS assignments
2019-01-03 16:13 ` [PATCH 2/2] tools iio: Override CFLAGS assignments Jiri Olsa
@ 2019-01-08 15:39 ` tip-bot for Jiri Olsa
0 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Jiri Olsa @ 2019-01-08 15:39 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, tglx, andriy.shevchenko, acme, linux-kernel, jic23,
peterz, hpa, jolsa, namhyung, lars, knaack.h, alexander.shishkin
Commit-ID: 536cdb684d2d5139708d290b9dc124b1420886c1
Gitweb: https://git.kernel.org/tip/536cdb684d2d5139708d290b9dc124b1420886c1
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Thu, 3 Jan 2019 17:13:50 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 4 Jan 2019 12:54:49 -0300
tools iio: Override CFLAGS assignments
So user could specify outside CFLAGS values.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20190103161350.11446-3-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/iio/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/iio/Makefile b/tools/iio/Makefile
index 332ed2f6c2c2..e22378dba244 100644
--- a/tools/iio/Makefile
+++ b/tools/iio/Makefile
@@ -12,7 +12,7 @@ endif
# (this improves performance and avoids hard-to-debug behaviour);
MAKEFLAGS += -r
-CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
+override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
ALL_TARGETS := iio_event_monitor lsiio iio_generic_buffer
ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-08 15:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-03 16:13 [PATCHv3 0/2] tools: Various build flags fixes Jiri Olsa
2019-01-03 16:13 ` [PATCH 1/2] tools thermal tmon: Use -O3 instead of -O1 if available Jiri Olsa
2019-01-08 15:39 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2019-01-03 16:13 ` [PATCH 2/2] tools iio: Override CFLAGS assignments Jiri Olsa
2019-01-08 15:39 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).