* [PATCH 0/2] arm64: dts: qcom: sdm845: add support for ADSP PIL
@ 2018-12-20 13:39 Rohit kumar
2018-12-20 13:39 ` [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes Rohit kumar
2018-12-20 13:39 ` [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node Rohit kumar
0 siblings, 2 replies; 8+ messages in thread
From: Rohit kumar @ 2018-12-20 13:39 UTC (permalink / raw)
To: dianders, andy.gross, david.brown, robh+dt, mark.rutland,
linux-arm-msm, devicetree, linux-kernel, plai, bgoswami,
srinivas.kandagatla, linux-remoteproc, bjorn.andersson
Cc: Rohit kumar
add remoteproc and child device nodes for adsp pil for sdm845.
This depends on below upstream patches:
1) lpasscc dt node : https://lore.kernel.org/patchwork/patch/1021267/
2) pdc sync reset dt node : https://lore.kernel.org/patchwork/patch/1003795/
3) dt-binding: Remove lpass_aon clock from adsp clk list: https://lore.kernel.org/patchwork/patch/1019609/
Rohit kumar (2):
arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes
arm64: dts: qcom: sdm845: Add Q6V5 ADSP node
arch/arm64/boot/dts/qcom/sdm845.dtsi | 101 ++++++++++++++++++++++++++++++++++-
1 file changed, 100 insertions(+), 1 deletion(-)
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes
2018-12-20 13:39 [PATCH 0/2] arm64: dts: qcom: sdm845: add support for ADSP PIL Rohit kumar
@ 2018-12-20 13:39 ` Rohit kumar
2019-01-03 23:42 ` Bjorn Andersson
2018-12-20 13:39 ` [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node Rohit kumar
1 sibling, 1 reply; 8+ messages in thread
From: Rohit kumar @ 2018-12-20 13:39 UTC (permalink / raw)
To: dianders, andy.gross, david.brown, robh+dt, mark.rutland,
linux-arm-msm, devicetree, linux-kernel, plai, bgoswami,
srinivas.kandagatla, linux-remoteproc, bjorn.andersson
Cc: Rohit kumar
Add memory nodes required for remoteproc q6v5_adsp pil.
Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 23a253b..c0a012f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -88,6 +88,11 @@
reg = <0 0x86200000 0 0x2d00000>;
no-map;
};
+
+ pil_adsp_mem: memory@8b100000 {
+ reg = <0 0x8b100000 0 0x1a00000>;
+ no-map;
+ };
};
cpus {
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node
2018-12-20 13:39 [PATCH 0/2] arm64: dts: qcom: sdm845: add support for ADSP PIL Rohit kumar
2018-12-20 13:39 ` [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes Rohit kumar
@ 2018-12-20 13:39 ` Rohit kumar
2018-12-22 11:34 ` kbuild test robot
2019-01-03 23:50 ` Bjorn Andersson
1 sibling, 2 replies; 8+ messages in thread
From: Rohit kumar @ 2018-12-20 13:39 UTC (permalink / raw)
To: dianders, andy.gross, david.brown, robh+dt, mark.rutland,
linux-arm-msm, devicetree, linux-kernel, plai, bgoswami,
srinivas.kandagatla, linux-remoteproc, bjorn.andersson
Cc: Rohit kumar
This patch adds Q6V5 ADSP remoteproc node for SDM845 SoCs.
Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 96 +++++++++++++++++++++++++++++++++++-
1 file changed, 95 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index c0a012f..dfeb3cf 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -13,6 +13,9 @@
#include <dt-bindings/reset/qcom,sdm845-aoss.h>
#include <dt-bindings/soc/qcom,rpmh-rsc.h>
#include <dt-bindings/clock/qcom,gcc-sdm845.h>
+#include <dt-bindings/soc/qcom,apr.h>
+#include <dt-bindings/sound/qcom,q6afe.h>
+#include <dt-bindings/sound/qcom,q6asm.h>
/ {
interrupt-parent = <&intc>;
@@ -1691,7 +1694,98 @@
status = "disabled";
};
};
- };
+
+ adsp_pil: remoteproc@17300000 {
+ compatible = "qcom,sdm845-adsp-pil";
+
+ reg = <0x17300000 0x410>;
+ reg-names = "qdsp6ss";
+
+ interrupts-extended = <&intc 0 162 IRQ_TYPE_EDGE_RISING>,
+ <&adsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
+ <&adsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
+ <&adsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
+ <&adsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "wdog", "fatal", "ready",
+ "handover", "stop-ack";
+
+ clocks = <&rpmhcc RPMH_CXO_CLK>,
+ <&gcc GCC_LPASS_SWAY_CLK>,
+ <&lpasscc LPASS_Q6SS_AHBS_AON_CLK>,
+ <&lpasscc LPASS_Q6SS_AHBM_AON_CLK>,
+ <&lpasscc LPASS_QDSP6SS_XO_CLK>,
+ <&lpasscc LPASS_QDSP6SS_SLEEP_CLK>,
+ <&lpasscc LPASS_QDSP6SS_CORE_CLK>;
+
+ clock-names = "xo", "sway_cbcr", "lpass_ahbs_aon_cbcr",
+ "lpass_ahbm_aon_cbcr", "qdsp6ss_xo",
+ "qdsp6ss_sleep", "qdsp6ss_core";
+
+ resets = <&pdc_reset PDC_AUDIO_SYNC_RESET>,
+ <&aoss_reset AOSS_CC_LPASS_RESTART>;
+ reset-names = "pdc_sync", "cc_lpass";
+
+ qcom,halt-regs = <&tcsr_mutex_regs 0x22000>;
+
+ memory-region = <&pil_adsp_mem>;
+
+ qcom,smem-states = <&adsp_smp2p_out 0>;
+ qcom,smem-state-names = "stop";
+
+ glink-edge {
+ compatible = "qcom,glink-smem";
+ interrupts = <0 156 IRQ_TYPE_EDGE_RISING>;
+
+ label = "lpass";
+ qcom,remote-pid = <2>;
+ mboxes = <&apss_shared 8>;
+ mbox-names = "adsp_smem";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ apr@4 {
+ compatible = "qcom,apr-v2";
+ qcom,glink-channels = "apr_audio_svc";
+ reg = <APR_DOMAIN_ADSP>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ q6core {
+ compatible = "qcom,q6core";
+ reg = <APR_SVC_ADSP_CORE>;
+ };
+
+ q6afe {
+ compatible = "qcom,q6afe";
+ reg = <APR_SVC_AFE>;
+ q6afedai: afedais {
+ compatible = "qcom,q6afe-dais";
+ #sound-dai-cells = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
+ q6asm {
+ compatible = "qcom,q6asm";
+ reg = <APR_SVC_ASM>;
+ q6asmdai: asmdai{
+ compatible = "qcom,q6asm-dais";
+ iommus = <&apps_smmu 0x1821 0x0>;
+ #sound-dai-cells = <1>;
+ };
+ };
+
+ q6adm {
+ compatible = "qcom,q6adm";
+ reg = <APR_SVC_ADM>;
+ q6routing: routing {
+ compatible = "qcom,q6adm-routing";
+ #sound-dai-cells = <0>;
+ };
+ };
+ };
+ };
+ status = "disabled";
+ };
thermal-zones {
cpu0-thermal {
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node
2018-12-20 13:39 ` [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node Rohit kumar
@ 2018-12-22 11:34 ` kbuild test robot
2019-01-03 23:50 ` Bjorn Andersson
1 sibling, 0 replies; 8+ messages in thread
From: kbuild test robot @ 2018-12-22 11:34 UTC (permalink / raw)
To: Rohit kumar
Cc: kbuild-all, dianders, andy.gross, david.brown, robh+dt,
mark.rutland, linux-arm-msm, devicetree, linux-kernel, plai,
bgoswami, srinivas.kandagatla, linux-remoteproc, bjorn.andersson,
Rohit kumar
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
Hi Rohit,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on agross/for-next]
[also build test ERROR on next-20181221]
[cannot apply to v4.20-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Rohit-kumar/arm64-dts-qcom-sdm845-add-support-for-ADSP-PIL/20181221-084458
base: https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git for-next
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm64
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/qcom/sdm845.dtsi:1708.12-13 syntax error
>> FATAL ERROR: Unable to parse input tree
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61733 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes
2018-12-20 13:39 ` [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes Rohit kumar
@ 2019-01-03 23:42 ` Bjorn Andersson
2019-01-07 7:47 ` Rohit Kumar
0 siblings, 1 reply; 8+ messages in thread
From: Bjorn Andersson @ 2019-01-03 23:42 UTC (permalink / raw)
To: Rohit kumar
Cc: dianders, andy.gross, david.brown, robh+dt, mark.rutland,
linux-arm-msm, devicetree, linux-kernel, plai, bgoswami,
srinivas.kandagatla, linux-remoteproc
On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:
> Add memory nodes required for remoteproc q6v5_adsp pil.
>
This range doesn't match the documented memory map. I would prefer to
see a "Specify all PIL regions as defined in V10" or similar.
Regards,
Bjorn
> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 23a253b..c0a012f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -88,6 +88,11 @@
> reg = <0 0x86200000 0 0x2d00000>;
> no-map;
> };
> +
> + pil_adsp_mem: memory@8b100000 {
> + reg = <0 0x8b100000 0 0x1a00000>;
> + no-map;
> + };
> };
>
> cpus {
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node
2018-12-20 13:39 ` [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node Rohit kumar
2018-12-22 11:34 ` kbuild test robot
@ 2019-01-03 23:50 ` Bjorn Andersson
2019-01-08 12:34 ` Rohit Kumar
1 sibling, 1 reply; 8+ messages in thread
From: Bjorn Andersson @ 2019-01-03 23:50 UTC (permalink / raw)
To: Rohit kumar
Cc: dianders, andy.gross, david.brown, robh+dt, mark.rutland,
linux-arm-msm, devicetree, linux-kernel, plai, bgoswami,
srinivas.kandagatla, linux-remoteproc
On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:
> This patch adds Q6V5 ADSP remoteproc node for SDM845 SoCs.
>
Thanks Rohit, nice to see these things on the list!
> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 96 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 95 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index c0a012f..dfeb3cf 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -13,6 +13,9 @@
> #include <dt-bindings/reset/qcom,sdm845-aoss.h>
> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
> #include <dt-bindings/clock/qcom,gcc-sdm845.h>
> +#include <dt-bindings/soc/qcom,apr.h>
> +#include <dt-bindings/sound/qcom,q6afe.h>
> +#include <dt-bindings/sound/qcom,q6asm.h>
>
> / {
> interrupt-parent = <&intc>;
> @@ -1691,7 +1694,98 @@
> status = "disabled";
> };
> };
> - };
> +
> + adsp_pil: remoteproc@17300000 {
Please sort nodes by address, then name.
> + compatible = "qcom,sdm845-adsp-pil";
> +
> + reg = <0x17300000 0x410>;
> + reg-names = "qdsp6ss";
reg-names was dropped from the binding (iirc), please omit it here.
> +
> + interrupts-extended = <&intc 0 162 IRQ_TYPE_EDGE_RISING>,
s/0/GIC_SPI/
> + <&adsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> + <&adsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> + <&adsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> + <&adsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "wdog", "fatal", "ready",
> + "handover", "stop-ack";
> +
> + clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&gcc GCC_LPASS_SWAY_CLK>,
> + <&lpasscc LPASS_Q6SS_AHBS_AON_CLK>,
> + <&lpasscc LPASS_Q6SS_AHBM_AON_CLK>,
> + <&lpasscc LPASS_QDSP6SS_XO_CLK>,
> + <&lpasscc LPASS_QDSP6SS_SLEEP_CLK>,
> + <&lpasscc LPASS_QDSP6SS_CORE_CLK>;
> +
> + clock-names = "xo", "sway_cbcr", "lpass_ahbs_aon_cbcr",
> + "lpass_ahbm_aon_cbcr", "qdsp6ss_xo",
> + "qdsp6ss_sleep", "qdsp6ss_core";
> +
> + resets = <&pdc_reset PDC_AUDIO_SYNC_RESET>,
> + <&aoss_reset AOSS_CC_LPASS_RESTART>;
> + reset-names = "pdc_sync", "cc_lpass";
> +
> + qcom,halt-regs = <&tcsr_mutex_regs 0x22000>;
> +
> + memory-region = <&pil_adsp_mem>;
> +
> + qcom,smem-states = <&adsp_smp2p_out 0>;
> + qcom,smem-state-names = "stop";
> +
> + glink-edge {
So we will end up duplicating these between the PAS based and non-PAS
based remoteprocs. I don't have a better idea right now, but this
deserves some thought.
> + compatible = "qcom,glink-smem";
> + interrupts = <0 156 IRQ_TYPE_EDGE_RISING>;
s/0/GIC_SPI/
> +
> + label = "lpass";
> + qcom,remote-pid = <2>;
> + mboxes = <&apss_shared 8>;
> + mbox-names = "adsp_smem";
mbox-names is not a documented property, please omit it.
> + #address-cells = <1>;
> + #size-cells = <0>;
> + apr@4 {
> + compatible = "qcom,apr-v2";
> + qcom,glink-channels = "apr_audio_svc";
> + reg = <APR_DOMAIN_ADSP>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + q6core {
> + compatible = "qcom,q6core";
> + reg = <APR_SVC_ADSP_CORE>;
> + };
> +
> + q6afe {
> + compatible = "qcom,q6afe";
> + reg = <APR_SVC_AFE>;
> + q6afedai: afedais {
> + compatible = "qcom,q6afe-dais";
> + #sound-dai-cells = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> +
> + q6asm {
> + compatible = "qcom,q6asm";
> + reg = <APR_SVC_ASM>;
> + q6asmdai: asmdai{
> + compatible = "qcom,q6asm-dais";
> + iommus = <&apps_smmu 0x1821 0x0>;
> + #sound-dai-cells = <1>;
> + };
> + };
> +
> + q6adm {
> + compatible = "qcom,q6adm";
> + reg = <APR_SVC_ADM>;
> + q6routing: routing {
> + compatible = "qcom,q6adm-routing";
> + #sound-dai-cells = <0>;
> + };
> + };
> + };
> + };
> + status = "disabled";
Properties must come before subnodes.
> + };
Regards,
Bjorn
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes
2019-01-03 23:42 ` Bjorn Andersson
@ 2019-01-07 7:47 ` Rohit Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Rohit Kumar @ 2019-01-07 7:47 UTC (permalink / raw)
To: Bjorn Andersson, Sibi Sankar
Cc: dianders, andy.gross, david.brown, robh+dt, mark.rutland,
linux-arm-msm, devicetree, linux-kernel, plai, bgoswami,
srinivas.kandagatla, linux-remoteproc
Thanks Bjorn for review.
On 1/4/2019 5:12 AM, Bjorn Andersson wrote:
> On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:
>
>> Add memory nodes required for remoteproc q6v5_adsp pil.
>>
> This range doesn't match the documented memory map. I would prefer to
> see a "Specify all PIL regions as defined in V10" or similar.
Yes, Sibi will post it along with other PIL regions with update address
in next spin.
>
> Regards,
> Bjorn
>
>> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index 23a253b..c0a012f 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -88,6 +88,11 @@
>> reg = <0 0x86200000 0 0x2d00000>;
>> no-map;
>> };
>> +
>> + pil_adsp_mem: memory@8b100000 {
>> + reg = <0 0x8b100000 0 0x1a00000>;
>> + no-map;
>> + };
>> };
>>
>> cpus {
>> --
>> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
>> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>>
Regards,
Rohit
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node
2019-01-03 23:50 ` Bjorn Andersson
@ 2019-01-08 12:34 ` Rohit Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Rohit Kumar @ 2019-01-08 12:34 UTC (permalink / raw)
To: Bjorn Andersson
Cc: dianders, andy.gross, david.brown, robh+dt, mark.rutland,
linux-arm-msm, devicetree, linux-kernel, plai, bgoswami,
srinivas.kandagatla, linux-remoteproc
Thanks Bjorn for review.
On 1/4/2019 5:20 AM, Bjorn Andersson wrote:
> On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:
>
>> This patch adds Q6V5 ADSP remoteproc node for SDM845 SoCs.
>>
> Thanks Rohit, nice to see these things on the list!
>
>> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 96 +++++++++++++++++++++++++++++++++++-
>> 1 file changed, 95 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index c0a012f..dfeb3cf 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -13,6 +13,9 @@
>> #include <dt-bindings/reset/qcom,sdm845-aoss.h>
>> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> #include <dt-bindings/clock/qcom,gcc-sdm845.h>
>> +#include <dt-bindings/soc/qcom,apr.h>
>> +#include <dt-bindings/sound/qcom,q6afe.h>
>> +#include <dt-bindings/sound/qcom,q6asm.h>
>>
>> / {
>> interrupt-parent = <&intc>;
>> @@ -1691,7 +1694,98 @@
>> status = "disabled";
>> };
>> };
>> - };
>> +
>> + adsp_pil: remoteproc@17300000 {
> Please sort nodes by address, then name.
Sure.
>
>> + compatible = "qcom,sdm845-adsp-pil";
>> +
>> + reg = <0x17300000 0x410>;
>> + reg-names = "qdsp6ss";
> reg-names was dropped from the binding (iirc), please omit it here.
Yup. Will remove it in next spin.
>
>> +
>> + interrupts-extended = <&intc 0 162 IRQ_TYPE_EDGE_RISING>,
> s/0/GIC_SPI/
okay.
>
>> + <&adsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
>> + <&adsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
>> + <&adsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
>> + <&adsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>;
>> + interrupt-names = "wdog", "fatal", "ready",
>> + "handover", "stop-ack";
>> +
>> + clocks = <&rpmhcc RPMH_CXO_CLK>,
>> + <&gcc GCC_LPASS_SWAY_CLK>,
>> + <&lpasscc LPASS_Q6SS_AHBS_AON_CLK>,
>> + <&lpasscc LPASS_Q6SS_AHBM_AON_CLK>,
>> + <&lpasscc LPASS_QDSP6SS_XO_CLK>,
>> + <&lpasscc LPASS_QDSP6SS_SLEEP_CLK>,
>> + <&lpasscc LPASS_QDSP6SS_CORE_CLK>;
>> +
>> + clock-names = "xo", "sway_cbcr", "lpass_ahbs_aon_cbcr",
>> + "lpass_ahbm_aon_cbcr", "qdsp6ss_xo",
>> + "qdsp6ss_sleep", "qdsp6ss_core";
>> +
>> + resets = <&pdc_reset PDC_AUDIO_SYNC_RESET>,
>> + <&aoss_reset AOSS_CC_LPASS_RESTART>;
>> + reset-names = "pdc_sync", "cc_lpass";
>> +
>> + qcom,halt-regs = <&tcsr_mutex_regs 0x22000>;
>> +
>> + memory-region = <&pil_adsp_mem>;
>> +
>> + qcom,smem-states = <&adsp_smp2p_out 0>;
>> + qcom,smem-state-names = "stop";
>> +
>> + glink-edge {
> So we will end up duplicating these between the PAS based and non-PAS
> based remoteprocs. I don't have a better idea right now, but this
> deserves some thought.
Yup. Will try to think if we can have some common node for glink-edge.
>> + compatible = "qcom,glink-smem";
>> + interrupts = <0 156 IRQ_TYPE_EDGE_RISING>;
> s/0/GIC_SPI/
sure
>
>> +
>> + label = "lpass";
>> + qcom,remote-pid = <2>;
>> + mboxes = <&apss_shared 8>;
>> + mbox-names = "adsp_smem";
> mbox-names is not a documented property, please omit it.
okay
>
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + apr@4 {
>> + compatible = "qcom,apr-v2";
>> + qcom,glink-channels = "apr_audio_svc";
>> + reg = <APR_DOMAIN_ADSP>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + q6core {
>> + compatible = "qcom,q6core";
>> + reg = <APR_SVC_ADSP_CORE>;
>> + };
>> +
>> + q6afe {
>> + compatible = "qcom,q6afe";
>> + reg = <APR_SVC_AFE>;
>> + q6afedai: afedais {
>> + compatible = "qcom,q6afe-dais";
>> + #sound-dai-cells = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + };
>> + };
>> +
>> + q6asm {
>> + compatible = "qcom,q6asm";
>> + reg = <APR_SVC_ASM>;
>> + q6asmdai: asmdai{
>> + compatible = "qcom,q6asm-dais";
>> + iommus = <&apps_smmu 0x1821 0x0>;
>> + #sound-dai-cells = <1>;
>> + };
>> + };
>> +
>> + q6adm {
>> + compatible = "qcom,q6adm";
>> + reg = <APR_SVC_ADM>;
>> + q6routing: routing {
>> + compatible = "qcom,q6adm-routing";
>> + #sound-dai-cells = <0>;
>> + };
>> + };
>> + };
>> + };
>> + status = "disabled";
> Properties must come before subnodes.
Yup, right. Will update in next spin.
>
>> + };
> Regards,
> Bjorn
Thanks,
Rohit
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-01-08 12:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20 13:39 [PATCH 0/2] arm64: dts: qcom: sdm845: add support for ADSP PIL Rohit kumar
2018-12-20 13:39 ` [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes Rohit kumar
2019-01-03 23:42 ` Bjorn Andersson
2019-01-07 7:47 ` Rohit Kumar
2018-12-20 13:39 ` [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node Rohit kumar
2018-12-22 11:34 ` kbuild test robot
2019-01-03 23:50 ` Bjorn Andersson
2019-01-08 12:34 ` Rohit Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).