* [PATCH] dmaengine: st_fdma: use struct_size() in kzalloc()
@ 2019-01-04 18:43 Gustavo A. R. Silva
2019-01-07 8:50 ` Patrice CHOTARD
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-04 18:43 UTC (permalink / raw)
To: Patrice Chotard, Vinod Koul, Dan Williams
Cc: linux-arm-kernel, dmaengine, linux-kernel, Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};
instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:
instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/dma/st_fdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
index 07c20aa2e955..df6b73028ecb 100644
--- a/drivers/dma/st_fdma.c
+++ b/drivers/dma/st_fdma.c
@@ -243,8 +243,7 @@ static struct st_fdma_desc *st_fdma_alloc_desc(struct st_fdma_chan *fchan,
struct st_fdma_desc *fdesc;
int i;
- fdesc = kzalloc(sizeof(*fdesc) +
- sizeof(struct st_fdma_sw_node) * sg_len, GFP_NOWAIT);
+ fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT);
if (!fdesc)
return NULL;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: st_fdma: use struct_size() in kzalloc()
2019-01-04 18:43 [PATCH] dmaengine: st_fdma: use struct_size() in kzalloc() Gustavo A. R. Silva
@ 2019-01-07 8:50 ` Patrice CHOTARD
2019-01-09 17:43 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Patrice CHOTARD @ 2019-01-07 8:50 UTC (permalink / raw)
To: Gustavo A. R. Silva, Vinod Koul, Dan Williams
Cc: linux-arm-kernel, dmaengine, linux-kernel
Hi Gustavo
On 1/4/19 7:43 PM, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding the
> size of a structure that has a zero-sized array at the end, along with memory
> for some number of elements for that array. For example:
>
> struct foo {
> int stuff;
> void *entry[];
> };
>
> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
>
> Instead of leaving these open-coded and prone to type mistakes, we can now
> use the new struct_size() helper:
>
> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/dma/st_fdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
> index 07c20aa2e955..df6b73028ecb 100644
> --- a/drivers/dma/st_fdma.c
> +++ b/drivers/dma/st_fdma.c
> @@ -243,8 +243,7 @@ static struct st_fdma_desc *st_fdma_alloc_desc(struct st_fdma_chan *fchan,
> struct st_fdma_desc *fdesc;
> int i;
>
> - fdesc = kzalloc(sizeof(*fdesc) +
> - sizeof(struct st_fdma_sw_node) * sg_len, GFP_NOWAIT);
> + fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT);
> if (!fdesc)
> return NULL;
>
>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: st_fdma: use struct_size() in kzalloc()
2019-01-07 8:50 ` Patrice CHOTARD
@ 2019-01-09 17:43 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-09 17:43 UTC (permalink / raw)
To: Patrice CHOTARD, Vinod Koul, Dan Williams
Cc: linux-arm-kernel, dmaengine, linux-kernel
On 1/7/19 2:50 AM, Patrice CHOTARD wrote:
> Hi Gustavo
>
> On 1/4/19 7:43 PM, Gustavo A. R. Silva wrote:
>> One of the more common cases of allocation size calculations is finding the
>> size of a structure that has a zero-sized array at the end, along with memory
>> for some number of elements for that array. For example:
>>
[..]
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/dma/st_fdma.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
>> index 07c20aa2e955..df6b73028ecb 100644
>> --- a/drivers/dma/st_fdma.c
>> +++ b/drivers/dma/st_fdma.c
>> @@ -243,8 +243,7 @@ static struct st_fdma_desc *st_fdma_alloc_desc(struct st_fdma_chan *fchan,
>> struct st_fdma_desc *fdesc;
>> int i;
>>
>> - fdesc = kzalloc(sizeof(*fdesc) +
>> - sizeof(struct st_fdma_sw_node) * sg_len, GFP_NOWAIT);
>> + fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT);
>> if (!fdesc)
>> return NULL;
>>
>>
>
>
> Acked-by: Patrice Chotard <patrice.chotard@st.com>
>
Thanks, Patrice.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-09 17:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 18:43 [PATCH] dmaengine: st_fdma: use struct_size() in kzalloc() Gustavo A. R. Silva
2019-01-07 8:50 ` Patrice CHOTARD
2019-01-09 17:43 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).