* [PATCH] [v2] ALSA: ice1712: fix a missing check of snd_i2c_sendbytes
@ 2019-01-06 16:31 Aditya Pakki
2019-01-07 10:58 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2019-01-06 16:31 UTC (permalink / raw)
To: pakki001; +Cc: kjlu, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
snd_i2c_sendbytes could fail. The fix checks its return value: if it
fails, issues an error message and returns with its error code.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
sound/pci/ice1712/ews.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/sound/pci/ice1712/ews.c b/sound/pci/ice1712/ews.c
index b8af747ecb43..7646c93e8268 100644
--- a/sound/pci/ice1712/ews.c
+++ b/sound/pci/ice1712/ews.c
@@ -826,7 +826,12 @@ static int snd_ice1712_6fire_read_pca(struct snd_ice1712 *ice, unsigned char reg
snd_i2c_lock(ice->i2c);
byte = reg;
- snd_i2c_sendbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1);
+ if (snd_i2c_sendbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1)) {
+ snd_i2c_unlock(ice->i2c);
+ dev_err(ice->card->dev, "cannot send pca\n");
+ return -EIO;
+ }
+
byte = 0;
if (snd_i2c_readbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1) != 1) {
snd_i2c_unlock(ice->i2c);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [v2] ALSA: ice1712: fix a missing check of snd_i2c_sendbytes
2019-01-06 16:31 [PATCH] [v2] ALSA: ice1712: fix a missing check of snd_i2c_sendbytes Aditya Pakki
@ 2019-01-07 10:58 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-01-07 10:58 UTC (permalink / raw)
To: Aditya Pakki; +Cc: alsa-devel, Jaroslav Kysela, kjlu, linux-kernel
On Sun, 06 Jan 2019 17:31:44 +0100,
Aditya Pakki wrote:
>
> snd_i2c_sendbytes could fail. The fix checks its return value: if it
> fails, issues an error message and returns with its error code.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-07 10:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-06 16:31 [PATCH] [v2] ALSA: ice1712: fix a missing check of snd_i2c_sendbytes Aditya Pakki
2019-01-07 10:58 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).