* [PATCH] dio: Fix buffer overflow in case of unknown board
@ 2019-01-08 14:06 Geert Uytterhoeven
2019-01-08 14:19 ` Andreas Schwab
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-01-08 14:06 UTC (permalink / raw)
To: Kars de Jong; +Cc: Arnd Bergmann, linux-m68k, linux-kernel, Geert Uytterhoeven
With gcc 8.2.0:
drivers/dio/dio.c: In function ‘dio_init’:
drivers/dio/dio.c:240:17: warning: ‘strcpy’ writing 69 or more bytes into a region of size 64 overflows the destination [-Wstringop-overflow=]
strcpy(dev->name,dio_getname(dev->id));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Indeed, if an unknown board is present, the target buffer will overflow.
Shorten the unknown board name string to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/dio/dio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index 92e78d16b476550c..4ff65c690b04b50b 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -90,7 +90,7 @@ static struct dioname names[] =
#undef DIOFBNAME
static const char *unknowndioname
- = "unknown DIO board -- please email <linux-m68k@lists.linux-m68k.org>!";
+ = "unknown DIO board, please email linux-m68k@lists.linux-m68k.org";
static const char *dio_getname(int id)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dio: Fix buffer overflow in case of unknown board
2019-01-08 14:06 [PATCH] dio: Fix buffer overflow in case of unknown board Geert Uytterhoeven
@ 2019-01-08 14:19 ` Andreas Schwab
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Schwab @ 2019-01-08 14:19 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Kars de Jong, Arnd Bergmann, linux-m68k, linux-kernel
On Jan 08 2019, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> @@ -90,7 +90,7 @@ static struct dioname names[] =
> #undef DIOFBNAME
>
> static const char *unknowndioname
> - = "unknown DIO board -- please email <linux-m68k@lists.linux-m68k.org>!";
> + = "unknown DIO board, please email linux-m68k@lists.linux-m68k.org";
This could be declared as an array.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-08 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 14:06 [PATCH] dio: Fix buffer overflow in case of unknown board Geert Uytterhoeven
2019-01-08 14:19 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).