linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/usb/storage: Remove duplicate headers
@ 2019-01-10  7:10 Sabyasachi Gupta
  2019-01-11  9:10 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Sabyasachi Gupta @ 2019-01-10  7:10 UTC (permalink / raw)
  To: stern, gregkh
  Cc: jrdr.linux, linux-usb, usb-storage, linux-kernel, brajeswar.linux

Remove duplicate headers which are included more than once.

Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
---
 drivers/usb/storage/datafab.c    | 1 -
 drivers/usb/storage/ene_ub6250.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c
index 09353be..4b1bd56 100644
--- a/drivers/usb/storage/datafab.c
+++ b/drivers/usb/storage/datafab.c
@@ -102,7 +102,6 @@ MODULE_DEVICE_TABLE(usb, datafab_usb_ids);
 }
 
 static struct us_unusual_dev datafab_unusual_dev_list[] = {
-#	include "unusual_datafab.h"
 	{ }		/* Terminating entry */
 };
 
diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 4d261e4..79a07bf 100644
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -65,7 +65,6 @@ MODULE_DEVICE_TABLE(usb, ene_ub6250_usb_ids);
 }
 
 static struct us_unusual_dev ene_ub6250_unusual_dev_list[] = {
-#	include "unusual_ene_ub6250.h"
 	{ }		/* Terminating entry */
 };
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/usb/storage: Remove duplicate headers
  2019-01-10  7:10 [PATCH] drivers/usb/storage: Remove duplicate headers Sabyasachi Gupta
@ 2019-01-11  9:10 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-01-11  9:10 UTC (permalink / raw)
  To: Sabyasachi Gupta
  Cc: stern, jrdr.linux, linux-usb, usb-storage, linux-kernel, brajeswar.linux

On Thu, Jan 10, 2019 at 12:40:07PM +0530, Sabyasachi Gupta wrote:
> Remove duplicate headers which are included more than once.
> 
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
>  drivers/usb/storage/datafab.c    | 1 -
>  drivers/usb/storage/ene_ub6250.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c
> index 09353be..4b1bd56 100644
> --- a/drivers/usb/storage/datafab.c
> +++ b/drivers/usb/storage/datafab.c
> @@ -102,7 +102,6 @@ MODULE_DEVICE_TABLE(usb, datafab_usb_ids);
>  }
>  
>  static struct us_unusual_dev datafab_unusual_dev_list[] = {
> -#	include "unusual_datafab.h"
>  	{ }		/* Terminating entry */
>  };

Nope, this breaks things :(

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-11  9:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10  7:10 [PATCH] drivers/usb/storage: Remove duplicate headers Sabyasachi Gupta
2019-01-11  9:10 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).