* [PATCH 0/9] Use vm_insert_range and vm_insert_range_buggy
@ 2019-01-11 15:05 Souptick Joarder
2019-01-17 11:39 ` Souptick Joarder
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2019-01-11 15:05 UTC (permalink / raw)
To: akpm, willy, mhocko, kirill.shutemov, vbabka, riel, sfr, rppt,
peterz, linux, robin.murphy, iamjoonsoo.kim, treding, keescook,
m.szyprowski, stefanr, hjc, heiko, airlied,
oleksandr_andrushchenko, joro, pawel, kyungmin.park, mchehab,
boris.ostrovsky, jgross
Cc: linux-kernel, linux-mm, linux-arm-kernel, linux1394-devel,
dri-devel, linux-rockchip, xen-devel, iommu, linux-media
Previouly drivers have their own way of mapping range of
kernel pages/memory into user vma and this was done by
invoking vm_insert_page() within a loop.
As this pattern is common across different drivers, it can
be generalized by creating new functions and use it across
the drivers.
vm_insert_range() is the API which could be used to mapped
kernel memory/pages in drivers which has considered vm_pgoff
vm_insert_range_buggy() is the API which could be used to map
range of kernel memory/pages in drivers which has not considered
vm_pgoff. vm_pgoff is passed default as 0 for those drivers.
We _could_ then at a later "fix" these drivers which are using
vm_insert_range_buggy() to behave according to the normal vm_pgoff
offsetting simply by removing the _buggy suffix on the function
name and if that causes regressions, it gives us an easy way to revert.
There is an existing bug in [7/9], where user passed length is not
verified against object_count. For any value of length > object_count
it will end up overrun page array which could lead to a potential bug.
This is fixed as part of these conversion.
Souptick Joarder (9):
mm: Introduce new vm_insert_range and vm_insert_range_buggy API
arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range
drivers/firewire/core-iso.c: Convert to use vm_insert_range_buggy
drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range
drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range
iommu/dma-iommu.c: Convert to use vm_insert_range
videobuf2/videobuf2-dma-sg.c: Convert to use vm_insert_range_buggy
xen/gntdev.c: Convert to use vm_insert_range
xen/privcmd-buf.c: Convert to use vm_insert_range_buggy
arch/arm/mm/dma-mapping.c | 22 ++----
drivers/firewire/core-iso.c | 15 +----
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 +----
drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 ++---
drivers/iommu/dma-iommu.c | 12 +---
drivers/media/common/videobuf2/videobuf2-dma-sg.c | 22 ++----
drivers/xen/gntdev.c | 16 ++---
drivers/xen/privcmd-buf.c | 8 +--
include/linux/mm.h | 4 ++
mm/memory.c | 81 +++++++++++++++++++++++
mm/nommu.c | 14 ++++
11 files changed, 129 insertions(+), 100 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/9] Use vm_insert_range and vm_insert_range_buggy
2019-01-11 15:05 [PATCH 0/9] Use vm_insert_range and vm_insert_range_buggy Souptick Joarder
@ 2019-01-17 11:39 ` Souptick Joarder
0 siblings, 0 replies; 2+ messages in thread
From: Souptick Joarder @ 2019-01-17 11:39 UTC (permalink / raw)
To: Andrew Morton, Matthew Wilcox, Michal Hocko, Kirill A. Shutemov,
vbabka, Rik van Riel, Stephen Rothwell, rppt, Peter Zijlstra,
Russell King - ARM Linux, robin.murphy, iamjoonsoo.kim, treding,
Kees Cook, Marek Szyprowski, stefanr, hjc, Heiko Stuebner,
airlied, oleksandr_andrushchenko, joro, pawel, Kyungmin Park,
mchehab, Boris Ostrovsky, Juergen Gross
Cc: linux-kernel, Linux-MM, linux-arm-kernel, linux1394-devel,
dri-devel, linux-rockchip, xen-devel, iommu, linux-media
On Fri, Jan 11, 2019 at 8:31 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Previouly drivers have their own way of mapping range of
> kernel pages/memory into user vma and this was done by
> invoking vm_insert_page() within a loop.
>
> As this pattern is common across different drivers, it can
> be generalized by creating new functions and use it across
> the drivers.
>
> vm_insert_range() is the API which could be used to mapped
> kernel memory/pages in drivers which has considered vm_pgoff
>
> vm_insert_range_buggy() is the API which could be used to map
> range of kernel memory/pages in drivers which has not considered
> vm_pgoff. vm_pgoff is passed default as 0 for those drivers.
>
> We _could_ then at a later "fix" these drivers which are using
> vm_insert_range_buggy() to behave according to the normal vm_pgoff
> offsetting simply by removing the _buggy suffix on the function
> name and if that causes regressions, it gives us an easy way to revert.
>
> There is an existing bug in [7/9], where user passed length is not
> verified against object_count. For any value of length > object_count
> it will end up overrun page array which could lead to a potential bug.
> This is fixed as part of these conversion.
>
> Souptick Joarder (9):
> mm: Introduce new vm_insert_range and vm_insert_range_buggy API
> arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range
> drivers/firewire/core-iso.c: Convert to use vm_insert_range_buggy
> drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range
> drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range
> iommu/dma-iommu.c: Convert to use vm_insert_range
> videobuf2/videobuf2-dma-sg.c: Convert to use vm_insert_range_buggy
> xen/gntdev.c: Convert to use vm_insert_range
> xen/privcmd-buf.c: Convert to use vm_insert_range_buggy
Any further comment on these patches ?
>
> arch/arm/mm/dma-mapping.c | 22 ++----
> drivers/firewire/core-iso.c | 15 +----
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 +----
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 ++---
> drivers/iommu/dma-iommu.c | 12 +---
> drivers/media/common/videobuf2/videobuf2-dma-sg.c | 22 ++----
> drivers/xen/gntdev.c | 16 ++---
> drivers/xen/privcmd-buf.c | 8 +--
> include/linux/mm.h | 4 ++
> mm/memory.c | 81 +++++++++++++++++++++++
> mm/nommu.c | 14 ++++
> 11 files changed, 129 insertions(+), 100 deletions(-)
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-17 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 15:05 [PATCH 0/9] Use vm_insert_range and vm_insert_range_buggy Souptick Joarder
2019-01-17 11:39 ` Souptick Joarder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).