* [PATCH] drm/cirrus: fix connector leak at unload
@ 2019-01-11 14:02 Rob Clark
2019-01-11 22:06 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Rob Clark @ 2019-01-11 14:02 UTC (permalink / raw)
To: dri-devel
Cc: Rob Clark, Dave Airlie, Gerd Hoffmann, David Airlie,
Thierry Reding, Daniel Stone, Thomas Zimmermann, YueHaibing,
Rob Clark, virtualization, linux-kernel
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
Signed-off-by: Rob Clark <robdclark@gmail.com>
---
Similar case to the issue that was fixed recently in drm/ast
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
index 4dd499c7d1ba..bb379ec4c182 100644
--- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
+++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
@@ -256,6 +256,8 @@ static int cirrus_fbdev_destroy(struct drm_device *dev,
{
struct drm_framebuffer *gfb = gfbdev->gfb;
+ drm_crtc_force_disable_all(dev);
+
drm_fb_helper_unregister_fbi(&gfbdev->helper);
vfree(gfbdev->sysram);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/cirrus: fix connector leak at unload
2019-01-11 14:02 [PATCH] drm/cirrus: fix connector leak at unload Rob Clark
@ 2019-01-11 22:06 ` Daniel Vetter
2019-01-11 22:16 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2019-01-11 22:06 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, Rob Clark, Daniel Stone, David Airlie, YueHaibing,
linux-kernel, virtualization, Gerd Hoffmann, Thomas Zimmermann,
Dave Airlie, Thierry Reding
On Fri, Jan 11, 2019 at 09:02:34AM -0500, Rob Clark wrote:
> This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
> Similar case to the issue that was fixed recently in drm/ast
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
> index 4dd499c7d1ba..bb379ec4c182 100644
> --- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
> +++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
> @@ -256,6 +256,8 @@ static int cirrus_fbdev_destroy(struct drm_device *dev,
> {
> struct drm_framebuffer *gfb = gfbdev->gfb;
>
> + drm_crtc_force_disable_all(dev);
> +
> drm_fb_helper_unregister_fbi(&gfbdev->helper);
>
> vfree(gfbdev->sysram);
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/cirrus: fix connector leak at unload
2019-01-11 22:06 ` Daniel Vetter
@ 2019-01-11 22:16 ` Daniel Vetter
2019-01-14 7:38 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2019-01-11 22:16 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, Rob Clark, Daniel Stone, David Airlie, YueHaibing,
linux-kernel, virtualization, Gerd Hoffmann, Thomas Zimmermann,
Dave Airlie, Thierry Reding
On Fri, Jan 11, 2019 at 11:06:20PM +0100, Daniel Vetter wrote:
> On Fri, Jan 11, 2019 at 09:02:34AM -0500, Rob Clark wrote:
> > This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
> >
> > Signed-off-by: Rob Clark <robdclark@gmail.com>
> > ---
> > Similar case to the issue that was fixed recently in drm/ast
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Actually I just pushed a patch to drm-misc-next to rename this function to
drm_helper_force_disable_all(), so you need to respin ... My r-b still
holds.
-Daniel
>
> >
> > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
> > index 4dd499c7d1ba..bb379ec4c182 100644
> > --- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
> > +++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
> > @@ -256,6 +256,8 @@ static int cirrus_fbdev_destroy(struct drm_device *dev,
> > {
> > struct drm_framebuffer *gfb = gfbdev->gfb;
> >
> > + drm_crtc_force_disable_all(dev);
> > +
> > drm_fb_helper_unregister_fbi(&gfbdev->helper);
> >
> > vfree(gfbdev->sysram);
> > --
> > 2.20.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/cirrus: fix connector leak at unload
2019-01-11 22:16 ` Daniel Vetter
@ 2019-01-14 7:38 ` Gerd Hoffmann
0 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2019-01-14 7:38 UTC (permalink / raw)
To: Rob Clark, dri-devel, Rob Clark, Daniel Stone, David Airlie,
YueHaibing, linux-kernel, virtualization, Thomas Zimmermann,
Dave Airlie, Thierry Reding
On Fri, Jan 11, 2019 at 11:16:38PM +0100, Daniel Vetter wrote:
> On Fri, Jan 11, 2019 at 11:06:20PM +0100, Daniel Vetter wrote:
> > On Fri, Jan 11, 2019 at 09:02:34AM -0500, Rob Clark wrote:
> > > This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
> > >
> > > Signed-off-by: Rob Clark <robdclark@gmail.com>
> > > ---
> > > Similar case to the issue that was fixed recently in drm/ast
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Actually I just pushed a patch to drm-misc-next to rename this function to
> drm_helper_force_disable_all(), so you need to respin ... My r-b still
> holds.
Fixed and queued up.
thanks,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-14 7:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 14:02 [PATCH] drm/cirrus: fix connector leak at unload Rob Clark
2019-01-11 22:06 ` Daniel Vetter
2019-01-11 22:16 ` Daniel Vetter
2019-01-14 7:38 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).