linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] etnaviv: allow to build on ARC
@ 2019-01-14 16:31 Eugeniy Paltsev
  2019-01-16 16:21 ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Eugeniy Paltsev @ 2019-01-14 16:31 UTC (permalink / raw)
  To: etnaviv
  Cc: dri-devel, Lucas Stach, Russell King, Christian Gmeiner,
	linux-snps-arc, linux-kernel, Vineet Gupta, Alexey Brodkin,
	Eugeniy Paltsev

ARC HSDK SoC has Vivante GPU IP so allow build etnaviv for ARC.

Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
---
 drivers/gpu/drm/etnaviv/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig
index 342591a1084e..49a9957c3373 100644
--- a/drivers/gpu/drm/etnaviv/Kconfig
+++ b/drivers/gpu/drm/etnaviv/Kconfig
@@ -2,7 +2,7 @@
 config DRM_ETNAVIV
 	tristate "ETNAVIV (DRM support for Vivante GPU IP cores)"
 	depends on DRM
-	depends on ARCH_MXC || ARCH_DOVE || ARM || COMPILE_TEST
+	depends on ARCH_MXC || ARCH_DOVE || ARM || ARC || COMPILE_TEST
 	depends on MMU
 	select SHMEM
 	select SYNC_FILE
-- 
2.14.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] etnaviv: allow to build on ARC
  2019-01-14 16:31 [PATCH] etnaviv: allow to build on ARC Eugeniy Paltsev
@ 2019-01-16 16:21 ` Christoph Hellwig
  2019-01-16 16:25   ` Lucas Stach
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2019-01-16 16:21 UTC (permalink / raw)
  To: Eugeniy Paltsev
  Cc: etnaviv, dri-devel, Lucas Stach, Russell King, Christian Gmeiner,
	linux-snps-arc, linux-kernel, Vineet Gupta, Alexey Brodkin

On Mon, Jan 14, 2019 at 07:31:57PM +0300, Eugeniy Paltsev wrote:
> ARC HSDK SoC has Vivante GPU IP so allow build etnaviv for ARC.
> 
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
>  drivers/gpu/drm/etnaviv/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig
> index 342591a1084e..49a9957c3373 100644
> --- a/drivers/gpu/drm/etnaviv/Kconfig
> +++ b/drivers/gpu/drm/etnaviv/Kconfig
> @@ -2,7 +2,7 @@
>  config DRM_ETNAVIV
>  	tristate "ETNAVIV (DRM support for Vivante GPU IP cores)"
>  	depends on DRM
> -	depends on ARCH_MXC || ARCH_DOVE || ARM || COMPILE_TEST
> +	depends on ARCH_MXC || ARCH_DOVE || ARM || ARC || COMPILE_TEST

Is there any reason to not just remove the dependencies entirely?
It seems like it could literally build everywhere, and who knows what
other SOCs the IP blocks end up in sooner or later?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] etnaviv: allow to build on ARC
  2019-01-16 16:21 ` Christoph Hellwig
@ 2019-01-16 16:25   ` Lucas Stach
  0 siblings, 0 replies; 3+ messages in thread
From: Lucas Stach @ 2019-01-16 16:25 UTC (permalink / raw)
  To: Christoph Hellwig, Eugeniy Paltsev
  Cc: etnaviv, dri-devel, Russell King, Christian Gmeiner,
	linux-snps-arc, linux-kernel, Vineet Gupta, Alexey Brodkin

Am Mittwoch, den 16.01.2019, 08:21 -0800 schrieb Christoph Hellwig:
> On Mon, Jan 14, 2019 at 07:31:57PM +0300, Eugeniy Paltsev wrote:
> > ARC HSDK SoC has Vivante GPU IP so allow build etnaviv for ARC.
> > 
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> > ---
> >  drivers/gpu/drm/etnaviv/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/etnaviv/Kconfig
> > b/drivers/gpu/drm/etnaviv/Kconfig
> > index 342591a1084e..49a9957c3373 100644
> > --- a/drivers/gpu/drm/etnaviv/Kconfig
> > +++ b/drivers/gpu/drm/etnaviv/Kconfig
> > @@ -2,7 +2,7 @@
> >  config DRM_ETNAVIV
> >  	tristate "ETNAVIV (DRM support for Vivante GPU IP cores)"
> >  	depends on DRM
> > -	depends on ARCH_MXC || ARCH_DOVE || ARM || COMPILE_TEST
> > +	depends on ARCH_MXC || ARCH_DOVE || ARM || ARC ||
> > COMPILE_TEST
> 
> Is there any reason to not just remove the dependencies entirely?
> It seems like it could literally build everywhere, and who knows what
> other SOCs the IP blocks end up in sooner or later?

I've just sent out a patch to do exactly this instead of playing whack-
a-mole with all the architectures. The patch has been chewed on by the
0-day robot since yesterday and didn't turn up any obvious fallout yet.

Regards,
Lucas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-16 16:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 16:31 [PATCH] etnaviv: allow to build on ARC Eugeniy Paltsev
2019-01-16 16:21 ` Christoph Hellwig
2019-01-16 16:25   ` Lucas Stach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).