* [PATCH 1/2] tracing: annotate implicit fall through
@ 2019-01-14 20:30 Mathieu Malaterre
2019-01-14 20:30 ` [PATCH 2/2] " Mathieu Malaterre
2019-01-14 21:34 ` [PATCH 1/2] " Steven Rostedt
0 siblings, 2 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2019-01-14 20:30 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Mathieu Malaterre, Ingo Molnar, linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).
This commit remove the following warning:
kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
kernel/trace/trace_probe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 9962cb5da8ac..89da34b326e3 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -300,6 +300,7 @@ parse_probe_arg(char *arg, const struct fetch_type *type,
case '+': /* deref memory */
arg++; /* Skip '+', because kstrtol() rejects it. */
+ /* fall through */
case '-':
tmp = strchr(arg, '(');
if (!tmp)
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] tracing: annotate implicit fall through
2019-01-14 20:30 [PATCH 1/2] tracing: annotate implicit fall through Mathieu Malaterre
@ 2019-01-14 20:30 ` Mathieu Malaterre
2019-01-14 21:34 ` [PATCH 1/2] " Steven Rostedt
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2019-01-14 20:30 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Mathieu Malaterre, Ingo Molnar, linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).
This commit remove the following warning:
kernel/trace/trace_events_filter.c:494:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
kernel/trace/trace_events_filter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 27821480105e..eb694756c4bb 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -495,6 +495,7 @@ predicate_parse(const char *str, int nr_parens, int nr_preds,
ptr++;
break;
}
+ /* fall through */
default:
parse_error(pe, FILT_ERR_TOO_MANY_PREDS,
next - str);
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] tracing: annotate implicit fall through
2019-01-14 20:30 [PATCH 1/2] tracing: annotate implicit fall through Mathieu Malaterre
2019-01-14 20:30 ` [PATCH 2/2] " Mathieu Malaterre
@ 2019-01-14 21:34 ` Steven Rostedt
1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2019-01-14 21:34 UTC (permalink / raw)
To: Mathieu Malaterre; +Cc: Ingo Molnar, linux-kernel
On Mon, 14 Jan 2019 21:30:37 +0100
Mathieu Malaterre <malat@debian.org> wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
> kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
I'm pulling this in, but I'm changing the subject. Even when doing
clean ups, don't use the exact same subject for multiple patches, it
gets confusing when looking for a specific change.
Also, Linus prefers that a subject header starts with a capital letter.
[PATCH 1/2] tracing: Annotate implicit fall through in parse_probe_arg()
-- Steve
> ---
> kernel/trace/trace_probe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 9962cb5da8ac..89da34b326e3 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -300,6 +300,7 @@ parse_probe_arg(char *arg, const struct fetch_type *type,
>
> case '+': /* deref memory */
> arg++; /* Skip '+', because kstrtol() rejects it. */
> + /* fall through */
> case '-':
> tmp = strchr(arg, '(');
> if (!tmp)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-14 21:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 20:30 [PATCH 1/2] tracing: annotate implicit fall through Mathieu Malaterre
2019-01-14 20:30 ` [PATCH 2/2] " Mathieu Malaterre
2019-01-14 21:34 ` [PATCH 1/2] " Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).