From: Mathieu Malaterre <malat@debian.org>
To: Alexei Starovoitov <ast@kernel.org>
Cc: Mathieu Malaterre <malat@debian.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] bpf: annotate implicit fall through
Date: Mon, 14 Jan 2019 21:29:41 +0100 [thread overview]
Message-ID: <20190114202941.16183-2-malat@debian.org> (raw)
In-Reply-To: <20190114202941.16183-1-malat@debian.org>
There is a plan to build the kernel with -Wimplicit-fallthrough and
thise place in the code produced a warnings (W=1).
In this particular case change a ‘:’ with a ‘,’ so as to match the
regular expression expected by GCC.
This commit remove the following warning:
net/core/filter.c:5310:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
net/core/filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index 447dd1bad31f..c8069a142994 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -5309,7 +5309,7 @@ bpf_base_func_proto(enum bpf_func_id func_id)
case BPF_FUNC_trace_printk:
if (capable(CAP_SYS_ADMIN))
return bpf_get_trace_printk_proto();
- /* else: fall through */
+ /* else, fall through */
default:
return NULL;
}
--
2.19.2
next prev parent reply other threads:[~2019-01-14 20:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 20:29 [PATCH 1/2] bpf: annotate implicit fall through Mathieu Malaterre
2019-01-14 20:29 ` Mathieu Malaterre [this message]
2019-01-15 9:03 ` [PATCH 2/2] " Sergei Shtylyov
2019-01-15 20:01 ` Daniel Borkmann
2019-01-16 19:35 ` [PATCH v2 2/2] bpf: Correctly annotate implicit fall through in bpf_base_func_proto Mathieu Malaterre
2019-01-16 19:32 ` [PATCH v2 1/2] bpf: Annotate implicit fall through in cgroup_dev_func_proto Mathieu Malaterre
2019-01-16 19:35 ` Mathieu Malaterre
2019-01-17 15:57 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114202941.16183-2-malat@debian.org \
--to=malat@debian.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).