linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Mathieu Malaterre <malat@debian.org>,
	Alexei Starovoitov <ast@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] bpf: annotate implicit fall through
Date: Tue, 15 Jan 2019 21:01:07 +0100	[thread overview]
Message-ID: <79030d7e-4db4-c03a-b2e0-53f1b30e0924@iogearbox.net> (raw)
In-Reply-To: <476963d1-fc1a-b185-6b33-c780fbb009c5@cogentembedded.com>

On 01/15/2019 10:03 AM, Sergei Shtylyov wrote:
> On 14.01.2019 23:29, Mathieu Malaterre wrote:
> 
>> There is a plan to build the kernel with -Wimplicit-fallthrough and
>> thise place in the code produced a warnings (W=1).
> 
>    This?
> 
>> In this particular case change a ‘:’ with a ‘,’ so as to match the
>> regular expression expected by GCC.
>>
>> This commit remove the following warning:
>>
>>    net/core/filter.c:5310:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>

Please respin and also make the two subject lines not exactly the same.

Thanks,
Daniel

>> ---
>>   net/core/filter.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/core/filter.c b/net/core/filter.c
>> index 447dd1bad31f..c8069a142994 100644
>> --- a/net/core/filter.c
>> +++ b/net/core/filter.c
>> @@ -5309,7 +5309,7 @@ bpf_base_func_proto(enum bpf_func_id func_id)
>>       case BPF_FUNC_trace_printk:
>>           if (capable(CAP_SYS_ADMIN))
>>               return bpf_get_trace_printk_proto();
>> -        /* else: fall through */
>> +        /* else, fall through */
> 
>    The other patches seem to just drop "else:"...
> 
>>       default:
>>           return NULL;
>>       }
>>
> 
> MBR, Sergei


  reply	other threads:[~2019-01-15 20:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 20:29 [PATCH 1/2] bpf: annotate implicit fall through Mathieu Malaterre
2019-01-14 20:29 ` [PATCH 2/2] " Mathieu Malaterre
2019-01-15  9:03   ` Sergei Shtylyov
2019-01-15 20:01     ` Daniel Borkmann [this message]
2019-01-16 19:35   ` [PATCH v2 2/2] bpf: Correctly annotate implicit fall through in bpf_base_func_proto Mathieu Malaterre
2019-01-16 19:32 ` [PATCH v2 1/2] bpf: Annotate implicit fall through in cgroup_dev_func_proto Mathieu Malaterre
2019-01-16 19:35 ` Mathieu Malaterre
2019-01-17 15:57   ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79030d7e-4db4-c03a-b2e0-53f1b30e0924@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malat@debian.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).