* [PATCH 1/3] staging: rtl8188eu: remove unnecessary parentheses in os_intfs.c
@ 2019-01-15 8:24 Michael Straube
2019-01-15 8:24 ` [PATCH 2/3] staging: rtl8188eu: cleanup declarations " Michael Straube
2019-01-15 8:24 ` [PATCH 3/3] staging: rtl8188eu: add spaces around operators " Michael Straube
0 siblings, 2 replies; 5+ messages in thread
From: Michael Straube @ 2019-01-15 8:24 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Michael Straube
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index abcce2240f15..6681383579ee 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -198,8 +198,8 @@ static int rtw_net_set_mac_address(struct net_device *pnetdev, void *p)
static struct net_device_stats *rtw_net_get_stats(struct net_device *pnetdev)
{
struct adapter *padapter = (struct adapter *)rtw_netdev_priv(pnetdev);
- struct xmit_priv *pxmitpriv = &(padapter->xmitpriv);
- struct recv_priv *precvpriv = &(padapter->recvpriv);
+ struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
+ struct recv_priv *precvpriv = &padapter->recvpriv;
padapter->stats.tx_packets = pxmitpriv->tx_pkts;
padapter->stats.rx_packets = precvpriv->rx_pkts;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] staging: rtl8188eu: cleanup declarations in os_intfs.c
2019-01-15 8:24 [PATCH 1/3] staging: rtl8188eu: remove unnecessary parentheses in os_intfs.c Michael Straube
@ 2019-01-15 8:24 ` Michael Straube
2019-01-15 15:25 ` Greg KH
2019-01-15 8:24 ` [PATCH 3/3] staging: rtl8188eu: add spaces around operators " Michael Straube
1 sibling, 1 reply; 5+ messages in thread
From: Michael Straube @ 2019-01-15 8:24 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Michael Straube
Replace tabs with spaces and/or remove extra spaces in declarations.
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 6681383579ee..6ed4a06a0796 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -137,7 +137,7 @@ static int netdev_close(struct net_device *pnetdev);
static void loadparam(struct adapter *padapter, struct net_device *pnetdev)
{
- struct registry_priv *registry_par = &padapter->registrypriv;
+ struct registry_priv *registry_par = &padapter->registrypriv;
GlobalDebugLevel = rtw_debug;
@@ -248,7 +248,7 @@ static u16 rtw_select_queue(struct net_device *dev, struct sk_buff *skb,
struct net_device *sb_dev,
select_queue_fallback_t fallback)
{
- struct adapter *padapter = rtw_netdev_priv(dev);
+ struct adapter *padapter = rtw_netdev_priv(dev);
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
skb->priority = rtw_classify8021d(skb);
@@ -263,7 +263,7 @@ u16 rtw_recv_select_queue(struct sk_buff *skb)
{
struct iphdr *piphdr;
unsigned int dscp;
- __be16 eth_type;
+ __be16 eth_type;
u32 priority;
u8 *pdata = skb->data;
@@ -286,7 +286,7 @@ static const struct net_device_ops rtw_netdev_ops = {
.ndo_open = netdev_open,
.ndo_stop = netdev_close,
.ndo_start_xmit = rtw_xmit_entry,
- .ndo_select_queue = rtw_select_queue,
+ .ndo_select_queue = rtw_select_queue,
.ndo_set_mac_address = rtw_net_set_mac_address,
.ndo_get_stats = rtw_net_get_stats,
.ndo_do_ioctl = rtw_ioctl,
@@ -361,7 +361,7 @@ void rtw_stop_drv_threads(struct adapter *padapter)
static u8 rtw_init_default_value(struct adapter *padapter)
{
struct registry_priv *pregistrypriv = &padapter->registrypriv;
- struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
+ struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct security_priv *psecuritypriv = &padapter->securitypriv;
@@ -431,7 +431,7 @@ u8 rtw_reset_drv_sw(struct adapter *padapter)
u8 rtw_init_drv_sw(struct adapter *padapter)
{
- u8 ret8 = _SUCCESS;
+ u8 ret8 = _SUCCESS;
RT_TRACE(_module_os_intfs_c_, _drv_info_, ("+rtw_init_drv_sw\n"));
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] staging: rtl8188eu: add spaces around operators in os_intfs.c
2019-01-15 8:24 [PATCH 1/3] staging: rtl8188eu: remove unnecessary parentheses in os_intfs.c Michael Straube
2019-01-15 8:24 ` [PATCH 2/3] staging: rtl8188eu: cleanup declarations " Michael Straube
@ 2019-01-15 8:24 ` Michael Straube
2019-01-15 15:25 ` Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Michael Straube @ 2019-01-15 8:24 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Michael Straube
Add spaces around '+', '<<' and '*' to follow kernel coding style.
Reported by checkpatch.
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 6ed4a06a0796..dfba6b725790 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -267,11 +267,11 @@ u16 rtw_recv_select_queue(struct sk_buff *skb)
u32 priority;
u8 *pdata = skb->data;
- memcpy(ð_type, pdata+(ETH_ALEN<<1), 2);
+ memcpy(ð_type, pdata + (ETH_ALEN << 1), 2);
switch (eth_type) {
case htons(ETH_P_IP):
- piphdr = (struct iphdr *)(pdata+ETH_HLEN);
+ piphdr = (struct iphdr *)(pdata + ETH_HLEN);
dscp = piphdr->tos & 0xfc;
priority = dscp >> 5;
break;
@@ -323,7 +323,7 @@ struct net_device *rtw_init_netdev(struct adapter *old_padapter)
padapter->pnetdev = pnetdev;
DBG_88E("register rtw_netdev_ops to netdev_ops\n");
pnetdev->netdev_ops = &rtw_netdev_ops;
- pnetdev->watchdog_timeo = HZ*3; /* 3 second timeout */
+ pnetdev->watchdog_timeo = HZ * 3; /* 3 second timeout */
pnetdev->wireless_handlers = (struct iw_handler_def *)&rtw_handlers_def;
loadparam(padapter, pnetdev);
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] staging: rtl8188eu: cleanup declarations in os_intfs.c
2019-01-15 8:24 ` [PATCH 2/3] staging: rtl8188eu: cleanup declarations " Michael Straube
@ 2019-01-15 15:25 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-01-15 15:25 UTC (permalink / raw)
To: Michael Straube; +Cc: devel, linux-kernel
On Tue, Jan 15, 2019 at 09:24:01AM +0100, Michael Straube wrote:
> Replace tabs with spaces and/or remove extra spaces in declarations.
> ---
> drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
No signed off by :(
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] staging: rtl8188eu: add spaces around operators in os_intfs.c
2019-01-15 8:24 ` [PATCH 3/3] staging: rtl8188eu: add spaces around operators " Michael Straube
@ 2019-01-15 15:25 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-01-15 15:25 UTC (permalink / raw)
To: Michael Straube; +Cc: devel, linux-kernel
On Tue, Jan 15, 2019 at 09:24:02AM +0100, Michael Straube wrote:
> Add spaces around '+', '<<' and '*' to follow kernel coding style.
> Reported by checkpatch.
> ---
> drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
No signed-off-by :(
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-15 15:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-15 8:24 [PATCH 1/3] staging: rtl8188eu: remove unnecessary parentheses in os_intfs.c Michael Straube
2019-01-15 8:24 ` [PATCH 2/3] staging: rtl8188eu: cleanup declarations " Michael Straube
2019-01-15 15:25 ` Greg KH
2019-01-15 8:24 ` [PATCH 3/3] staging: rtl8188eu: add spaces around operators " Michael Straube
2019-01-15 15:25 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).