From: Christoph Hellwig <hch@infradead.org>
To: Anup Patel <anup@brainfault.org>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <atish.patra@wdc.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/5] irqchip: sifive-plic: Don't inline plic_toggle() and plic_irq_toggle()
Date: Tue, 15 Jan 2019 07:54:37 -0800 [thread overview]
Message-ID: <20190115155437.GA13095@infradead.org> (raw)
In-Reply-To: <20181227111821.80908-3-anup@brainfault.org>
On Thu, Dec 27, 2018 at 04:48:18PM +0530, Anup Patel wrote:
> The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a
> for loop so both these functions are not suitable for being inline
> hence this patch removes the inline keyword.
That is a weird argument for a function which has by design exactly
two callers and is in the hot path. The alternative to the inline
here would be to duplicate the code.
next prev parent reply other threads:[~2019-01-15 15:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 11:18 [PATCH v4 0/5] IRQ affinity support in PLIC driver Anup Patel
2018-12-27 11:18 ` [PATCH v4 1/5] irqchip: sifive-plic: Pre-compute context hart base and enable base Anup Patel
2018-12-27 11:18 ` [PATCH v4 2/5] irqchip: sifive-plic: Don't inline plic_toggle() and plic_irq_toggle() Anup Patel
2019-01-15 15:54 ` Christoph Hellwig [this message]
2019-01-19 5:00 ` Anup Patel
2018-12-27 11:18 ` [PATCH v4 3/5] irqchip: sifive-plic: Add warning in plic_init() if handler already present Anup Patel
2019-01-15 15:54 ` Christoph Hellwig
2019-01-19 5:03 ` Anup Patel
2018-12-27 11:18 ` [PATCH v4 4/5] irqchip: sifive-plic: Differentiate between PLIC handler and context Anup Patel
2019-01-15 15:56 ` Christoph Hellwig
2019-01-19 5:25 ` Anup Patel
2018-12-27 11:18 ` [PATCH v4 5/5] irqchip: sifive-plic: Implement irq_set_affinity() for SMP host Anup Patel
2019-01-15 15:57 ` Christoph Hellwig
2019-01-19 5:26 ` Anup Patel
2019-01-08 12:14 ` [PATCH v4 0/5] IRQ affinity support in PLIC driver Anup Patel
2019-01-23 18:57 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115155437.GA13095@infradead.org \
--to=hch@infradead.org \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=palmer@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).