From: Eric Biggers <ebiggers@kernel.org>
To: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
broonie@kernel.org, ard.biesheuvel@linaro.org,
jonathan.cameron@huawei.com
Subject: Re: [PATCH 0/5] Crypto Cleanup
Date: Wed, 16 Jan 2019 09:49:51 -0800 [thread overview]
Message-ID: <20190116174949.GA152952@gmail.com> (raw)
In-Reply-To: <1547607034-40948-1-git-send-email-wangxiongfeng2@huawei.com>
On Wed, Jan 16, 2019 at 10:50:29AM +0800, Xiongfeng Wang wrote:
> The patchset introduce a helper to (un)register a array of crypto templates.
> The following patches use this helper to simplify the code. This is also
> a preparation for a coming patchset, which will register several crypto
> templates.
>
> Xiongfeng Wang (5):
> crypto: api - add a helper to (un)register a array of templates
> crypto: ccm - use template array registering API to simplify the code
> crypto: gcm - use template array registering API to simplify the code
> crypto: ctr - use template array registering API to simplify the code
> crypto: chacha20poly1305 - use template array registering API to
> simplify the code
>
> crypto/algapi.c | 27 ++++++++++++++++
> crypto/ccm.c | 81 +++++++++++++++--------------------------------
> crypto/chacha20poly1305.c | 38 +++++++++-------------
> crypto/ctr.c | 46 ++++++++++-----------------
> crypto/gcm.c | 76 +++++++++++++++-----------------------------
> include/crypto/algapi.h | 2 ++
> 6 files changed, 113 insertions(+), 157 deletions(-)
>
> --
> 1.7.12.4
>
Hi Xiongfeng, I think this a useful cleanup but can you please rebase this onto
cryptodev? There is a conflict in crypto/ctr.c.
- Eric
next prev parent reply other threads:[~2019-01-16 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 2:50 [PATCH 0/5] Crypto Cleanup Xiongfeng Wang
2019-01-16 2:50 ` [PATCH 1/5] crypto: api - add a helper to (un)register a array of templates Xiongfeng Wang
2019-01-16 17:52 ` Eric Biggers
2019-01-16 2:50 ` [PATCH 2/5] crypto: ccm - use template array registering API to simplify the code Xiongfeng Wang
2019-01-16 17:57 ` Eric Biggers
2019-01-16 2:50 ` [PATCH 3/5] crypto: gcm " Xiongfeng Wang
2019-01-16 2:50 ` [PATCH 4/5] crypto: ctr " Xiongfeng Wang
2019-01-16 2:50 ` [PATCH 5/5] crypto: chacha20poly1305 " Xiongfeng Wang
2019-01-16 17:49 ` Eric Biggers [this message]
2019-01-17 2:50 ` [PATCH 0/5] Crypto Cleanup Xiongfeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116174949.GA152952@gmail.com \
--to=ebiggers@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jonathan.cameron@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).